| Message ID | 1366251498-11677-1-git-send-email-festevam@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Fabio, On 18/04/13 12:18, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > There is nothing in the driver that requires asm header files. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > Greg, > > I built this for ARM and x86 (tweaking Kconfig), but I don't have a m68k > toolchain installed here to test it. > > Please build it for m68k if you have a chance. Thanks > > drivers/net/ethernet/freescale/fec_main.c | 7 ------- fec_main.c? It doesn't exist in 3.9-rc7. Comments and tests below based on fec.c in 3.9-rc7. > 1 file changed, 7 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c > index 719177b..22c0feb 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -50,13 +50,6 @@ > #include <linux/pinctrl/consumer.h> > #include <linux/regulator/consumer.h> > > -#include <asm/cacheflush.h> There is a very bogus looking call to flush_cache_all() conditional on CONFIG_M532x, and I suspect this won't compile if you take this out. > - > -#ifndef CONFIG_ARM > -#include <asm/coldfire.h> > -#include <asm/mcfsim.h> > -#endif No problem with this part. I tested on a couple of ColdFire targets with this and they still compile ok. Regards Greg -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Fabio, On 18/04/13 12:18, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > There is nothing in the driver that requires asm header files. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > Greg, > > I built this for ARM and x86 (tweaking Kconfig), but I don't have a m68k > toolchain installed here to test it. > > Please build it for m68k if you have a chance. Thanks > > drivers/net/ethernet/freescale/fec_main.c | 7 ------- fec_main.c? That doesn't exist in linux-3.9-rc7. Comments and tests below based on fec.c in linux-3.9-rc7. > 1 file changed, 7 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c > index 719177b..22c0feb 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -50,13 +50,6 @@ > #include <linux/pinctrl/consumer.h> > #include <linux/regulator/consumer.h> > > -#include <asm/cacheflush.h> There is a rather bogus looking call to flush_cache_all() conditional on CONFIG_M532x, and I suspect removing this include will break that. > - > -#ifndef CONFIG_ARM > -#include <asm/coldfire.h> > -#include <asm/mcfsim.h> > -#endif No problem with this part. I compiled for a couple of ColdFire targets and this is ok. Regards Greg -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Greg, On Thu, Apr 18, 2013 at 9:00 AM, Greg Ungerer <gerg@uclinux.org> wrote: > fec_main.c? That doesn't exist in linux-3.9-rc7. > Comments and tests below based on fec.c in linux-3.9-rc7. Yes, fec.c got was renamed to fec_main.c in net-next: https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/tree/drivers/net/ethernet/freescale/fec_main.c >> -#include <asm/cacheflush.h> > > There is a rather bogus looking call to flush_cache_all() conditional > on CONFIG_M532x, and I suspect removing this include will break that. Ok, will keep <asm/cacheflush.h> in v2 then. >> -#ifndef CONFIG_ARM >> -#include <asm/coldfire.h> >> -#include <asm/mcfsim.h> >> -#endif > > No problem with this part. I compiled for a couple of ColdFire targets > and this is ok. Thanks for testing, Greg. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Greg Ungerer <gregungerer00@gmail.com> Date: Thu, 18 Apr 2013 21:56:43 +1000 > Hi Fabio, > > On 18/04/13 12:18, Fabio Estevam wrote: >> From: Fabio Estevam <fabio.estevam@freescale.com> >> >> There is nothing in the driver that requires asm header files. >> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >> --- >> Greg, >> >> I built this for ARM and x86 (tweaking Kconfig), but I don't have a m68k >> toolchain installed here to test it. >> >> Please build it for m68k if you have a chance. Thanks >> >> drivers/net/ethernet/freescale/fec_main.c | 7 ------- > > fec_main.c? It doesn't exist in 3.9-rc7. > Comments and tests below based on fec.c in 3.9-rc7. That's where the driver is in net-next, which cleanups such as this should be targetted. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 719177b..22c0feb 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -50,13 +50,6 @@ #include <linux/pinctrl/consumer.h> #include <linux/regulator/consumer.h> -#include <asm/cacheflush.h> - -#ifndef CONFIG_ARM -#include <asm/coldfire.h> -#include <asm/mcfsim.h> -#endif - #include "fec.h" #if defined(CONFIG_ARM)