diff mbox

[1/2] powerpc/83xx: Fix missing #{address,size}-cells in mpc8313erdb.dts

Message ID 20090205201032.GA3425@oksana.dev.rtsoft.ru (mailing list archive)
State Accepted, archived
Commit 1f0d4d16d9d4ffa65438425d092f7061476b95b3
Delegated to: Kumar Gala
Headers show

Commit Message

Anton Vorontsov Feb. 5, 2009, 8:10 p.m. UTC
commit b31a1d8b41513b96e9c7ec2f68c5734cef0b26a4 ("gianfar: Convert
gianfar to an of_platform_driver") introduced a child node for
the ethernet@25000 controller, but no address and size cells
specifiers were added, and that makes dtc unhappy:

DTC: dts->dtb  on file "arch/powerpc/boot/dts/mpc8313erdb.dts"
Warning (reg_format): "reg" property in /soc8313@e0000000/ethernet@25000/mdio@25520 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc8313@e0000000/ethernet@25000/mdio@25520
Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc8313@e0000000/ethernet@25000/mdio@25520

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 arch/powerpc/boot/dts/mpc8313erdb.dts |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Kumar Gala Feb. 6, 2009, 4:39 p.m. UTC | #1
On Feb 5, 2009, at 2:10 PM, Anton Vorontsov wrote:

> commit b31a1d8b41513b96e9c7ec2f68c5734cef0b26a4 ("gianfar: Convert
> gianfar to an of_platform_driver") introduced a child node for
> the ethernet@25000 controller, but no address and size cells
> specifiers were added, and that makes dtc unhappy:
>
> DTC: dts->dtb  on file "arch/powerpc/boot/dts/mpc8313erdb.dts"
> Warning (reg_format): "reg" property in /soc8313@e0000000/ 
> ethernet@25000/mdio@25520 has invalid length (8 bytes) (#address- 
> cells == 2, #size-cells == 1)
> Warning (avoid_default_addr_size): Relying on default #address-cells  
> value for /soc8313@e0000000/ethernet@25000/mdio@25520
> Warning (avoid_default_addr_size): Relying on default #size-cells  
> value for /soc8313@e0000000/ethernet@25000/mdio@25520
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/mpc8313erdb.dts |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)

applied to merge

- k
diff mbox

Patch

diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/boot/dts/mpc8313erdb.dts
index 909a89c..3f84cd0 100644
--- a/arch/powerpc/boot/dts/mpc8313erdb.dts
+++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
@@ -219,6 +219,8 @@ 
 		};
 
 		enet1: ethernet@25000 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			cell-index = <1>;
 			device_type = "network";
 			model = "eTSEC";