mbox

[pull,request,v4] Pull request for branch yem-ext234

Message ID cover.1365718555.git.yann.morin.1998@free.fr
State Accepted
Headers show

Pull-request

git://gitorious.org/buildroot/buildroot.git yem-ext234

Message

Yann E. MORIN April 11, 2013, 10:17 p.m. UTC 
Hello All!

This patch series enhances the ext2 fs backend to also build ext3 and ext4
filesystems, and differentiate between ext2 rev0 and ext2 rev1 filesystems.


Changes v3 -> v4:
  - rebased ontop master for Peter

Changes v2 -> v3:
  - cleanup ext2 dependencies  (Thomas)
  - explain UUID removal  (Thomas)
  - use post-hook to create "ext# -> ext2" symlink  (Thomas, Arnout)
  - drop patch to let fs name the image file extension  (Thomas, Arnout)

Changes v1 -> v2:
  - enhance the ext2/3/4 generation  (Arnout, Peter)
  - allow fs generators to specify the image extension  (Arnout)
  - remove ext2 count- and time-based fsck  (Arnout)


The following changes since commit 2c4ff68e08e063152245d0a1b211df7a4360f925:

  system/securetty: Add ttyPS[0-1] (2013-04-11 23:32:11 +0200)

are available in the git repository at:
  git://gitorious.org/buildroot/buildroot.git yem-ext234

Yann E. MORIN (5):
      fs/ext2: enclose the ext2 options in if...endif
      fs/ext2: add ability to build ext3/4 too
      fs/ext2: add a symlink 'rootfs.ext#' -> 'rootfs.ext2'
      fs/ext2: add support for ext2 rev0 and rev1
      fs/ext2: remove count- and time-based fsck

 fs/ext2/Config.in                |   57 +++++++++++++++++++++-----
 fs/ext2/ext2.mk                  |   14 ++++++-
 fs/ext2/genext2fs.sh             |   82 +++++++++++++++++++++++++++++++++++++-
 package/e2fsprogs/Config.in.host |    2 +-
 4 files changed, 140 insertions(+), 15 deletions(-)

Regards,
Yann E. MORIN

Comments

Peter Korsgaard April 12, 2013, 1 p.m. UTC | #1 
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 Yann> Hello All!

 Yann> This patch series enhances the ext2 fs backend to also build ext3
 Yann> and ext4 filesystems, and differentiate between ext2 rev0 and
 Yann> ext2 rev1 filesystems.

Committed series, thanks.

Notice: I did a quick test with a smallish ext4 (3.5MB) filesystem,
where the 1081 blocks extra for the journal wasn't enough, so I've
increased it to 1300 instead.
Yann E. MORIN April 12, 2013, 3:53 p.m. UTC | #2 
Peter, All,

On Fri, Apr 12, 2013 at 03:00:45PM +0200, Peter Korsgaard wrote:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>  Yann> This patch series enhances the ext2 fs backend to also build ext3
>  Yann> and ext4 filesystems, and differentiate between ext2 rev0 and
>  Yann> ext2 rev1 filesystems.
[--SNIP--]
> Notice: I did a quick test with a smallish ext4 (3.5MB) filesystem,
> where the 1081 blocks extra for the journal wasn't enough, so I've
> increased it to 1300 instead.

Strange, Thomas had the same issue, which I was notable to reproduce
here with a basic busybox-only file system (roughly 3.5MiB here too).

Anyway, thanks for the fix up. Indeed, systems going for ext3/4 will
probably not be much impacted by the few extra sectors.

Regards,
Yann E. MORIN.