diff mbox

[U-Boot,V3,1/3] OMAP5: I2C: Enable i2c5 clocks

Message ID 51629CEC.6000008@mm-sol.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Lubomir Popov April 8, 2013, 10:33 a.m. UTC
Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
---
V3 consolidates this patch into a series.

 arch/arm/cpu/armv7/omap5/hw_data.c |    1 +
 1 file changed, 1 insertion(+)

Comments

SRICHARAN R April 9, 2013, 6:34 a.m. UTC | #1
Hi Lubomir,

On Monday 08 April 2013 04:03 PM, Lubomir Popov wrote:
> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
> ---
> V3 consolidates this patch into a series.
> 
>  arch/arm/cpu/armv7/omap5/hw_data.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c
> index e5e41fd..5698876 100644
> --- a/arch/arm/cpu/armv7/omap5/hw_data.c
> +++ b/arch/arm/cpu/armv7/omap5/hw_data.c
> @@ -412,6 +412,7 @@ void enable_basic_uboot_clocks(void)
>  		(*prcm)->cm_l4per_i2c2_clkctrl,
>  		(*prcm)->cm_l4per_i2c3_clkctrl,
>  		(*prcm)->cm_l4per_i2c4_clkctrl,
> +		(*prcm)->cm_l4per_i2c5_clkctrl,
>  		(*prcm)->cm_l3init_hsusbhost_clkctrl,
>  		(*prcm)->cm_l3init_fsusb_clkctrl,
>  		0

  Please note that whatever is above the '----' gets committed.
  So now all the 3 patches will not have any commit message.

Regards,
 Sricharan
Lubomir Popov April 9, 2013, 6:39 a.m. UTC | #2
Hi Sricharan,

On 09/04/13 09:34, Sricharan R wrote:
> Hi Lubomir,
> 
> On Monday 08 April 2013 04:03 PM, Lubomir Popov wrote:
>> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
>> ---
>> V3 consolidates this patch into a series.
>>
>>  arch/arm/cpu/armv7/omap5/hw_data.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c
>> index e5e41fd..5698876 100644
>> --- a/arch/arm/cpu/armv7/omap5/hw_data.c
>> +++ b/arch/arm/cpu/armv7/omap5/hw_data.c
>> @@ -412,6 +412,7 @@ void enable_basic_uboot_clocks(void)
>>  		(*prcm)->cm_l4per_i2c2_clkctrl,
>>  		(*prcm)->cm_l4per_i2c3_clkctrl,
>>  		(*prcm)->cm_l4per_i2c4_clkctrl,
>> +		(*prcm)->cm_l4per_i2c5_clkctrl,
>>  		(*prcm)->cm_l3init_hsusbhost_clkctrl,
>>  		(*prcm)->cm_l3init_fsusb_clkctrl,
>>  		0
> 
>   Please note that whatever is above the '----' gets committed.
>   So now all the 3 patches will not have any commit message.

Ooops... So much work, so little time... Should I do a V4?

> 
> Regards,
>  Sricharan
>   
> 

Thanks,
Lubo
SRICHARAN R April 9, 2013, 6:42 a.m. UTC | #3
On Tuesday 09 April 2013 12:09 PM, Lubomir Popov wrote:
> Hi Sricharan,
> 
> On 09/04/13 09:34, Sricharan R wrote:
>> Hi Lubomir,
>>
>> On Monday 08 April 2013 04:03 PM, Lubomir Popov wrote:
>>> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
>>> ---
>>> V3 consolidates this patch into a series.
>>>
>>>  arch/arm/cpu/armv7/omap5/hw_data.c |    1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c
>>> index e5e41fd..5698876 100644
>>> --- a/arch/arm/cpu/armv7/omap5/hw_data.c
>>> +++ b/arch/arm/cpu/armv7/omap5/hw_data.c
>>> @@ -412,6 +412,7 @@ void enable_basic_uboot_clocks(void)
>>>  		(*prcm)->cm_l4per_i2c2_clkctrl,
>>>  		(*prcm)->cm_l4per_i2c3_clkctrl,
>>>  		(*prcm)->cm_l4per_i2c4_clkctrl,
>>> +		(*prcm)->cm_l4per_i2c5_clkctrl,
>>>  		(*prcm)->cm_l3init_hsusbhost_clkctrl,
>>>  		(*prcm)->cm_l3init_fsusb_clkctrl,
>>>  		0
>>
>>   Please note that whatever is above the '----' gets committed.
>>   So now all the 3 patches will not have any commit message.
> 
> Ooops... So much work, so little time... Should I do a V4?
> 

ya, because a patch without a commit log would look really blank :)

Regards,
 Sricharan
diff mbox

Patch

diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c
index e5e41fd..5698876 100644
--- a/arch/arm/cpu/armv7/omap5/hw_data.c
+++ b/arch/arm/cpu/armv7/omap5/hw_data.c
@@ -412,6 +412,7 @@  void enable_basic_uboot_clocks(void)
 		(*prcm)->cm_l4per_i2c2_clkctrl,
 		(*prcm)->cm_l4per_i2c3_clkctrl,
 		(*prcm)->cm_l4per_i2c4_clkctrl,
+		(*prcm)->cm_l4per_i2c5_clkctrl,
 		(*prcm)->cm_l3init_hsusbhost_clkctrl,
 		(*prcm)->cm_l3init_fsusb_clkctrl,
 		0