Message ID | 1365442249-18259-1-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
Pulled. Thanks. Regards, Anthony Liguori
On 8 April 2013 18:30, Paolo Bonzini <pbonzini@redhat.com> wrote:
> {hw => include/hw/arm}/devices.h | 0
Just noticed this is wrong -- devices.h contains prototypes
for various miscellaneous devices. For instance sm501
is sh4. This doesn't belong in include/hw/arm/.
(More generally I don't much like the include/hw/$ARCH/
directories -- ideally all these headers should be
replaced by generic manipulations of properties...)
-- PMM
Il 09/04/2013 15:40, Peter Maydell ha scritto: >> > {hw => include/hw/arm}/devices.h | 0 > Just noticed this is wrong -- devices.h contains prototypes > for various miscellaneous devices. For instance sm501 > is sh4. This doesn't belong in include/hw/arm/. I can fix these in a followup. I saw you also pointed to include/hw/arm.h. > (More generally I don't much like the include/hw/$ARCH/ > directories -- ideally all these headers should be > replaced by generic manipulations of properties...) Yes, they should. Paolo