diff mbox

[RESEND] uefirtvariable: add some information for the GetNextVariableName sub-tests

Message ID 1365382388-4069-1-git-send-email-ivan.hu@canonical.com
State Accepted
Headers show

Commit Message

Ivan Hu April 8, 2013, 12:53 a.m. UTC 
From: IvanHu <ivan.hu@canonical.com>

Add more information for testing the GetNextVarialbeName sub-tests.

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/uefi/uefirtvariable/uefirtvariable.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Keng-Yu Lin April 8, 2013, 8:28 a.m. UTC | #1 
On Mon, Apr 8, 2013 at 8:53 AM, Ivan Hu <ivan.hu@canonical.com> wrote:
> From: IvanHu <ivan.hu@canonical.com>
>
> Add more information for testing the GetNextVarialbeName sub-tests.
>
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  src/uefi/uefirtvariable/uefirtvariable.c |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/src/uefi/uefirtvariable/uefirtvariable.c b/src/uefi/uefirtvariable/uefirtvariable.c
> index c5caa33..50e4e3a 100644
> --- a/src/uefi/uefirtvariable/uefirtvariable.c
> +++ b/src/uefi/uefirtvariable/uefirtvariable.c
> @@ -1165,23 +1165,30 @@ static int uefirtvariable_test2(fwts_framework *fw)
>  {
>         int ret;
>
> +       fwts_log_info(fw, "The runtime service GetNextVariableName interface function test.");
>         ret = getnextvariable_test1(fw);
>         if (ret != FWTS_OK)
>                 return ret;
> +       fwts_passed(fw, "The runtime service GetNextVariableName interface function test passed.");
>
> +       fwts_log_info(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName.");
>         ret = getnextvariable_test2(fw);
>         if (ret != FWTS_OK)
>                 return ret;
> +       fwts_passed(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName passed.");
>
> +       fwts_log_info(fw, "Test GetNextVariableName interface returns unique variables.");
>         ret = getnextvariable_test3(fw);
>         if (ret != FWTS_OK)
>                 return ret;
> +       fwts_passed(fw, "Test GetNextVariableName interface returns unique variables passed.");
>
> +       fwts_log_info(fw, "The GetNextVariableName interface conformance tests.");
>         ret = getnextvariable_test4(fw);
>         if (ret != FWTS_OK)
>                 return ret;
> +       fwts_passed(fw, "The runtime service GetNextVariableName interface conformance tests passed.");
>
> -       fwts_passed(fw, "UEFI runtime service GetNextVariableName interface test passed.");
>
>         return FWTS_OK;
>  }
> --
> 1.7.9.5
>
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung April 8, 2013, 8:31 a.m. UTC | #2 
On 04/08/2013 08:53 AM, Ivan Hu wrote:
> From: IvanHu <ivan.hu@canonical.com>
>
> Add more information for testing the GetNextVarialbeName sub-tests.
>
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>   src/uefi/uefirtvariable/uefirtvariable.c |    9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/src/uefi/uefirtvariable/uefirtvariable.c b/src/uefi/uefirtvariable/uefirtvariable.c
> index c5caa33..50e4e3a 100644
> --- a/src/uefi/uefirtvariable/uefirtvariable.c
> +++ b/src/uefi/uefirtvariable/uefirtvariable.c
> @@ -1165,23 +1165,30 @@ static int uefirtvariable_test2(fwts_framework *fw)
>   {
>   	int ret;
>
> +	fwts_log_info(fw, "The runtime service GetNextVariableName interface function test.");
>   	ret = getnextvariable_test1(fw);
>   	if (ret != FWTS_OK)
>   		return ret;
> +	fwts_passed(fw, "The runtime service GetNextVariableName interface function test passed.");
>
> +	fwts_log_info(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName.");
>   	ret = getnextvariable_test2(fw);
>   	if (ret != FWTS_OK)
>   		return ret;
> +	fwts_passed(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName passed.");
>
> +	fwts_log_info(fw, "Test GetNextVariableName interface returns unique variables.");
>   	ret = getnextvariable_test3(fw);
>   	if (ret != FWTS_OK)
>   		return ret;
> +	fwts_passed(fw, "Test GetNextVariableName interface returns unique variables passed.");
>
> +	fwts_log_info(fw, "The GetNextVariableName interface conformance tests.");
>   	ret = getnextvariable_test4(fw);
>   	if (ret != FWTS_OK)
>   		return ret;
> +	fwts_passed(fw, "The runtime service GetNextVariableName interface conformance tests passed.");
>
> -	fwts_passed(fw, "UEFI runtime service GetNextVariableName interface test passed.");
>
>   	return FWTS_OK;
>   }
>
Acked-by: Alex Hung <alex.hung@canonical.com>
Colin Ian King April 8, 2013, 8:32 a.m. UTC | #3 
On 08/04/13 01:53, Ivan Hu wrote:
> From: IvanHu <ivan.hu@canonical.com>
> 
> Add more information for testing the GetNextVarialbeName sub-tests.
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  src/uefi/uefirtvariable/uefirtvariable.c |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/uefi/uefirtvariable/uefirtvariable.c b/src/uefi/uefirtvariable/uefirtvariable.c
> index c5caa33..50e4e3a 100644
> --- a/src/uefi/uefirtvariable/uefirtvariable.c
> +++ b/src/uefi/uefirtvariable/uefirtvariable.c
> @@ -1165,23 +1165,30 @@ static int uefirtvariable_test2(fwts_framework *fw)
>  {
>  	int ret;
>  
> +	fwts_log_info(fw, "The runtime service GetNextVariableName interface function test.");
>  	ret = getnextvariable_test1(fw);
>  	if (ret != FWTS_OK)
>  		return ret;
> +	fwts_passed(fw, "The runtime service GetNextVariableName interface function test passed.");
>  
> +	fwts_log_info(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName.");
>  	ret = getnextvariable_test2(fw);
>  	if (ret != FWTS_OK)
>  		return ret;
> +	fwts_passed(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName passed.");
>  
> +	fwts_log_info(fw, "Test GetNextVariableName interface returns unique variables.");
>  	ret = getnextvariable_test3(fw);
>  	if (ret != FWTS_OK)
>  		return ret;
> +	fwts_passed(fw, "Test GetNextVariableName interface returns unique variables passed.");
>  
> +	fwts_log_info(fw, "The GetNextVariableName interface conformance tests.");
>  	ret = getnextvariable_test4(fw);
>  	if (ret != FWTS_OK)
>  		return ret;
> +	fwts_passed(fw, "The runtime service GetNextVariableName interface conformance tests passed.");
>  
> -	fwts_passed(fw, "UEFI runtime service GetNextVariableName interface test passed.");
>  
>  	return FWTS_OK;
>  }
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
diff mbox

Patch

diff --git a/src/uefi/uefirtvariable/uefirtvariable.c b/src/uefi/uefirtvariable/uefirtvariable.c
index c5caa33..50e4e3a 100644
--- a/src/uefi/uefirtvariable/uefirtvariable.c
+++ b/src/uefi/uefirtvariable/uefirtvariable.c
@@ -1165,23 +1165,30 @@  static int uefirtvariable_test2(fwts_framework *fw)
 {
 	int ret;
 
+	fwts_log_info(fw, "The runtime service GetNextVariableName interface function test.");
 	ret = getnextvariable_test1(fw);
 	if (ret != FWTS_OK)
 		return ret;
+	fwts_passed(fw, "The runtime service GetNextVariableName interface function test passed.");
 
+	fwts_log_info(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName.");
 	ret = getnextvariable_test2(fw);
 	if (ret != FWTS_OK)
 		return ret;
+	fwts_passed(fw, "Check the GetNextVariableName returned value of VariableNameSize is equal to the length of VariableName passed.");
 
+	fwts_log_info(fw, "Test GetNextVariableName interface returns unique variables.");
 	ret = getnextvariable_test3(fw);
 	if (ret != FWTS_OK)
 		return ret;
+	fwts_passed(fw, "Test GetNextVariableName interface returns unique variables passed.");
 
+	fwts_log_info(fw, "The GetNextVariableName interface conformance tests.");
 	ret = getnextvariable_test4(fw);
 	if (ret != FWTS_OK)
 		return ret;
+	fwts_passed(fw, "The runtime service GetNextVariableName interface conformance tests passed.");
 
-	fwts_passed(fw, "UEFI runtime service GetNextVariableName interface test passed.");
 
 	return FWTS_OK;
 }