| Message ID | 1365162493-9415-1-git-send-email-baruch@ev-en.org |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 05-04-2013 15:48, Baruch Even wrote: > Commit message of c78968bb Please also specify the summary line of that commit in parens (or however you like). > by Jeff Garzik says we need to provide the SATL > driver version and not the disk firmware version but the code overwrites the > driver version with the disk version. > Signed-off-by: Baruch Even <baruch@ev-en.org> WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
OK. Resending. On Fri, Apr 5, 2013 at 5:44 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello. > > On 05-04-2013 15:48, Baruch Even wrote: > >> Commit message of c78968bb > > > Please also specify the summary line of that commit in parens (or however > you like). > > >> by Jeff Garzik says we need to provide the SATL >> driver version and not the disk firmware version but the code overwrites >> the >> driver version with the disk version. > > >> Signed-off-by: Baruch Even <baruch@ev-en.org> > > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 318b413..e61a054 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2126,7 +2126,6 @@ static unsigned int ata_scsiop_inq_89(struct ata_scsi_args *args, u8 *rbuf) memcpy(&rbuf[8], "linux ", 8); memcpy(&rbuf[16], "libata ", 16); memcpy(&rbuf[32], DRV_VERSION, 4); - ata_id_string(args->id, &rbuf[32], ATA_ID_FW_REV, 4); /* we don't store the ATA device signature, so we fake it */
Commit message of c78968bb by Jeff Garzik says we need to provide the SATL driver version and not the disk firmware version but the code overwrites the driver version with the disk version. Signed-off-by: Baruch Even <baruch@ev-en.org> --- drivers/ata/libata-scsi.c | 1 - 1 file changed, 1 deletion(-)