Message ID | CAPgLHd_oC4z6YbswNOo-bpObgH7v420DupSgx_pmmB6B29HjEg@mail.gmail.com |
---|---|
State | Not Applicable, archived |
Headers | show |
On Fri, Apr 05, 2013 at 03:45:12PM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > symbol '' was not declared. It should be static. This description doesn't make any sense. The patch looks good, though. Maybe something like: ---snip--- Neither tegra20_spi_cdata nor tegra30_spi_cdata are used outside this file so they can, and should, be static. ---snip--- Is more accurate? Thierry
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c index 4e58b53..b224a82 100644 --- a/drivers/spi/spi-tegra20-slink.c +++ b/drivers/spi/spi-tegra20-slink.c @@ -1087,11 +1087,11 @@ static struct tegra_spi_platform_data *tegra_slink_parse_dt( return pdata; } -const struct tegra_slink_chip_data tegra30_spi_cdata = { +static const struct tegra_slink_chip_data tegra30_spi_cdata = { .cs_hold_time = true, }; -const struct tegra_slink_chip_data tegra20_spi_cdata = { +static const struct tegra_slink_chip_data tegra20_spi_cdata = { .cs_hold_time = false, };