| Message ID | 1364912259-15488-2-git-send-email-adnan.ali@codethink.co.uk |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
On Tue, Apr 2, 2013 at 9:17 AM, Adnan Ali <adnan.ali@codethink.co.uk> wrote: > Enable btrfs support in mx53loco config > > Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> > --- > include/configs/mx53loco.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h > index a4b610f..62e9a76 100644 > --- a/include/configs/mx53loco.h > +++ b/include/configs/mx53loco.h > @@ -56,6 +56,8 @@ > #define CONFIG_GENERIC_MMC > #define CONFIG_CMD_FAT > #define CONFIG_CMD_EXT2 > +#define CONFIG_CMD_BTR > +#define CONFIG_CMD_FS_GENERIC > #define CONFIG_DOS_PARTITION > > /* Eth Configs */ > @@ -128,7 +130,7 @@ > "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \ > "mmcargs=setenv bootargs console=ttymxc0,${baudrate} root=${mmcroot}\0" \ > "loadbootscript=" \ > - "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ > + "btrload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ Instead of changing this to btrload for everyone, wouldn't it make more sense to use the generic "load" command? As your already setting "CONFIG_CMD_FS_GENERIC" Once you do that, you might as well also enable: #define CONFIG_CMD_EXT4 > "bootscript=echo Running bootscript from mmc ...; " \ > "source\0" \ > "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \ > -- > 1.7.9.5 Regards,
On 02/04/13 16:19, Robert Nelson wrote: > On Tue, Apr 2, 2013 at 9:17 AM, Adnan Ali <adnan.ali@codethink.co.uk> wrote: >> Enable btrfs support in mx53loco config >> >> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> >> --- >> include/configs/mx53loco.h | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h >> index a4b610f..62e9a76 100644 >> --- a/include/configs/mx53loco.h >> +++ b/include/configs/mx53loco.h >> @@ -56,6 +56,8 @@ >> #define CONFIG_GENERIC_MMC >> #define CONFIG_CMD_FAT >> #define CONFIG_CMD_EXT2 >> +#define CONFIG_CMD_BTR >> +#define CONFIG_CMD_FS_GENERIC >> #define CONFIG_DOS_PARTITION >> >> /* Eth Configs */ >> @@ -128,7 +130,7 @@ >> "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \ >> "mmcargs=setenv bootargs console=ttymxc0,${baudrate} root=${mmcroot}\0" \ >> "loadbootscript=" \ >> - "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ >> + "btrload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ > Instead of changing this to btrload for everyone, wouldn't it make > more sense to use the generic "load" command? As your already setting > "CONFIG_CMD_FS_GENERIC" Well idea of adding that was to enable btrfs and to show its associated commands. Yes you can use generic 'load' command. Defaults was using fatload so i change it to btrload. > > Once you do that, you might as well also enable: > #define CONFIG_CMD_EXT4 > >> "bootscript=echo Running bootscript from mmc ...; " \ >> "source\0" \ >> "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \ >> -- >> 1.7.9.5 > Regards, >
On Tue, Apr 2, 2013 at 10:38 AM, Adnan Ali <adnan.ali@codethink.co.uk> wrote: > On 02/04/13 16:19, Robert Nelson wrote: >> >> On Tue, Apr 2, 2013 at 9:17 AM, Adnan Ali <adnan.ali@codethink.co.uk> >> wrote: >>> >>> Enable btrfs support in mx53loco config >>> >>> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> >>> --- >>> include/configs/mx53loco.h | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h >>> index a4b610f..62e9a76 100644 >>> --- a/include/configs/mx53loco.h >>> +++ b/include/configs/mx53loco.h >>> @@ -56,6 +56,8 @@ >>> #define CONFIG_GENERIC_MMC >>> #define CONFIG_CMD_FAT >>> #define CONFIG_CMD_EXT2 >>> +#define CONFIG_CMD_BTR >>> +#define CONFIG_CMD_FS_GENERIC >>> #define CONFIG_DOS_PARTITION >>> >>> /* Eth Configs */ >>> @@ -128,7 +130,7 @@ >>> "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \ >>> "mmcargs=setenv bootargs console=ttymxc0,${baudrate} >>> root=${mmcroot}\0" \ >>> "loadbootscript=" \ >>> - "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} >>> ${script};\0" \ >>> + "btrload mmc ${mmcdev}:${mmcpart} ${loadaddr} >>> ${script};\0" \ >> >> Instead of changing this to btrload for everyone, wouldn't it make >> more sense to use the generic "load" command? As your already setting >> "CONFIG_CMD_FS_GENERIC" > > Well idea of adding that was to enable btrfs and to show its associated > commands. > Yes you can use generic 'load' command. Defaults was using fatload so i > change > it to btrload. That's perfectly fine for showing the btrfs command's as an RFC patch, but if this was heading for mainline as-is, it would be nice to use the "load" command instead of moving from one partition format that's been default for a couple years to a new format with less users. (not that I don't like the btrfs format. ;) as i've been running it on a few omap boards for a couple years now..) Regards,
On Tue, Apr 2, 2013 at 11:17 AM, Adnan Ali <adnan.ali@codethink.co.uk> wrote: > Enable btrfs support in mx53loco config > > Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> NACK! This break current uses. -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
On Tue, Apr 2, 2013 at 12:38 PM, Adnan Ali <adnan.ali@codethink.co.uk> wrote: > On 02/04/13 16:19, Robert Nelson wrote: >> >> On Tue, Apr 2, 2013 at 9:17 AM, Adnan Ali <adnan.ali@codethink.co.uk> >> wrote: >>> >>> Enable btrfs support in mx53loco config >>> >>> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> >>> --- >>> include/configs/mx53loco.h | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h >>> index a4b610f..62e9a76 100644 >>> --- a/include/configs/mx53loco.h >>> +++ b/include/configs/mx53loco.h >>> @@ -56,6 +56,8 @@ >>> #define CONFIG_GENERIC_MMC >>> #define CONFIG_CMD_FAT >>> #define CONFIG_CMD_EXT2 >>> +#define CONFIG_CMD_BTR >>> +#define CONFIG_CMD_FS_GENERIC >>> #define CONFIG_DOS_PARTITION >>> >>> /* Eth Configs */ >>> @@ -128,7 +130,7 @@ >>> "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \ >>> "mmcargs=setenv bootargs console=ttymxc0,${baudrate} >>> root=${mmcroot}\0" \ >>> "loadbootscript=" \ >>> - "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} >>> ${script};\0" \ >>> + "btrload mmc ${mmcdev}:${mmcpart} ${loadaddr} >>> ${script};\0" \ >> >> Instead of changing this to btrload for everyone, wouldn't it make >> more sense to use the generic "load" command? As your already setting >> "CONFIG_CMD_FS_GENERIC" > > Well idea of adding that was to enable btrfs and to show its associated > commands. > Yes you can use generic 'load' command. Defaults was using fatload so i > change > it to btrload. If you use the generic load I would be OK in changing it. -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/02/2013 11:52 AM, Robert Nelson wrote: > On Tue, Apr 2, 2013 at 10:38 AM, Adnan Ali > <adnan.ali@codethink.co.uk> wrote: >> On 02/04/13 16:19, Robert Nelson wrote: >>> >>> On Tue, Apr 2, 2013 at 9:17 AM, Adnan Ali >>> <adnan.ali@codethink.co.uk> wrote: >>>> >>>> Enable btrfs support in mx53loco config >>>> >>>> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> --- >>>> include/configs/mx53loco.h | 4 +++- 1 file changed, 3 >>>> insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/configs/mx53loco.h >>>> b/include/configs/mx53loco.h index a4b610f..62e9a76 100644 >>>> --- a/include/configs/mx53loco.h +++ >>>> b/include/configs/mx53loco.h @@ -56,6 +56,8 @@ #define >>>> CONFIG_GENERIC_MMC #define CONFIG_CMD_FAT #define >>>> CONFIG_CMD_EXT2 +#define CONFIG_CMD_BTR +#define >>>> CONFIG_CMD_FS_GENERIC #define CONFIG_DOS_PARTITION >>>> >>>> /* Eth Configs */ @@ -128,7 +130,7 @@ "mmcroot=/dev/mmcblk0p3 >>>> rw rootwait\0" \ "mmcargs=setenv bootargs >>>> console=ttymxc0,${baudrate} root=${mmcroot}\0" \ >>>> "loadbootscript=" \ - "fatload mmc >>>> ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ + >>>> "btrload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" >>>> \ >>> >>> Instead of changing this to btrload for everyone, wouldn't it >>> make more sense to use the generic "load" command? As your >>> already setting "CONFIG_CMD_FS_GENERIC" >> >> Well idea of adding that was to enable btrfs and to show its >> associated commands. Yes you can use generic 'load' command. >> Defaults was using fatload so i change it to btrload. > > That's perfectly fine for showing the btrfs command's as an RFC > patch, but if this was heading for mainline as-is, it would be nice > to use the "load" command instead of moving from one partition > format that's been default for a couple years to a new format with > less users. (not that I don't like the btrfs format. ;) as i've > been running it on a few omap boards for a couple years now..) Exactly. The code needs to be built somewhere, to not be considered dead code. The next change here, to loadbootscript needs to be done in a forward-compatible way like 'load' so now it just works for everyone. Thanks! - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRWw9wAAoJENk4IS6UOR1WwicP/iQiFRK3FAl6dqOTo+tfbeKX Aqbak7P+ULhKB4UtuYrAVP56GdGykTu8q/SdbQqXveFm2qGvsu1TIg1ZehJDOLxu AP8KMt9XssoaZerFIBCUlySBTeqDwbdaKM6zLsiey5RRvs5yy6Sgg3q/ssrxbmxE KYTiX4rVtQcTYdYZnlUkBZ7YBzT2rwUb9ZsWIvEPwv8NPvP8e2qNfsmgtOb2Z8nX 3EQ2Ssgf6VeAVdiQxmNrzcZM84vOyo9cfYNGSgURBQ76L6ZSchQ3ciqS0H/3Xkca 7dAVeQxFxK7U+hqDUZV0g69vwm0BZxsk58HelFXjdt5ZXKkDbK1UIIE/6XxCo+5g KQfrYhUQG7iF7pNRvTU+yn1YDijc7R4i4/6XbT8mgSvogOAyZajQzHnbkRcS7ssP RXV2V0HpdFuCBE0HNIjxnurEQPbT6O7Fb0/oRXWwWfHDJP2PBwsk0lWSyQoqog9B U2RmDG4iIBcqFAhzeREhxSQRwXLezujDwiTWklHjWeFMYavYa7mOdiuUpKucA7Y8 F4B1IJIUlP5X51A/7jA6PmboeYx6n0VzZNW3pjOK3smY+64cj9WVHCwQM5ypbsgv s+qCHDh7AYhbFCn0nPdUpuqMsDJVoVkeo3si0exs1Zh0+2jA7fAAYhjmFEhgK378 w/4Ajy/H8LSVlCd4duzl =gDdz -----END PGP SIGNATURE-----
On 02/04/13 17:41, Otavio Salvador wrote: > On Tue, Apr 2, 2013 at 12:38 PM, Adnan Ali <adnan.ali@codethink.co.uk> wrote: >> On 02/04/13 16:19, Robert Nelson wrote: >>> On Tue, Apr 2, 2013 at 9:17 AM, Adnan Ali <adnan.ali@codethink.co.uk> >>> wrote: >>>> Enable btrfs support in mx53loco config >>>> >>>> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> >>>> --- >>>> include/configs/mx53loco.h | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h >>>> index a4b610f..62e9a76 100644 >>>> --- a/include/configs/mx53loco.h >>>> +++ b/include/configs/mx53loco.h >>>> @@ -56,6 +56,8 @@ >>>> #define CONFIG_GENERIC_MMC >>>> #define CONFIG_CMD_FAT >>>> #define CONFIG_CMD_EXT2 >>>> +#define CONFIG_CMD_BTR >>>> +#define CONFIG_CMD_FS_GENERIC >>>> #define CONFIG_DOS_PARTITION >>>> >>>> /* Eth Configs */ >>>> @@ -128,7 +130,7 @@ >>>> "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \ >>>> "mmcargs=setenv bootargs console=ttymxc0,${baudrate} >>>> root=${mmcroot}\0" \ >>>> "loadbootscript=" \ >>>> - "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} >>>> ${script};\0" \ >>>> + "btrload mmc ${mmcdev}:${mmcpart} ${loadaddr} >>>> ${script};\0" \ >>> Instead of changing this to btrload for everyone, wouldn't it make >>> more sense to use the generic "load" command? As your already setting >>> "CONFIG_CMD_FS_GENERIC" >> Well idea of adding that was to enable btrfs and to show its associated >> commands. >> Yes you can use generic 'load' command. Defaults was using fatload so i >> change >> it to btrload. > If you use the generic load I would be OK in changing it. I will send this as separate patch. But I leave it until btrfs patch get accepted. If you are happy with that. ;) > > -- > Otavio Salvador O.S. Systems > E-mail: otavio@ossystems.com.br http://www.ossystems.com.br > Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
On 02/04/13 18:03, Tom Rini wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 04/02/2013 11:52 AM, Robert Nelson wrote: >> On Tue, Apr 2, 2013 at 10:38 AM, Adnan Ali >> <adnan.ali@codethink.co.uk> wrote: >>> On 02/04/13 16:19, Robert Nelson wrote: >>>> On Tue, Apr 2, 2013 at 9:17 AM, Adnan Ali >>>> <adnan.ali@codethink.co.uk> wrote: >>>>> Enable btrfs support in mx53loco config >>>>> >>>>> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> --- >>>>> include/configs/mx53loco.h | 4 +++- 1 file changed, 3 >>>>> insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/include/configs/mx53loco.h >>>>> b/include/configs/mx53loco.h index a4b610f..62e9a76 100644 >>>>> --- a/include/configs/mx53loco.h +++ >>>>> b/include/configs/mx53loco.h @@ -56,6 +56,8 @@ #define >>>>> CONFIG_GENERIC_MMC #define CONFIG_CMD_FAT #define >>>>> CONFIG_CMD_EXT2 +#define CONFIG_CMD_BTR +#define >>>>> CONFIG_CMD_FS_GENERIC #define CONFIG_DOS_PARTITION >>>>> >>>>> /* Eth Configs */ @@ -128,7 +130,7 @@ "mmcroot=/dev/mmcblk0p3 >>>>> rw rootwait\0" \ "mmcargs=setenv bootargs >>>>> console=ttymxc0,${baudrate} root=${mmcroot}\0" \ >>>>> "loadbootscript=" \ - "fatload mmc >>>>> ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ + >>>>> "btrload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" >>>>> \ >>>> Instead of changing this to btrload for everyone, wouldn't it >>>> make more sense to use the generic "load" command? As your >>>> already setting "CONFIG_CMD_FS_GENERIC" >>> Well idea of adding that was to enable btrfs and to show its >>> associated commands. Yes you can use generic 'load' command. >>> Defaults was using fatload so i change it to btrload. >> That's perfectly fine for showing the btrfs command's as an RFC >> patch, but if this was heading for mainline as-is, it would be nice >> to use the "load" command instead of moving from one partition >> format that's been default for a couple years to a new format with >> less users. (not that I don't like the btrfs format. ;) as i've >> been running it on a few omap boards for a couple years now..) > Exactly. The code needs to be built somewhere, to not be considered > dead code. The next change here, to loadbootscript needs to be done > in a forward-compatible way like 'load' so now it just works for > everyone. Thanks! I will need to send this as separate patch. [snip] Thanks Adnan
Hi On 02/04/13 18:03, Tom Rini wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 04/02/2013 11:52 AM, Robert Nelson wrote: >> On Tue, Apr 2, 2013 at 10:38 AM, Adnan Ali >> <adnan.ali@codethink.co.uk> wrote: >>> On 02/04/13 16:19, Robert Nelson wrote: >>>> On Tue, Apr 2, 2013 at 9:17 AM, Adnan Ali >>>> <adnan.ali@codethink.co.uk> wrote: >>>>> Enable btrfs support in mx53loco config >>>>> >>>>> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> --- >>>>> include/configs/mx53loco.h | 4 +++- 1 file changed, 3 >>>>> insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/include/configs/mx53loco.h >>>>> b/include/configs/mx53loco.h index a4b610f..62e9a76 100644 >>>>> --- a/include/configs/mx53loco.h +++ >>>>> b/include/configs/mx53loco.h @@ -56,6 +56,8 @@ #define >>>>> CONFIG_GENERIC_MMC #define CONFIG_CMD_FAT #define >>>>> CONFIG_CMD_EXT2 +#define CONFIG_CMD_BTR +#define >>>>> CONFIG_CMD_FS_GENERIC #define CONFIG_DOS_PARTITION >>>>> >>>>> /* Eth Configs */ @@ -128,7 +130,7 @@ "mmcroot=/dev/mmcblk0p3 >>>>> rw rootwait\0" \ "mmcargs=setenv bootargs >>>>> console=ttymxc0,${baudrate} root=${mmcroot}\0" \ >>>>> "loadbootscript=" \ - "fatload mmc >>>>> ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ + >>>>> "btrload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" >>>>> \ >>>> Instead of changing this to btrload for everyone, wouldn't it >>>> make more sense to use the generic "load" command? As your >>>> already setting "CONFIG_CMD_FS_GENERIC" >>> Well idea of adding that was to enable btrfs and to show its >>> associated commands. Yes you can use generic 'load' command. >>> Defaults was using fatload so i change it to btrload. >> That's perfectly fine for showing the btrfs command's as an RFC >> patch, but if this was heading for mainline as-is, it would be nice >> to use the "load" command instead of moving from one partition >> format that's been default for a couple years to a new format with >> less users. (not that I don't like the btrfs format. ;) as i've >> been running it on a few omap boards for a couple years now..) > Exactly. The code needs to be built somewhere, to not be considered > dead code. The next change here, to loadbootscript needs to be done > in a forward-compatible way like 'load' so now it just works for > everyone. Thanks! > > - -- Don't know whether you have read my previous mail or not. What i meant was that you can review the patch v11 and i will send the mx53loco_config with that change later. > Thanks Adnan Ali
diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h index a4b610f..62e9a76 100644 --- a/include/configs/mx53loco.h +++ b/include/configs/mx53loco.h @@ -56,6 +56,8 @@ #define CONFIG_GENERIC_MMC #define CONFIG_CMD_FAT #define CONFIG_CMD_EXT2 +#define CONFIG_CMD_BTR +#define CONFIG_CMD_FS_GENERIC #define CONFIG_DOS_PARTITION /* Eth Configs */ @@ -128,7 +130,7 @@ "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \ "mmcargs=setenv bootargs console=ttymxc0,${baudrate} root=${mmcroot}\0" \ "loadbootscript=" \ - "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ + "btrload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ "bootscript=echo Running bootscript from mmc ...; " \ "source\0" \ "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
Enable btrfs support in mx53loco config Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> --- include/configs/mx53loco.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)