| Message ID | 1363448999-3936-1-git-send-email-gwenhael.goavec-merou@armadeus.com |
|---|---|
| State | New |
| Headers | show |
Ping? Gwenhael On Sat, 16 Mar 2013 16:49:59 +0100 Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com> wrote: > mxc_device_init() is mandatory for mxc_aips and mxc_ahb bus registration, needed > as parents, at least, for gpio and dma. > > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com> > --- > arch/arm/mach-imx/mm-imx1.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-imx/mm-imx1.c b/arch/arm/mach-imx/mm-imx1.c > index 7a14667..3c609c5 100644 > --- a/arch/arm/mach-imx/mm-imx1.c > +++ b/arch/arm/mach-imx/mm-imx1.c > @@ -51,6 +51,8 @@ void __init mx1_init_irq(void) > > void __init imx1_soc_init(void) > { > + mxc_device_init(); > + > mxc_register_gpio("imx1-gpio", 0, MX1_GPIO1_BASE_ADDR, SZ_256, > MX1_GPIO_INT_PORTA, 0); > mxc_register_gpio("imx1-gpio", 1, MX1_GPIO2_BASE_ADDR, SZ_256, > -- > 1.8.1.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On Sat, Mar 16, 2013 at 04:49:59PM +0100, Gwenhael Goavec-Merou wrote: > mxc_device_init() is mandatory for mxc_aips and mxc_ahb bus registration, needed > as parents, at least, for gpio and dma. > > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com> Applied, thanks Sascha > --- > arch/arm/mach-imx/mm-imx1.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-imx/mm-imx1.c b/arch/arm/mach-imx/mm-imx1.c > index 7a14667..3c609c5 100644 > --- a/arch/arm/mach-imx/mm-imx1.c > +++ b/arch/arm/mach-imx/mm-imx1.c > @@ -51,6 +51,8 @@ void __init mx1_init_irq(void) > > void __init imx1_soc_init(void) > { > + mxc_device_init(); > + > mxc_register_gpio("imx1-gpio", 0, MX1_GPIO1_BASE_ADDR, SZ_256, > MX1_GPIO_INT_PORTA, 0); > mxc_register_gpio("imx1-gpio", 1, MX1_GPIO2_BASE_ADDR, SZ_256, > -- > 1.8.1.5 > >
Sascha, On Mon, Mar 25, 2013 at 03:09:40PM +0100, Sascha Hauer wrote: > On Sat, Mar 16, 2013 at 04:49:59PM +0100, Gwenhael Goavec-Merou wrote: > > mxc_device_init() is mandatory for mxc_aips and mxc_ahb bus registration, needed > > as parents, at least, for gpio and dma. > > > > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com> > > Applied, thanks I did not see this patch in those you ask me to handle. Has it been handled or just missed? Shawn
On Tue, Apr 02, 2013 at 09:16:33PM +0800, Shawn Guo wrote: > Sascha, > > On Mon, Mar 25, 2013 at 03:09:40PM +0100, Sascha Hauer wrote: > > On Sat, Mar 16, 2013 at 04:49:59PM +0100, Gwenhael Goavec-Merou wrote: > > > mxc_device_init() is mandatory for mxc_aips and mxc_ahb bus registration, needed > > > as parents, at least, for gpio and dma. > > > > > > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com> > > > > Applied, thanks > > I did not see this patch in those you ask me to handle. Has it been > handled or just missed? I seem to have lost it, although I'm pretty sure I really applied it and not just said so. Sascha
diff --git a/arch/arm/mach-imx/mm-imx1.c b/arch/arm/mach-imx/mm-imx1.c index 7a14667..3c609c5 100644 --- a/arch/arm/mach-imx/mm-imx1.c +++ b/arch/arm/mach-imx/mm-imx1.c @@ -51,6 +51,8 @@ void __init mx1_init_irq(void) void __init imx1_soc_init(void) { + mxc_device_init(); + mxc_register_gpio("imx1-gpio", 0, MX1_GPIO1_BASE_ADDR, SZ_256, MX1_GPIO_INT_PORTA, 0); mxc_register_gpio("imx1-gpio", 1, MX1_GPIO2_BASE_ADDR, SZ_256,
mxc_device_init() is mandatory for mxc_aips and mxc_ahb bus registration, needed as parents, at least, for gpio and dma. Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com> --- arch/arm/mach-imx/mm-imx1.c | 2 ++ 1 file changed, 2 insertions(+)