| Message ID | 1363611926-27105-57-git-send-email-jbb@gamblify.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On 18/03/13 14:05, Jesper Baekdahl wrote: > From: Will Wagner <will_wagner@carallon.com> > > Signed-off-by: Will Wagner <will_wagner@carallon.com> > Signed-off-by: Jesper Baekdahl <jbb@gamblify.com> > --- > package/x11r7/xutil_util-macros/xutil_util-macros-1.17.patch | 9 +++++++++ > 1 file changed, 9 insertions(+) > create mode 100644 package/x11r7/xutil_util-macros/xutil_util-macros-1.17.patch > > diff --git a/package/x11r7/xutil_util-macros/xutil_util-macros-1.17.patch b/package/x11r7/xutil_util-macros/xutil_util-macros-1.17.patch > new file mode 100644 > index 0000000..167229d > --- /dev/null > +++ b/package/x11r7/xutil_util-macros/xutil_util-macros-1.17.patch > @@ -0,0 +1,9 @@ > +--- xutil_util-macros-1.8.0/xorg-macros.m4.in.orig 2010-05-27 14:03:30.000000000 +0100 > ++++ xutil_util-macros-1.8.0/xorg-macros.m4.in 2011-11-09 11:57:41.000000000 +0000 > +@@ -1064,3 +1064,6 @@ mv \$(top_srcdir)/.INSTALL.tmp \$(top_sr > + echo 'util-macros \"pkgdatadir\" from xorg-macros.pc not found: installing possibly empty INSTALL.' >&2)" > + AC_SUBST([INSTALL_CMD]) > + ]) # XORG_INSTALL > ++ > ++# Buildroot stuff > ++AC_SUBST(STAGING_DIR) This does not make sense... It's not a version bump, first of all, and in addition the STAGING_DIR variable isn't used anywhere so substituting it won't do much good... Or am I missing something? In addition, it's very strange that a patch for version 1.17 would refer to the -1.8.0 directory. And finally: patch filenames shouldn't contain a version number, and the patch should have an explanatory comment and a Signed-off-by line. Regards, Arnout
Hi Arnout Vandecappelle Thank you for taking a look. On Thu, Mar 21, 2013 at 6:45 PM, Arnout Vandecappelle <arnout@mind.be>wrote: > On 18/03/13 14:05, Jesper Baekdahl wrote: > >> From: Will Wagner <will_wagner@carallon.com> >> >> Signed-off-by: Will Wagner <will_wagner@carallon.com> >> Signed-off-by: Jesper Baekdahl <jbb@gamblify.com> >> --- >> package/x11r7/xutil_util-**macros/xutil_util-macros-1.17.**patch | >> 9 +++++++++ >> 1 file changed, 9 insertions(+) >> create mode 100644 package/x11r7/xutil_util-** >> macros/xutil_util-macros-1.17.**patch >> >> diff --git a/package/x11r7/xutil_util-**macros/xutil_util-macros-1.17.**patch >> b/package/x11r7/xutil_util-**macros/xutil_util-macros-1.17.**patch >> new file mode 100644 >> index 0000000..167229d >> --- /dev/null >> +++ b/package/x11r7/xutil_util-**macros/xutil_util-macros-1.17.**patch >> @@ -0,0 +1,9 @@ >> +--- xutil_util-macros-1.8.0/xorg-**macros.m4.in.orig 2010-05-27 >> 14:03:30.000000000 +0100 >> ++++ xutil_util-macros-1.8.0/xorg-**macros.m4.in<http://xorg-macros.m4.in> 2011-11-09 11:57:41.000000000 +0000 >> +@@ -1064,3 +1064,6 @@ mv \$(top_srcdir)/.INSTALL.tmp \$(top_sr >> + echo 'util-macros \"pkgdatadir\" from xorg-macros.pc not found: >> installing possibly empty INSTALL.' >&2)" >> + AC_SUBST([INSTALL_CMD]) >> + ]) # XORG_INSTALL >> ++ >> ++# Buildroot stuff >> ++AC_SUBST(STAGING_DIR) >> > > > This does not make sense... It's not a version bump, first of all, and in > addition the STAGING_DIR variable isn't used anywhere so substituting it > won't do much good... Or am I missing something? In addition, it's very > strange that a patch for version 1.17 would refer to the -1.8.0 directory. > And finally: patch filenames shouldn't contain a version number, and the > patch should have an explanatory comment and a Signed-off-by line. You are absolutely right. I have removed this patch and also been through the whole patchset, correcting things, after a discussion with Thomas Petazzoni here: http://lists.busybox.net/pipermail/buildroot/2013-March/069149.html My new version can be found as a branch here: https://bitbucket.org/baekdahl/buildroot/src/96182fac0691/?at=x11r77_v2 Regards, Jesper
diff --git a/package/x11r7/xutil_util-macros/xutil_util-macros-1.17.patch b/package/x11r7/xutil_util-macros/xutil_util-macros-1.17.patch new file mode 100644 index 0000000..167229d --- /dev/null +++ b/package/x11r7/xutil_util-macros/xutil_util-macros-1.17.patch @@ -0,0 +1,9 @@ +--- xutil_util-macros-1.8.0/xorg-macros.m4.in.orig 2010-05-27 14:03:30.000000000 +0100 ++++ xutil_util-macros-1.8.0/xorg-macros.m4.in 2011-11-09 11:57:41.000000000 +0000 +@@ -1064,3 +1064,6 @@ mv \$(top_srcdir)/.INSTALL.tmp \$(top_sr + echo 'util-macros \"pkgdatadir\" from xorg-macros.pc not found: installing possibly empty INSTALL.' >&2)" + AC_SUBST([INSTALL_CMD]) + ]) # XORG_INSTALL ++ ++# Buildroot stuff ++AC_SUBST(STAGING_DIR)