| Message ID | 1363864206.1390.117.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Michael Ellerman |
| Headers | show |
On Thu, Mar 21, 2013 at 12:10:06PM +0100, Paul Bolle wrote: > When I submitted commit 6805ab6daa2b589fe3242d05ddc47a9dbb0c4eb1 > ("powerpc: drop unused Kconfig symbols") I apparently failed to notice > that my patch also made PREP_RESIDUAL and PPC_A2_DD2 unused. Drop these > now. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > 0) Untested. > > 1) I investigated these Kconfig files a bit and discovered that PPC_PREP > is marked BROKEN since v2.6.15, see commit > 5be396b00ca0f2f769c55cf69bbd7c77451c925e ("powerpc: Mark PREP and > embedded as broken for now"). Though it's not my problem, this does > suggest PReP support can be removed entirely. It does, and the best code is deleted code. Care to send a patch? cheers
On Thu, 2013-03-21 at 12:10 +0100, Paul Bolle wrote: > diff --git a/arch/powerpc/platforms/wsp/Kconfig b/arch/powerpc/platforms/wsp/Kconfig > index 79d2225..9eea710 100644 > --- a/arch/powerpc/platforms/wsp/Kconfig > +++ b/arch/powerpc/platforms/wsp/Kconfig > @@ -29,7 +29,3 @@ config PPC_CHROMA > default y > > endmenu > - > -config PPC_A2_DD2 > - bool "Support for DD2 based A2/WSP systems" > - depends on PPC_A2 This part was not included in the "powerpc: remove PReP" follow up patch. Should I resend separately? Paul Bolle
On Wed, Mar 27, 2013 at 11:51:35AM +0100, Paul Bolle wrote: > On Thu, 2013-03-21 at 12:10 +0100, Paul Bolle wrote: > > diff --git a/arch/powerpc/platforms/wsp/Kconfig b/arch/powerpc/platforms/wsp/Kconfig > > index 79d2225..9eea710 100644 > > --- a/arch/powerpc/platforms/wsp/Kconfig > > +++ b/arch/powerpc/platforms/wsp/Kconfig > > @@ -29,7 +29,3 @@ config PPC_CHROMA > > default y > > > > endmenu > > - > > -config PPC_A2_DD2 > > - bool "Support for DD2 based A2/WSP systems" > > - depends on PPC_A2 > > This part was not included in the "powerpc: remove PReP" follow up > patch. Should I resend separately? Yes thanks. It was added in commit a1d0d98 "Add WSP platform" but should not have been, it was to support bringup hacks that were never merged upstream. cheers
diff --git a/arch/powerpc/platforms/prep/Kconfig b/arch/powerpc/platforms/prep/Kconfig index 1547f66..2036e7e 100644 --- a/arch/powerpc/platforms/prep/Kconfig +++ b/arch/powerpc/platforms/prep/Kconfig @@ -8,16 +8,3 @@ config PPC_PREP select PPC_UDBG_16550 select PPC_NATIVE default n - -config PREP_RESIDUAL - bool "Support for PReP Residual Data" - depends on PPC_PREP - help - Some PReP systems have residual data passed to the kernel by the - firmware. This allows detection of memory size, devices present and - other useful pieces of information. Sometimes this information is - not present or incorrect, in which case it could lead to the machine - behaving incorrectly. If this happens, either disable PREP_RESIDUAL - or pass the 'noresidual' option to the kernel. - - If you are running a PReP system, say Y here, otherwise say N. diff --git a/arch/powerpc/platforms/wsp/Kconfig b/arch/powerpc/platforms/wsp/Kconfig index 79d2225..9eea710 100644 --- a/arch/powerpc/platforms/wsp/Kconfig +++ b/arch/powerpc/platforms/wsp/Kconfig @@ -29,7 +29,3 @@ config PPC_CHROMA default y endmenu - -config PPC_A2_DD2 - bool "Support for DD2 based A2/WSP systems" - depends on PPC_A2
When I submitted commit 6805ab6daa2b589fe3242d05ddc47a9dbb0c4eb1 ("powerpc: drop unused Kconfig symbols") I apparently failed to notice that my patch also made PREP_RESIDUAL and PPC_A2_DD2 unused. Drop these now. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- 0) Untested. 1) I investigated these Kconfig files a bit and discovered that PPC_PREP is marked BROKEN since v2.6.15, see commit 5be396b00ca0f2f769c55cf69bbd7c77451c925e ("powerpc: Mark PREP and embedded as broken for now"). Though it's not my problem, this does suggest PReP support can be removed entirely. arch/powerpc/platforms/prep/Kconfig | 13 ------------- arch/powerpc/platforms/wsp/Kconfig | 4 ---- 2 files changed, 17 deletions(-)