| Message ID | 1363867954-28937-1-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Accepted |
| Commit | fc53ebdca51a88aae44a4d33aa143916450873dc |
| Headers | show |
Gustavo, All, On Thursday 21 March 2013 13:12:34 Gustavo Zacarias wrote: > host-dosfstools shouldn't pull host-libiconv in since that's for > uClibc-based toolchains and we don't have that package anyway. > Fixes: > http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/ > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/dosfstools/dosfstools.mk | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/package/dosfstools/dosfstools.mk b/package/dosfstools/dosfstools.mk > index 332f2ee..79d1c7a 100644 > --- a/package/dosfstools/dosfstools.mk > +++ b/package/dosfstools/dosfstools.mk > @@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+ > DOSFSTOOLS_LICENSE_FILES = COPYING > DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS) > > +# Avoid target dosfstools dependencies, no host-libiconv > +HOST_DOSFSTOOLS_DEPENDENCIES = > + Shouldn't we also do: HOST_DOSFSTOOLS_LDFLAGS = > ifneq ($(BR2_ENABLE_LOCALE),y) > DOSFSTOOLS_DEPENDENCIES += libiconv > DOSFSTOOLS_LDFLAGS += -liconv Regards, Yann E. MORIN.
On 03/21/2013 09:21 AM, Yann E. MORIN wrote: >> +# Avoid target dosfstools dependencies, no host-libiconv >> +HOST_DOSFSTOOLS_DEPENDENCIES = >> + > > Shouldn't we also do: > HOST_DOSFSTOOLS_LDFLAGS = > >> ifneq ($(BR2_ENABLE_LOCALE),y) >> DOSFSTOOLS_DEPENDENCIES += libiconv >> DOSFSTOOLS_LDFLAGS += -liconv Not really, HOST_LDFLAGS doesn't inherit. Regards.
On 03/21/2013 09:29 AM, Gustavo Zacarias wrote: > On 03/21/2013 09:21 AM, Yann E. MORIN wrote: > >>> +# Avoid target dosfstools dependencies, no host-libiconv >>> +HOST_DOSFSTOOLS_DEPENDENCIES = >>> + >> >> Shouldn't we also do: >> HOST_DOSFSTOOLS_LDFLAGS = >> >>> ifneq ($(BR2_ENABLE_LOCALE),y) >>> DOSFSTOOLS_DEPENDENCIES += libiconv >>> DOSFSTOOLS_LDFLAGS += -liconv > > Not really, HOST_LDFLAGS doesn't inherit. > Regards. And we explicitly use a clean BUILD_CMDS for the host :) Regards.
Gustavo, All, On Thursday 21 March 2013 Gustavo Zacarias wrote: > host-dosfstools shouldn't pull host-libiconv in since that's for > uClibc-based toolchains and we don't have that package anyway. > Fixes: > http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/ > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Thanks for fixing my breakage! ;-) Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > package/dosfstools/dosfstools.mk | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/package/dosfstools/dosfstools.mk b/package/dosfstools/dosfstools.mk > index 332f2ee..79d1c7a 100644 > --- a/package/dosfstools/dosfstools.mk > +++ b/package/dosfstools/dosfstools.mk > @@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+ > DOSFSTOOLS_LICENSE_FILES = COPYING > DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS) > > +# Avoid target dosfstools dependencies, no host-libiconv > +HOST_DOSFSTOOLS_DEPENDENCIES = > + > ifneq ($(BR2_ENABLE_LOCALE),y) > DOSFSTOOLS_DEPENDENCIES += libiconv > DOSFSTOOLS_LDFLAGS += -liconv > -- > 1.8.1.5 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > >
Dear Gustavo Zacarias, On Thu, 21 Mar 2013 09:12:34 -0300, Gustavo Zacarias wrote: > host-dosfstools shouldn't pull host-libiconv in since that's for > uClibc-based toolchains and we don't have that package anyway. > Fixes: > http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/ > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
Gustavo> host-dosfstools shouldn't pull host-libiconv in since that's for
Gustavo> uClibc-based toolchains and we don't have that package anyway.
Gustavo> Fixes:
Gustavo> http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/
Committed, thanks.
diff --git a/package/dosfstools/dosfstools.mk b/package/dosfstools/dosfstools.mk index 332f2ee..79d1c7a 100644 --- a/package/dosfstools/dosfstools.mk +++ b/package/dosfstools/dosfstools.mk @@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+ DOSFSTOOLS_LICENSE_FILES = COPYING DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS) +# Avoid target dosfstools dependencies, no host-libiconv +HOST_DOSFSTOOLS_DEPENDENCIES = + ifneq ($(BR2_ENABLE_LOCALE),y) DOSFSTOOLS_DEPENDENCIES += libiconv DOSFSTOOLS_LDFLAGS += -liconv
host-dosfstools shouldn't pull host-libiconv in since that's for uClibc-based toolchains and we don't have that package anyway. Fixes: http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/ Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/dosfstools/dosfstools.mk | 3 +++ 1 file changed, 3 insertions(+)