| Message ID | 1363297640-2321-1-git-send-email-viniciustinti@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On 03/14/13 22:47, Vinicius Tinti wrote: > Add Python bindings for the Apache Thrift RPC. > > Thrift is an interface definition language that is used to define and create > services for numerous languages using remote procedure calls (RPC). > > This patch does not include the Thrift code generator. It only includes the > Thrift libraries used at runtime. > > Signed-off-by: Tiago Maluta <tiagomaluta@gmail.com> > Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Still some remarks below, up to Peter to decide if they need to be fixed before committing. [snip] > diff --git a/package/python-thrift/python-thrift.mk b/package/python-thrift/python-thrift.mk > new file mode 100644 > index 0000000..5d9831e > --- /dev/null > +++ b/package/python-thrift/python-thrift.mk > @@ -0,0 +1,27 @@ > +############################################################# > +# > +# python-thrift > +# > +############################################################# > + > +PYTHON_THRIFT_VERSION = 0.9.0 > +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz Redundant. > +PYTHON_THRIFT_SITE = https://pypi.python.org/packages/source/t/thrift/ Should be http rather than https, and the final / is redundant. > +PYTHON_THRIFT_LICENSE = Apache-2.0 > +PYTHON_THRIFT_LICENSE_FILES = README > + > +PYTHON_THRIFT_DEPENDENCIES = python > + > +define PYTHON_THRIFT_BUILD_CMDS > + (cd $(@D); \ > + PYTHONXCPREFIX="$(STAGING_DIR)/usr/" \ > + LDFLAGS="-L$(STAGING_DIR)/lib -L$(STAGING_DIR)/usr/lib" \ > + $(HOST_DIR)/usr/bin/python setup.py build) This should be indented one tab more. > +endef > + Missing comment: # host-distutilscross, if it has been installed before, will check that # the installation directory is in python's load path. For host-python, # it is not, so add it explicitly while installing to target. > +define PYTHON_THRIFT_INSTALL_TARGET_CMDS > + (cd $(@D); PYTHONPATH=$(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages \ > + $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr) > +endef > + > +$(eval $(generic-package)) > Regards, Arnout
diff --git a/package/Config.in b/package/Config.in index b8b1e60..fc50465 100644 --- a/package/Config.in +++ b/package/Config.in @@ -334,6 +334,7 @@ source "package/python-pygame/Config.in" source "package/python-pyparsing/Config.in" source "package/python-serial/Config.in" source "package/python-setuptools/Config.in" +source "package/python-thrift/Config.in" endmenu endif source "package/ruby/Config.in" diff --git a/package/python-thrift/Config.in b/package/python-thrift/Config.in new file mode 100644 index 0000000..94a7590 --- /dev/null +++ b/package/python-thrift/Config.in @@ -0,0 +1,7 @@ +config BR2_PACKAGE_PYTHON_THRIFT + bool "python-thrift" + depends on BR2_PACKAGE_PYTHON + help + python-thrift is a Python bindings for the Apache Thrift RPC system. + + http://thrift.apache.org/ diff --git a/package/python-thrift/python-thrift.mk b/package/python-thrift/python-thrift.mk new file mode 100644 index 0000000..5d9831e --- /dev/null +++ b/package/python-thrift/python-thrift.mk @@ -0,0 +1,27 @@ +############################################################# +# +# python-thrift +# +############################################################# + +PYTHON_THRIFT_VERSION = 0.9.0 +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz +PYTHON_THRIFT_SITE = https://pypi.python.org/packages/source/t/thrift/ +PYTHON_THRIFT_LICENSE = Apache-2.0 +PYTHON_THRIFT_LICENSE_FILES = README + +PYTHON_THRIFT_DEPENDENCIES = python + +define PYTHON_THRIFT_BUILD_CMDS + (cd $(@D); \ + PYTHONXCPREFIX="$(STAGING_DIR)/usr/" \ + LDFLAGS="-L$(STAGING_DIR)/lib -L$(STAGING_DIR)/usr/lib" \ + $(HOST_DIR)/usr/bin/python setup.py build) +endef + +define PYTHON_THRIFT_INSTALL_TARGET_CMDS + (cd $(@D); PYTHONPATH=$(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages \ + $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr) +endef + +$(eval $(generic-package))