| Message ID | 1363124951.3137.156.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kumar Gala |
| Headers | show |
On Mar 12, 2013, at 4:49 PM, Paul Bolle wrote: > The Kconfig entry for QE_USB contains > default y if USB_GADGET_FSL_QE > > But USB_GADGET_FSL_QE got removed in commit > 193ab2a6070039e7ee2b9b9bebea754a7c52fd1b ("usb: gadget: allow multiple > gadgets to be built"). This default will therefor never be set and can > be removed. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > 0) Tested with "make ARCH=powerpc menuconfig" and "make ARCH=powerpc > oldconfig" (before and after the patch). Enough to see this patch didn't > obviously break stuff. > > 1) I don't really understand commit > 193ab2a6070039e7ee2b9b9bebea754a7c52fd1b. Was its point that we replace > USB_GADGET_FSL_QE with USB_FSL_QE? I couldn't tell and chose not to > actually change any behavior. > > arch/powerpc/sysdev/qe_lib/Kconfig | 1 - > 1 file changed, 1 deletion(-) > You're correct that this isn't quite right, I've posted a proper patch that should fix this correctly. thanks for pointing it out. - k
diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig index 41ac3df..33caf44 100644 --- a/arch/powerpc/sysdev/qe_lib/Kconfig +++ b/arch/powerpc/sysdev/qe_lib/Kconfig @@ -22,6 +22,5 @@ config UCC config QE_USB bool - default y if USB_GADGET_FSL_QE help QE USB Controller support
The Kconfig entry for QE_USB contains default y if USB_GADGET_FSL_QE But USB_GADGET_FSL_QE got removed in commit 193ab2a6070039e7ee2b9b9bebea754a7c52fd1b ("usb: gadget: allow multiple gadgets to be built"). This default will therefor never be set and can be removed. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- 0) Tested with "make ARCH=powerpc menuconfig" and "make ARCH=powerpc oldconfig" (before and after the patch). Enough to see this patch didn't obviously break stuff. 1) I don't really understand commit 193ab2a6070039e7ee2b9b9bebea754a7c52fd1b. Was its point that we replace USB_GADGET_FSL_QE with USB_FSL_QE? I couldn't tell and chose not to actually change any behavior. arch/powerpc/sysdev/qe_lib/Kconfig | 1 - 1 file changed, 1 deletion(-)