| Message ID | 1363120519.3137.148.camel@x61.thuisdomein |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Mar 12, 2013 at 09:35:19PM +0100, Paul Bolle wrote: > Commit 2d78d4beb64eb07d50665432867971c481192ebf ("[PATCH] bitops: > sparc64: use generic bitops") made the default of GENERIC_HWEIGHT depend > on !ULTRA_HAS_POPULATION_COUNT. But since there's no Kconfig symbol with > that name, this always evaluates to true. Delete this dependency. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Acked-by: Sam Ravnborg <sam@ravnborg.org> Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Paul Bolle <pebolle@tiscali.nl> Date: Tue, 12 Mar 2013 21:35:19 +0100 > Commit 2d78d4beb64eb07d50665432867971c481192ebf ("[PATCH] bitops: > sparc64: use generic bitops") made the default of GENERIC_HWEIGHT depend > on !ULTRA_HAS_POPULATION_COUNT. But since there's no Kconfig symbol with > that name, this always evaluates to true. Delete this dependency. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Applied, thanks Paul. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig index 289127d..7fcd4b4 100644 --- a/arch/sparc/Kconfig +++ b/arch/sparc/Kconfig @@ -197,7 +197,7 @@ config RWSEM_XCHGADD_ALGORITHM config GENERIC_HWEIGHT bool - default y if !ULTRA_HAS_POPULATION_COUNT + default y config GENERIC_CALIBRATE_DELAY bool
Commit 2d78d4beb64eb07d50665432867971c481192ebf ("[PATCH] bitops: sparc64: use generic bitops") made the default of GENERIC_HWEIGHT depend on !ULTRA_HAS_POPULATION_COUNT. But since there's no Kconfig symbol with that name, this always evaluates to true. Delete this dependency. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- 0) Tested with "make ARCH=sparc menuconfig" (before and after this patch). 1) There apparently is an (obscure) preprocessor macro ULTRA_HAS_POPULATION_COUNT. But the check for it got removed in commit ef7c4d4675d2a9206f913f26ca1a5cd41bff9d41 ("sparc: Use popc if possible for hweight routines."). arch/sparc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)