diff mbox

ext4: Reserve xattr index for Rich ACL support

Message ID 1360155211-7146-1-git-send-email-jack@suse.cz
State Accepted, archived
Headers show

Commit Message

Jan Kara Feb. 6, 2013, 12:53 p.m. UTC
SUSE is carrying out of tree patches for Rich ACL support for ext4 as
they didn't get upstream due to opposition of some VFS maintainers.
Reserve xattr index for Rich ACLs so that it cannot be taken by anything
else which would force users to backup and reset their Rich ACLs on
files.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/xattr.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Jan Kara March 7, 2013, 2:59 p.m. UTC | #1
On Wed 06-02-13 13:53:31, Jan Kara wrote:
> SUSE is carrying out of tree patches for Rich ACL support for ext4 as
> they didn't get upstream due to opposition of some VFS maintainers.
> Reserve xattr index for Rich ACLs so that it cannot be taken by anything
> else which would force users to backup and reset their Rich ACLs on
> files.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
  Ping? Any opinion on this?

								Honza
> ---
>  fs/ext4/xattr.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext4/xattr.h b/fs/ext4/xattr.h
> index 69eda78..7955773 100644
> --- a/fs/ext4/xattr.h
> +++ b/fs/ext4/xattr.h
> @@ -22,6 +22,7 @@
>  #define	EXT4_XATTR_INDEX_LUSTRE			5
>  #define EXT4_XATTR_INDEX_SECURITY	        6
>  #define EXT4_XATTR_INDEX_SYSTEM			7
> +#define EXT4_XATTR_INDEX_RICHACL		8
>  
>  struct ext4_xattr_header {
>  	__le32	h_magic;	/* magic number for identification */
> -- 
> 1.7.1
>
Theodore Ts'o April 17, 2013, 10:14 p.m. UTC | #2
On Wed, Feb 06, 2013 at 01:53:31PM +0100, Jan Kara wrote:
> SUSE is carrying out of tree patches for Rich ACL support for ext4 as
> they didn't get upstream due to opposition of some VFS maintainers.
> Reserve xattr index for Rich ACLs so that it cannot be taken by anything
> else which would force users to backup and reset their Rich ACLs on
> files.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>

I've added this to the ext4 patch queue.  Thanks for poking me about
this.

Cheers,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ext4/xattr.h b/fs/ext4/xattr.h
index 69eda78..7955773 100644
--- a/fs/ext4/xattr.h
+++ b/fs/ext4/xattr.h
@@ -22,6 +22,7 @@ 
 #define	EXT4_XATTR_INDEX_LUSTRE			5
 #define EXT4_XATTR_INDEX_SECURITY	        6
 #define EXT4_XATTR_INDEX_SYSTEM			7
+#define EXT4_XATTR_INDEX_RICHACL		8
 
 struct ext4_xattr_header {
 	__le32	h_magic;	/* magic number for identification */