Message ID | 1355564002-14490-1-git-send-email-francois.perrad@gadz.org |
---|---|
State | Superseded |
Headers | show |
ping 2012/12/15 Francois Perrad <fperrad@gmail.com>: > runtime dependencies are handled in Config.in > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > --- > package/cgilua/cgilua.mk | 1 - > package/copas/copas.mk | 1 - > package/coxpcall/coxpcall.mk | 1 - > package/wsapi/wsapi.mk | 1 - > package/xavante/xavante.mk | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/package/cgilua/cgilua.mk b/package/cgilua/cgilua.mk > index 48ee005..184d836 100644 > --- a/package/cgilua/cgilua.mk > +++ b/package/cgilua/cgilua.mk > @@ -6,7 +6,6 @@ > > CGILUA_VERSION = 5.1.4 > CGILUA_SITE = http://github.com/downloads/keplerproject/cgilua > -CGILUA_DEPENDENCIES = luafilesystem > CGILUA_LICENSE = MIT > > define CGILUA_INSTALL_TARGET_CMDS > diff --git a/package/copas/copas.mk b/package/copas/copas.mk > index c84a6cc..d3e6576 100644 > --- a/package/copas/copas.mk > +++ b/package/copas/copas.mk > @@ -6,7 +6,6 @@ > > COPAS_VERSION = 1.1.6 > COPAS_SITE = http://github.com/downloads/keplerproject/copas > -COPAS_DEPENDENCIES = lua coxpcall luasocket > COPAS_LICENSE = MIT > > define COPAS_INSTALL_TARGET_CMDS > diff --git a/package/coxpcall/coxpcall.mk b/package/coxpcall/coxpcall.mk > index e7fb76d..329d6fd 100644 > --- a/package/coxpcall/coxpcall.mk > +++ b/package/coxpcall/coxpcall.mk > @@ -6,7 +6,6 @@ > > COXPCALL_VERSION = 1.13.0 > COXPCALL_SITE = http://luaforge.net/frs/download.php/3406 > -COXPCALL_DEPENDENCIES = lua > COXPCALL_LICENSE = MIT > > define COXPCALL_INSTALL_TARGET_CMDS > diff --git a/package/wsapi/wsapi.mk b/package/wsapi/wsapi.mk > index eb2b51c..4628530 100644 > --- a/package/wsapi/wsapi.mk > +++ b/package/wsapi/wsapi.mk > @@ -6,7 +6,6 @@ > > WSAPI_VERSION = 1.5 > WSAPI_SITE = http://github.com/downloads/keplerproject/wsapi > -WSAPI_DEPENDENCIES = coxpcall luafilesystem rings > WSAPI_LICENSE = MIT > > define WSAPI_INSTALL_TARGET_CMDS > diff --git a/package/xavante/xavante.mk b/package/xavante/xavante.mk > index 0c1c6f1..d1ca320 100644 > --- a/package/xavante/xavante.mk > +++ b/package/xavante/xavante.mk > @@ -6,7 +6,6 @@ > > XAVANTE_VERSION = 2.2.1 > XAVANTE_SITE = http://github.com/downloads/keplerproject/xavante > -XAVANTE_DEPENDENCIES = cgilua copas coxpcall lua luafilesystem luasocket wsapi > XAVANTE_LICENSE = MIT > > define XAVANTE_INSTALL_TARGET_CMDS > -- > 1.7.9.5 >
ping 2012/12/15 Francois Perrad <fperrad@gmail.com>: > runtime dependencies are handled in Config.in > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > --- > package/cgilua/cgilua.mk | 1 - > package/copas/copas.mk | 1 - > package/coxpcall/coxpcall.mk | 1 - > package/wsapi/wsapi.mk | 1 - > package/xavante/xavante.mk | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/package/cgilua/cgilua.mk b/package/cgilua/cgilua.mk > index 48ee005..184d836 100644 > --- a/package/cgilua/cgilua.mk > +++ b/package/cgilua/cgilua.mk > @@ -6,7 +6,6 @@ > > CGILUA_VERSION = 5.1.4 > CGILUA_SITE = http://github.com/downloads/keplerproject/cgilua > -CGILUA_DEPENDENCIES = luafilesystem > CGILUA_LICENSE = MIT > > define CGILUA_INSTALL_TARGET_CMDS > diff --git a/package/copas/copas.mk b/package/copas/copas.mk > index c84a6cc..d3e6576 100644 > --- a/package/copas/copas.mk > +++ b/package/copas/copas.mk > @@ -6,7 +6,6 @@ > > COPAS_VERSION = 1.1.6 > COPAS_SITE = http://github.com/downloads/keplerproject/copas > -COPAS_DEPENDENCIES = lua coxpcall luasocket > COPAS_LICENSE = MIT > > define COPAS_INSTALL_TARGET_CMDS > diff --git a/package/coxpcall/coxpcall.mk b/package/coxpcall/coxpcall.mk > index e7fb76d..329d6fd 100644 > --- a/package/coxpcall/coxpcall.mk > +++ b/package/coxpcall/coxpcall.mk > @@ -6,7 +6,6 @@ > > COXPCALL_VERSION = 1.13.0 > COXPCALL_SITE = http://luaforge.net/frs/download.php/3406 > -COXPCALL_DEPENDENCIES = lua > COXPCALL_LICENSE = MIT > > define COXPCALL_INSTALL_TARGET_CMDS > diff --git a/package/wsapi/wsapi.mk b/package/wsapi/wsapi.mk > index eb2b51c..4628530 100644 > --- a/package/wsapi/wsapi.mk > +++ b/package/wsapi/wsapi.mk > @@ -6,7 +6,6 @@ > > WSAPI_VERSION = 1.5 > WSAPI_SITE = http://github.com/downloads/keplerproject/wsapi > -WSAPI_DEPENDENCIES = coxpcall luafilesystem rings > WSAPI_LICENSE = MIT > > define WSAPI_INSTALL_TARGET_CMDS > diff --git a/package/xavante/xavante.mk b/package/xavante/xavante.mk > index 0c1c6f1..d1ca320 100644 > --- a/package/xavante/xavante.mk > +++ b/package/xavante/xavante.mk > @@ -6,7 +6,6 @@ > > XAVANTE_VERSION = 2.2.1 > XAVANTE_SITE = http://github.com/downloads/keplerproject/xavante > -XAVANTE_DEPENDENCIES = cgilua copas coxpcall lua luafilesystem luasocket wsapi > XAVANTE_LICENSE = MIT > > define XAVANTE_INSTALL_TARGET_CMDS > -- > 1.7.9.5 >
Dear Francois Perrad, On Sat, 15 Dec 2012 10:33:21 +0100, Francois Perrad wrote: > runtime dependencies are handled in Config.in > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> If those are runtime dependencies only, then you need to update the Config.in file to add a comment explaining that it's a runtime dependency. Generally, when a package selects another one in its Config.in, we expect the .mk file to have this dependency as well. When it's not the case, we want a comment that explains why. # Runtime dependency only select BR2_PACKAGE_LUAFILESYSTEM Could you post an updated version of your [PATCH 1/2] with this change? Thanks, Thomas
diff --git a/package/cgilua/cgilua.mk b/package/cgilua/cgilua.mk index 48ee005..184d836 100644 --- a/package/cgilua/cgilua.mk +++ b/package/cgilua/cgilua.mk @@ -6,7 +6,6 @@ CGILUA_VERSION = 5.1.4 CGILUA_SITE = http://github.com/downloads/keplerproject/cgilua -CGILUA_DEPENDENCIES = luafilesystem CGILUA_LICENSE = MIT define CGILUA_INSTALL_TARGET_CMDS diff --git a/package/copas/copas.mk b/package/copas/copas.mk index c84a6cc..d3e6576 100644 --- a/package/copas/copas.mk +++ b/package/copas/copas.mk @@ -6,7 +6,6 @@ COPAS_VERSION = 1.1.6 COPAS_SITE = http://github.com/downloads/keplerproject/copas -COPAS_DEPENDENCIES = lua coxpcall luasocket COPAS_LICENSE = MIT define COPAS_INSTALL_TARGET_CMDS diff --git a/package/coxpcall/coxpcall.mk b/package/coxpcall/coxpcall.mk index e7fb76d..329d6fd 100644 --- a/package/coxpcall/coxpcall.mk +++ b/package/coxpcall/coxpcall.mk @@ -6,7 +6,6 @@ COXPCALL_VERSION = 1.13.0 COXPCALL_SITE = http://luaforge.net/frs/download.php/3406 -COXPCALL_DEPENDENCIES = lua COXPCALL_LICENSE = MIT define COXPCALL_INSTALL_TARGET_CMDS diff --git a/package/wsapi/wsapi.mk b/package/wsapi/wsapi.mk index eb2b51c..4628530 100644 --- a/package/wsapi/wsapi.mk +++ b/package/wsapi/wsapi.mk @@ -6,7 +6,6 @@ WSAPI_VERSION = 1.5 WSAPI_SITE = http://github.com/downloads/keplerproject/wsapi -WSAPI_DEPENDENCIES = coxpcall luafilesystem rings WSAPI_LICENSE = MIT define WSAPI_INSTALL_TARGET_CMDS diff --git a/package/xavante/xavante.mk b/package/xavante/xavante.mk index 0c1c6f1..d1ca320 100644 --- a/package/xavante/xavante.mk +++ b/package/xavante/xavante.mk @@ -6,7 +6,6 @@ XAVANTE_VERSION = 2.2.1 XAVANTE_SITE = http://github.com/downloads/keplerproject/xavante -XAVANTE_DEPENDENCIES = cgilua copas coxpcall lua luafilesystem luasocket wsapi XAVANTE_LICENSE = MIT define XAVANTE_INSTALL_TARGET_CMDS
runtime dependencies are handled in Config.in Signed-off-by: Francois Perrad <francois.perrad@gadz.org> --- package/cgilua/cgilua.mk | 1 - package/copas/copas.mk | 1 - package/coxpcall/coxpcall.mk | 1 - package/wsapi/wsapi.mk | 1 - package/xavante/xavante.mk | 1 - 5 files changed, 5 deletions(-)