| Message ID | CAFk-A4=BgAP5Bzt7Tku6h3L5E-fKqdomPuepqwsbkgvXMHZWCQ@mail.gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Feb 26, 2013 at 10:36:00PM +0900, Masashi Honma wrote: > diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c > @@ -1344,7 +1344,7 @@ int wpa_supplicant_fast_associate(struct > - if (now.sec - wpa_s->last_scan.sec > 5) { > + if (now.sec - wpa_s->last_scan.sec > wpa_s->conf->bss_expiration_age) { > wpa_printf(MSG_DEBUG, "Fast associate: Old scan results"); This would change the default behavior to use up to 180 seconds old scan results to avoid the new scan. I don't think I want to go that far as the default behavior.. Scan results may have changed considerably and BSS or even network selection is not really going to be ideal if the device has moved.
On Thu, Feb 28, 2013 at 6:37 AM, Jouni Malinen <j@w1.fi> wrote: > On Tue, Feb 26, 2013 at 10:36:00PM +0900, Masashi Honma wrote: >> diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c >> @@ -1344,7 +1344,7 @@ int wpa_supplicant_fast_associate(struct > >> - if (now.sec - wpa_s->last_scan.sec > 5) { >> + if (now.sec - wpa_s->last_scan.sec > wpa_s->conf->bss_expiration_age) { >> wpa_printf(MSG_DEBUG, "Fast associate: Old scan results"); > > This would change the default behavior to use up to 180 seconds old scan > results to avoid the new scan. I don't think I want to go that far as > the default behavior.. Scan results may have changed considerably and > BSS or even network selection is not really going to be ideal if the > device has moved. Moreover, AFAIK the information needed in cfg80211 to perform association expires fairly quickly, so it doesn't take long before a fast-associate will fail anyway and necessitate a scan anyway. > > -- > Jouni Malinen PGP id EFC895FA > _______________________________________________ > HostAP mailing list > HostAP@lists.shmoo.com > http://lists.shmoo.com/mailman/listinfo/hostap
diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c index 6c8ab6c..8507a42 100644 --- a/wpa_supplicant/events.c +++ b/wpa_supplicant/events.c @@ -1344,7 +1344,7 @@ int wpa_supplicant_fast_associate(struct wpa_supplicant *wpa_s) return -1; os_get_time(&now); - if (now.sec - wpa_s->last_scan.sec > 5) { + if (now.sec - wpa_s->last_scan.sec > wpa_s->conf->bss_expiration_age) { wpa_printf(MSG_DEBUG, "Fast associate: Old scan results"); return -1;
Signed-hostap: Masashi Honma <masashi.honma@gmail.com> } Regards, Masashi Honma.