[U-Boot,2/2] ARM: tegra: make CONFIG_CMD_PART common

From: Stephen Warren <swarren@nvidia.com>

This is useful on all Tegras, so that boot.scr on all devices can use
the same commands. Hence, move it to tegra-common.h.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 include/configs/tegra-common.h   |    2 ++
 include/configs/tegra20-common.h |    3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)

On 02/26/2013 04:00 PM, Stephen Warren wrote:
> This is useful on all Tegras, so that boot.scr on all devices can use
> the same commands. Hence, move it to tegra-common.h.

Unfortunately, this breaks Tegra114 builds because no partition types
are enabled, and CONFIG_CMD_PART requires functionality that's only
enabled if some partition types are supported.

There are two possible solutions:

1) Conditionally enable PARTITION_UUIDS and CMD_PART in
tegra-common-post.h only if some partition type is enabled.

2) Also enable DOS and EFI partitions in tegra-common.h, along with all
of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards
this won't be any change. For the Colibri T20 and Avionic Design boards,
this ends up enabling a few more options.

(or perhaps enable all of those in tegra-common-post.h only if support
for any block device is enabled)

I prefer option (2). Does anyone object?

On Wed, Feb 27, 2013 at 02:03:37PM -0700, Stephen Warren wrote:
> On 02/26/2013 04:00 PM, Stephen Warren wrote:
> > This is useful on all Tegras, so that boot.scr on all devices can use
> > the same commands. Hence, move it to tegra-common.h.
> 
> Unfortunately, this breaks Tegra114 builds because no partition types
> are enabled, and CONFIG_CMD_PART requires functionality that's only
> enabled if some partition types are supported.
> 
> There are two possible solutions:
> 
> 1) Conditionally enable PARTITION_UUIDS and CMD_PART in
> tegra-common-post.h only if some partition type is enabled.
> 
> 2) Also enable DOS and EFI partitions in tegra-common.h, along with all
> of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards
> this won't be any change. For the Colibri T20 and Avionic Design boards,
> this ends up enabling a few more options.
> 
> (or perhaps enable all of those in tegra-common-post.h only if support
> for any block device is enabled)
> 
> I prefer option (2). Does anyone object?

Fine with me. I recently posted patches that enable some of these
options as part of boot script support on Tamonten boards anyway.

Thierry

Am Mittwoch, den 27.02.2013, 14:03 -0700 schrieb Stephen Warren:
> On 02/26/2013 04:00 PM, Stephen Warren wrote:
> > This is useful on all Tegras, so that boot.scr on all devices can use
> > the same commands. Hence, move it to tegra-common.h.
> 
> Unfortunately, this breaks Tegra114 builds because no partition types
> are enabled, and CONFIG_CMD_PART requires functionality that's only
> enabled if some partition types are supported.
> 
> There are two possible solutions:
> 
> 1) Conditionally enable PARTITION_UUIDS and CMD_PART in
> tegra-common-post.h only if some partition type is enabled.
> 
> 2) Also enable DOS and EFI partitions in tegra-common.h, along with all
> of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards
> this won't be any change. For the Colibri T20 and Avionic Design boards,
> this ends up enabling a few more options.
> 
> (or perhaps enable all of those in tegra-common-post.h only if support
> for any block device is enabled)
> 
> I prefer option (2). Does anyone object?
> 
No objections. There is no real reason to leave out all those options as
we are not size limited on the Colibri.

Regards,
Lucas