| Message ID | 045f10c12bcbdb388e3a4151256d9223623c75c0.1361246789.git.peter.crosthwaite@xilinx.com |
|---|---|
| State | New |
| Headers | show |
On 19.02.2013, at 05:19, Peter Crosthwaite wrote: > Add dtc submodule as a fallback for old distros. > Picking version 1.3.0. as this is the most recently tagged stable version. > > Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > --- > > .gitmodules | 3 +++ > dtc | 1 + > 2 files changed, 4 insertions(+), 0 deletions(-) > create mode 160000 dtc > > diff --git a/.gitmodules b/.gitmodules > index cfa2af9..b426ea6 100644 > --- a/.gitmodules > +++ b/.gitmodules > @@ -22,3 +22,6 @@ > [submodule "pixman"] > path = pixman > url = git://anongit.freedesktop.org/pixman > +[submodule "dtc"] > + path = dtc > + url = git://git.qemu.org/dtc.git > diff --git a/dtc b/dtc > new file mode 160000 > index 0000000..bc895d6 > --- /dev/null > +++ b/dtc I still don't think that we should have compat submodules in the top level directory. Alex > @@ -0,0 +1 @@ > +Subproject commit bc895d6d09695d05ceb8b52486ffe861d6cfbdde > -- > 1.7.0.4 >
Hi, >> diff --git a/dtc b/dtc >> new file mode 160000 >> index 0000000..bc895d6 >> --- /dev/null >> +++ b/dtc > > I still don't think that we should have compat submodules in the top level directory. > Don't think this is a big issue. We have only two now. If the number grows to 4-5 (which I don't expect happening) it's worth moving them into a compat subdir to not clutter the toplevel dir too much. cheers, Gerd
On 25.02.2013, at 13:24, Gerd Hoffmann wrote: > Hi, > >>> diff --git a/dtc b/dtc >>> new file mode 160000 >>> index 0000000..bc895d6 >>> --- /dev/null >>> +++ b/dtc >> >> I still don't think that we should have compat submodules in the top level directory. >> > > Don't think this is a big issue. We have only two now. If the number > grows to 4-5 (which I don't expect happening) it's worth moving them > into a compat subdir to not clutter the toplevel dir too much. Would it be much work to do so now? Alex
On 02/25/13 13:36, Alexander Graf wrote: > > On 25.02.2013, at 13:24, Gerd Hoffmann wrote: > >> Hi, >> >>>> diff --git a/dtc b/dtc >>>> new file mode 160000 >>>> index 0000000..bc895d6 >>>> --- /dev/null >>>> +++ b/dtc >>> >>> I still don't think that we should have compat submodules in the top level directory. >>> >> >> Don't think this is a big issue. We have only two now. If the number >> grows to 4-5 (which I don't expect happening) it's worth moving them >> into a compat subdir to not clutter the toplevel dir too much. > > Would it be much work to do so now? Certainly more than a five minute job, especially the build testing to make sure you didn't forgot something which then breaks out-of-tree builds / cross-builds / whatever. Feel free to send patches if it bugs you too much. cheers, Gerd
diff --git a/.gitmodules b/.gitmodules index cfa2af9..b426ea6 100644 --- a/.gitmodules +++ b/.gitmodules @@ -22,3 +22,6 @@ [submodule "pixman"] path = pixman url = git://anongit.freedesktop.org/pixman +[submodule "dtc"] + path = dtc + url = git://git.qemu.org/dtc.git diff --git a/dtc b/dtc new file mode 160000 index 0000000..bc895d6 --- /dev/null +++ b/dtc @@ -0,0 +1 @@ +Subproject commit bc895d6d09695d05ceb8b52486ffe861d6cfbdde
Add dtc submodule as a fallback for old distros. Picking version 1.3.0. as this is the most recently tagged stable version. Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> --- .gitmodules | 3 +++ dtc | 1 + 2 files changed, 4 insertions(+), 0 deletions(-) create mode 160000 dtc