| Message ID | 1361259199-24709-1-git-send-email-jchandra@broadcom.com |
|---|---|
| State | Accepted |
| Headers | show |
>>>>> "Jayachandran" == Jayachandran C <jchandra@broadcom.com> writes: Jayachandran> After commit a000b8c1 [i2c: ocores: Add support for the Jayachandran> GRLIB port of the controller and use function pointers Jayachandran> for getreg and setreg function], compiling i2c-ocores.c Jayachandran> for 64-bit gives the following warning: Jayachandran> drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_of_probe': Jayachandran> drivers/i2c/busses/i2c-ocores.c:334:15: warning: cast from pointer to integer of different size Jayachandran> Fix it by casting the pointer to long. I've CC'ed Andreas who made the change. Acked-by: Peter Korsgaard <jacmet@sunsite.dk> Jayachandran> Signed-off-by: Jayachandran C <jchandra@broadcom.com> Jayachandran> --- Jayachandran> drivers/i2c/busses/i2c-ocores.c | 2 +- Jayachandran> 1 file changed, 1 insertion(+), 1 deletion(-) Jayachandran> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c Jayachandran> index a873d0a..6afa02d 100644 Jayachandran> --- a/drivers/i2c/busses/i2c-ocores.c Jayachandran> +++ b/drivers/i2c/busses/i2c-ocores.c Jayachandran> @@ -331,7 +331,7 @@ static int ocores_i2c_of_probe(struct platform_device *pdev, Jayachandran> &i2c->reg_io_width); Jayachandran> match = of_match_node(ocores_i2c_match, pdev->dev.of_node); Jayachandran> - if (match && (int)match->data == TYPE_GRLIB) { Jayachandran> + if (match && (long)match->data == TYPE_GRLIB) { Jayachandran> dev_dbg(&pdev->dev, "GRLIB variant of i2c-ocores\n"); i2c-> setreg = oc_setreg_grlib; i2c-> getreg = oc_getreg_grlib; Jayachandran> -- Jayachandran> 1.7.9.5 Jayachandran> -- Jayachandran> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in Jayachandran> the body of a message to majordomo@vger.kernel.org Jayachandran> More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013-02-19 09:31, Peter Korsgaard wrote: >>>>>> "Jayachandran" == Jayachandran C <jchandra@broadcom.com> writes: > > Jayachandran> After commit a000b8c1 [i2c: ocores: Add support for the > Jayachandran> GRLIB port of the controller and use function pointers > Jayachandran> for getreg and setreg function], compiling i2c-ocores.c > Jayachandran> for 64-bit gives the following warning: > > Jayachandran> drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_of_probe': > Jayachandran> drivers/i2c/busses/i2c-ocores.c:334:15: warning: cast from pointer to integer of different size > > Jayachandran> Fix it by casting the pointer to long. > > I've CC'ed Andreas who made the change. > > Acked-by: Peter Korsgaard <jacmet@sunsite.dk> Thanks! Acked-by: Andreas Larsson <andreas@gaisler.com> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 19, 2013 at 01:03:19PM +0530, Jayachandran C wrote: > After commit a000b8c1 [i2c: ocores: Add support for the GRLIB port of the > controller and use function pointers for getreg and setreg function], > compiling i2c-ocores.c for 64-bit gives the following warning: > > drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_of_probe': > drivers/i2c/busses/i2c-ocores.c:334:15: warning: cast from pointer to integer of different size > > Fix it by casting the pointer to long. > > Signed-off-by: Jayachandran C <jchandra@broadcom.com> Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index a873d0a..6afa02d 100644 --- a/drivers/i2c/busses/i2c-ocores.c +++ b/drivers/i2c/busses/i2c-ocores.c @@ -331,7 +331,7 @@ static int ocores_i2c_of_probe(struct platform_device *pdev, &i2c->reg_io_width); match = of_match_node(ocores_i2c_match, pdev->dev.of_node); - if (match && (int)match->data == TYPE_GRLIB) { + if (match && (long)match->data == TYPE_GRLIB) { dev_dbg(&pdev->dev, "GRLIB variant of i2c-ocores\n"); i2c->setreg = oc_setreg_grlib; i2c->getreg = oc_getreg_grlib;
After commit a000b8c1 [i2c: ocores: Add support for the GRLIB port of the controller and use function pointers for getreg and setreg function], compiling i2c-ocores.c for 64-bit gives the following warning: drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_of_probe': drivers/i2c/busses/i2c-ocores.c:334:15: warning: cast from pointer to integer of different size Fix it by casting the pointer to long. Signed-off-by: Jayachandran C <jchandra@broadcom.com> --- drivers/i2c/busses/i2c-ocores.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)