| Message ID | 003601ce0b50$726cb860$57462920$%han@samsung.com |
|---|---|
| State | Rejected |
| Headers | show |
On Fri, 15 Feb 2013 16:45:38 +0900 Jingoo Han <jg1.han@samsung.com> wrote: > Fixed build warning as below: > > drivers/rtc/rtc-max77686.c: In function 'max77686_rtc_update': > drivers/rtc/rtc-max77686.c:147:6: warning: 'data' may be used uninitialized in this function [-Wuninitialized] > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/rtc/rtc-max77686.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index abe27c0..2634fed 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -133,7 +133,7 @@ static int max77686_rtc_update(struct max77686_rtc_info *info, > enum MAX77686_RTC_OP op) > { > int ret; > - unsigned int data; > + unsigned int data = 0; > > switch (op) { > case MAX77686_RTC_WRITE: spose so. But the end result is rather awkward-looking. As `op' must be (and is) one of MAX77686_RTC_WRITE and MAX77686_RTC_READ, the straightfoward implementation is static int max77686_rtc_update(struct max77686_rtc_info *info, enum MAX77686_RTC_OP op) { int ret; unsigned int data; if (op == MAX77686_RTC_WRITE) data = 1 << RTC_UDR_SHIFT; else data = 1 << RTC_RBUDR_SHIFT;
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index abe27c0..2634fed 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -133,7 +133,7 @@ static int max77686_rtc_update(struct max77686_rtc_info *info, enum MAX77686_RTC_OP op) { int ret; - unsigned int data; + unsigned int data = 0; switch (op) { case MAX77686_RTC_WRITE:
Fixed build warning as below: drivers/rtc/rtc-max77686.c: In function 'max77686_rtc_update': drivers/rtc/rtc-max77686.c:147:6: warning: 'data' may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/rtc/rtc-max77686.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)