| Message ID | 1359373261-16796-2-git-send-email-fabio.estevam@freescale.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
On Mon, Jan 28, 2013 at 9:41 AM, Fabio Estevam <fabio.estevam@freescale.com> wrote: > The baudrate is already defined by CONFIG_BAUDRATE and there is no need > to keep CONFIG_SYS_BAUDRATE_TABLE. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Otavio Salvador <otavio@ossystems.com.br> -- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Dear Fabio Estevam, > The baudrate is already defined by CONFIG_BAUDRATE and there is no need > to keep CONFIG_SYS_BAUDRATE_TABLE. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > include/configs/mx23evk.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h > index 51aa9c4..e43b93f 100644 > --- a/include/configs/mx23evk.h > +++ b/include/configs/mx23evk.h > @@ -110,7 +110,6 @@ > #define CONFIG_PL01x_PORTS { (void *)MXS_UARTDBG_BASE } > #define CONFIG_CONS_INDEX 0 > #define CONFIG_BAUDRATE 115200 /* Default baud rate */ > -#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } This will not allow different baudrates now, will it? Best regards, Marek Vasut
On Mon, Jan 28, 2013 at 10:46 AM, Marek Vasut <marex@denx.de> wrote: > This will not allow different baudrates now, will it? You still may change the baudrate if you need to. CONFIG_SYS_BAUDRATE_TABLE has been placed to a common place after the commit below: commit 26750c8aee2383a026e0cf89e9310628d3a5a6a0 Author: Tom Rini <trini@ti.com> Date: Tue Jun 19 12:54:34 2012 +0000 CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there We provide a default table of { 9600, 19200, 38400, 57600, 115200 } in <config_fallbacks.h> which mkconfig places after <configs/...h> in the generated config file. This is used when a board has not set its own table. Signed-off-by: Tom Rini <trini@ti.com>
Dear Fabio Estevam, > On Mon, Jan 28, 2013 at 10:46 AM, Marek Vasut <marex@denx.de> wrote: > > This will not allow different baudrates now, will it? > > You still may change the baudrate if you need to. > > CONFIG_SYS_BAUDRATE_TABLE has been placed to a common place after the > commit below: > > commit 26750c8aee2383a026e0cf89e9310628d3a5a6a0 > Author: Tom Rini <trini@ti.com> > Date: Tue Jun 19 12:54:34 2012 +0000 > > CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there > > We provide a default table of { 9600, 19200, 38400, 57600, 115200 } > in <config_fallbacks.h> which mkconfig places after <configs/...h> in > the generated config file. This is used when a board has not set its > own table. > > Signed-off-by: Tom Rini <trini@ti.com> Ok then I'd say -- kill 'em all!! Best regards, Marek Vasut
On 28/01/2013 12:41, Fabio Estevam wrote: > The baudrate is already defined by CONFIG_BAUDRATE and there is no need > to keep CONFIG_SYS_BAUDRATE_TABLE. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic
diff --git a/include/configs/mx23evk.h b/include/configs/mx23evk.h index 51aa9c4..e43b93f 100644 --- a/include/configs/mx23evk.h +++ b/include/configs/mx23evk.h @@ -110,7 +110,6 @@ #define CONFIG_PL01x_PORTS { (void *)MXS_UARTDBG_BASE } #define CONFIG_CONS_INDEX 0 #define CONFIG_BAUDRATE 115200 /* Default baud rate */ -#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } /* DMA */ #define CONFIG_APBH_DMA
The baudrate is already defined by CONFIG_BAUDRATE and there is no need to keep CONFIG_SYS_BAUDRATE_TABLE. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- include/configs/mx23evk.h | 1 - 1 file changed, 1 deletion(-)