| Message ID | 1360330602-30472-9-git-send-email-pdeschrijver@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi, On Fri, Feb 08, 2013 at 03:36:40PM +0200, Peter De Schrijver wrote: > tegra_car: clock { > - compatible = "nvidia,tegra114-car, nvidia,tegra30-car"; > + compatible = "nvidia,tegra114-car"; trailing change or intentional ?
On 02/08/2013 07:03 AM, Felipe Balbi wrote: > Hi, > > On Fri, Feb 08, 2013 at 03:36:40PM +0200, Peter De Schrijver > wrote: >> tegra_car: clock { - compatible = "nvidia,tegra114-car, >> nvidia,tegra30-car"; + compatible = "nvidia,tegra114-car"; > > trailing change or intentional ? I believe it's intentional since the HW isn't fully backwards-compatible. However, the commit description should mention this. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Feb 08, 2013 at 03:03:02PM +0100, Felipe Balbi wrote: > * PGP Signed by an unknown key > > Hi, > > On Fri, Feb 08, 2013 at 03:36:40PM +0200, Peter De Schrijver wrote: > > tegra_car: clock { > > - compatible = "nvidia,tegra114-car, nvidia,tegra30-car"; > > + compatible = "nvidia,tegra114-car"; > > trailing change or intentional ? No, the Tegra30 car driver shouldn't be used for Tegra114. Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi index 96a8235..6b0a01e 100644 --- a/arch/arm/boot/dts/tegra114.dtsi +++ b/arch/arm/boot/dts/tegra114.dtsi @@ -24,10 +24,11 @@ 0 42 0x04 0 121 0x04 0 122 0x04>; + clocks = <&tegra_car 5>; }; tegra_car: clock { - compatible = "nvidia,tegra114-car, nvidia,tegra30-car"; + compatible = "nvidia,tegra114-car"; reg = <0x60006000 0x1000>; #clock-cells = <1>; }; @@ -43,6 +44,7 @@ reg-shift = <2>; interrupts = <0 36 0x04>; status = "disabled"; + clocks = <&tegra_car 6>; }; serial@70006040 { @@ -51,6 +53,7 @@ reg-shift = <2>; interrupts = <0 37 0x04>; status = "disabled"; + clocks = <&tegra_car 192>; }; serial@70006200 { @@ -59,6 +62,7 @@ reg-shift = <2>; interrupts = <0 46 0x04>; status = "disabled"; + clocks = <&tegra_car 55>; }; serial@70006300 { @@ -67,12 +71,14 @@ reg-shift = <2>; interrupts = <0 90 0x04>; status = "disabled"; + clocks = <&tegra_car 65>; }; rtc { compatible = "nvidia,tegra114-rtc", "nvidia,tegra20-rtc"; reg = <0x7000e000 0x100>; interrupts = <0 2 0x04>; + clocks = <&tegra_car 4>; }; pmc {
Add references to tegra_car clocks for the basic device nodes. Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> --- arch/arm/boot/dts/tegra114.dtsi | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)