| Message ID | 1359299779-25107-1-git-send-email-afaerber@suse.de |
|---|---|
| State | New |
| Headers | show |
Am 27.01.2013 16:16, schrieb Andreas Färber: > The automatic drop of -Werror during the RC phases has in the past led > to warnings creeping into submaintainer trees. > > Last QEMU Summit it was concluded that -Werror should stay on and > enabled only as part of the release process. be disabled, obviously :) > To relieve our release manager, instead of always enabling -Werror or > doing some number magic, let's enable it depending on whether a .git/ > directory exists in the source tree. > > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > configure | 2 +- > 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) > > diff --git a/configure b/configure > index b7635e4..0657b1a 100755 > --- a/configure > +++ b/configure > @@ -1180,7 +1180,7 @@ fi > z_version=`cut -f3 -d. $source_path/VERSION` > > if test -z "$werror" ; then > - if test "$z_version" = "50" -a \ > + if test -d "$source_path/.git" -a \ > "$linux" = "yes" ; then > werror="yes" > else
Am 27.01.2013 16:20, schrieb Andreas Färber: > Am 27.01.2013 16:16, schrieb Andreas Färber: >> The automatic drop of -Werror during the RC phases has in the past led >> to warnings creeping into submaintainer trees. >> >> Last QEMU Summit it was concluded that -Werror should stay on and >> enabled only as part of the release process. > > be disabled, obviously :) > >> To relieve our release manager, instead of always enabling -Werror or >> doing some number magic, let's enable it depending on whether a .git/ >> directory exists in the source tree. >> >> Signed-off-by: Andreas Färber <afaerber@suse.de> Big PING for rc0! Andreas >> --- >> configure | 2 +- >> 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) >> >> diff --git a/configure b/configure >> index b7635e4..0657b1a 100755 >> --- a/configure >> +++ b/configure >> @@ -1180,7 +1180,7 @@ fi >> z_version=`cut -f3 -d. $source_path/VERSION` >> >> if test -z "$werror" ; then >> - if test "$z_version" = "50" -a \ >> + if test -d "$source_path/.git" -a \ >> "$linux" = "yes" ; then >> werror="yes" >> else >
Applied. Thanks. Regards, Anthony Liguori
diff --git a/configure b/configure index b7635e4..0657b1a 100755 --- a/configure +++ b/configure @@ -1180,7 +1180,7 @@ fi z_version=`cut -f3 -d. $source_path/VERSION` if test -z "$werror" ; then - if test "$z_version" = "50" -a \ + if test -d "$source_path/.git" -a \ "$linux" = "yes" ; then werror="yes" else
The automatic drop of -Werror during the RC phases has in the past led to warnings creeping into submaintainer trees. Last QEMU Summit it was concluded that -Werror should stay on and enabled only as part of the release process. To relieve our release manager, instead of always enabling -Werror or doing some number magic, let's enable it depending on whether a .git/ directory exists in the source tree. Signed-off-by: Andreas Färber <afaerber@suse.de> --- configure | 2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)