| Message ID | 1357210966-29251-1-git-send-email-alexey.brodkin@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Thu, Jan 03, 2013 at 01:02:46AM -0000, Alexey Brodkin wrote: > Currently we have "unsigned long blkcnt" which is fine with > CONFIG_SYS_64BIT_LBA undefined because "lbaint_t" is basically the same > "unsigned long". > If CONFIG_SYS_64BIT_LBA gets defined "lbaint_t" is defined as "unsigned > long long". > > Even though not many embedded systems have CONFIG_SYS_64BIT_LBA defined > it's good to have types in function implementation that match exactly > with prototypes. > > Signed-off-by: Alexey Brodkin <alexey.brodkin@gmail.com> Applied to u-boot/master, thanks!
diff --git a/drivers/block/systemace.c b/drivers/block/systemace.c index 247cf06..80076b4 100644 --- a/drivers/block/systemace.c +++ b/drivers/block/systemace.c @@ -83,7 +83,7 @@ static u16 ace_readw(unsigned off) } static unsigned long systemace_read(int dev, unsigned long start, - unsigned long blkcnt, void *buffer); + lbaint_t blkcnt, void *buffer); static block_dev_desc_t systemace_dev = { 0 }; @@ -149,7 +149,7 @@ block_dev_desc_t *systemace_get_dev(int dev) * number of blocks read. A zero return indicates an error. */ static unsigned long systemace_read(int dev, unsigned long start, - unsigned long blkcnt, void *buffer) + lbaint_t blkcnt, void *buffer) { int retry; unsigned blk_countdown;
Currently we have "unsigned long blkcnt" which is fine with CONFIG_SYS_64BIT_LBA undefined because "lbaint_t" is basically the same "unsigned long". If CONFIG_SYS_64BIT_LBA gets defined "lbaint_t" is defined as "unsigned long long". Even though not many embedded systems have CONFIG_SYS_64BIT_LBA defined it's good to have types in function implementation that match exactly with prototypes. Signed-off-by: Alexey Brodkin <alexey.brodkin@gmail.com> --- drivers/block/systemace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)