| Message ID | 1358855740-20459-1-git-send-email-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Jan 22, 2013 at 7:55 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > PnP BIOS messages are normally classified as errors. The following > warning is just an info message from the kernel and currently triggers > fwts klog scanner to report an error: > > "PnPBIOS: Disabled by ACPI PNP" > > ..so make this into an info message rather than an error. > > This false positive was detected by fwts in bug report LP:#1102370 > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > data/klog.json | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/data/klog.json b/data/klog.json > index 447c331..d526979 100644 > --- a/data/klog.json > +++ b/data/klog.json > @@ -1356,6 +1356,14 @@ > }, > { > "compare_mode": "regex", > + "log_level": "LOG_LEVEL_INFO", > + "tag": "FWTS_TAG_ACPI", > + "pattern": "PnPBIOS.*Disabled by ACPI PNP", > + "advice": "The PnPBIOS driver was disabled because PnP support is provided by the ACPI driver.", > + "label": "KlogPnpBiosDisabled" > + }, > + { > + "compare_mode": "regex", > "log_level": "LOG_LEVEL_HIGH", > "tag": "FWTS_TAG_ACPI", > "pattern": "PnPBIOS.*", > -- > 1.8.0 > Acked-by: Keng-Yu Lin <kengyu@canonical.com>
On 01/22/2013 07:55 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > PnP BIOS messages are normally classified as errors. The following > warning is just an info message from the kernel and currently triggers > fwts klog scanner to report an error: > > "PnPBIOS: Disabled by ACPI PNP" > > ..so make this into an info message rather than an error. > > This false positive was detected by fwts in bug report LP:#1102370 > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > data/klog.json | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/data/klog.json b/data/klog.json > index 447c331..d526979 100644 > --- a/data/klog.json > +++ b/data/klog.json > @@ -1356,6 +1356,14 @@ > }, > { > "compare_mode": "regex", > + "log_level": "LOG_LEVEL_INFO", > + "tag": "FWTS_TAG_ACPI", > + "pattern": "PnPBIOS.*Disabled by ACPI PNP", > + "advice": "The PnPBIOS driver was disabled because PnP support is provided by the ACPI driver.", > + "label": "KlogPnpBiosDisabled" > + }, > + { > + "compare_mode": "regex", > "log_level": "LOG_LEVEL_HIGH", > "tag": "FWTS_TAG_ACPI", > "pattern": "PnPBIOS.*", > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/data/klog.json b/data/klog.json index 447c331..d526979 100644 --- a/data/klog.json +++ b/data/klog.json @@ -1356,6 +1356,14 @@ }, { "compare_mode": "regex", + "log_level": "LOG_LEVEL_INFO", + "tag": "FWTS_TAG_ACPI", + "pattern": "PnPBIOS.*Disabled by ACPI PNP", + "advice": "The PnPBIOS driver was disabled because PnP support is provided by the ACPI driver.", + "label": "KlogPnpBiosDisabled" + }, + { + "compare_mode": "regex", "log_level": "LOG_LEVEL_HIGH", "tag": "FWTS_TAG_ACPI", "pattern": "PnPBIOS.*",