| Message ID | 1359042370-4358-30-git-send-email-balbi@ti.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Felipe Balbi <balbi@ti.com> writes: > By simply setting a flag, we can drop some > boilerplate code. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > drivers/usb/gadget/pxa27x_udc.c | 9 +-------- Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> And I tested also your patch and it works in my environment. For next patches I'd like to be CCed for pxa27x_udc stuff as I'm maintaining that one since its beginning (and yes, I know, I didn't put that in MAINTAINERS ...). Cheers. -- Robert
On Mon, Jan 28, 2013 at 09:18:29PM +0100, Robert Jarzmik wrote: > Felipe Balbi <balbi@ti.com> writes: > > > By simply setting a flag, we can drop some > > boilerplate code. > > > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > --- > > drivers/usb/gadget/pxa27x_udc.c | 9 +-------- > Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> > > And I tested also your patch and it works in my environment. For next patches > I'd like to be CCed for pxa27x_udc stuff as I'm maintaining that one since its > beginning (and yes, I know, I didn't put that in MAINTAINERS ...). you should add yourself to MAINTAINERS. Please send a patch to Greg when you have time. No need to prepare a tree, though. I just need you to give your Acked-by and I'll queue the patches myself. cheers
diff --git a/drivers/usb/gadget/pxa27x_udc.c b/drivers/usb/gadget/pxa27x_udc.c index f7d2579..23a3eed 100644 --- a/drivers/usb/gadget/pxa27x_udc.c +++ b/drivers/usb/gadget/pxa27x_udc.c @@ -1814,11 +1814,6 @@ static int pxa27x_udc_start(struct usb_gadget *g, udc->gadget.dev.driver = &driver->driver; dplus_pullup(udc, 1); - retval = device_add(&udc->gadget.dev); - if (retval) { - dev_err(udc->dev, "device_add error %d\n", retval); - goto fail; - } if (!IS_ERR_OR_NULL(udc->transceiver)) { retval = otg_set_peripheral(udc->transceiver->otg, &udc->gadget); @@ -1876,8 +1871,6 @@ static int pxa27x_udc_stop(struct usb_gadget *g, udc->driver = NULL; - device_del(&udc->gadget.dev); - if (!IS_ERR_OR_NULL(udc->transceiver)) return otg_set_peripheral(udc->transceiver->otg, NULL); return 0; @@ -2462,9 +2455,9 @@ static int __init pxa_udc_probe(struct platform_device *pdev) goto err_map; } - device_initialize(&udc->gadget.dev); udc->gadget.dev.parent = &pdev->dev; udc->gadget.dev.dma_mask = NULL; + udc->gadget.register_my_device = true; udc->vbus_sensed = 0; the_controller = udc;
By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi <balbi@ti.com> --- drivers/usb/gadget/pxa27x_udc.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)