| Message ID | 1358662329-8294-2-git-send-email-cpuwolf@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 20-01-2013 10:12, Wei Shuai wrote: > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can define a new common structure wwan_noarp_info. Wrap your lines at 76-80 columns maximum please. > Then more similiar NO ARP devices can be handled easily > Signed-off-by: Wei Shuai <cpuwolf@gmail.com> > --- > drivers/net/usb/cdc_ncm.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c > index 71b6e92..2d699b6 100644 > --- a/drivers/net/usb/cdc_ncm.c > +++ b/drivers/net/usb/cdc_ncm.c > @@ -1155,6 +1155,20 @@ static const struct driver_info wwan_info = { > .tx_fixup = cdc_ncm_tx_fixup, > }; > > +/* Same as wwan_info, but with IFF_NOARP */ FLAG_NOARP, you mean? > +static const struct driver_info wwan_noarp_info = { > + .description = "Mobile Broadband Network Device (NO ARP)", > + .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET > + | FLAG_WWAN | FLAG_NOARP, WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
The main problem is that these devices don't support ethernet. They support IP (v4 and _maybe_ v6) with an ethernet header. Many of them will do ARP (and IPv6 ND) as well to complete the picture, but some of them don't and that's what these drivers try to deal with. Note that most of the devices will run a DHCP server, so there is some sort of IP broadcast support. Whether that qualifies as proper ethernet broadcast support is another question... These devices are attempting to bridge an IP-only point-to-point interface and an ethernet over USB interface, with the intention to make the point-to-point interface look like ethernet to applications and users. This is of course always going to be imperfect. But I believe that we should aim to help the firmware achive this goal when writing drivers instead of working against it. Setting IFF_NOARP and not IFF_POINTTOPOINT is one way to do that. ---- by Bjorn Mork <bjorn@mork.no> 2013/1/21, Sergei Shtylyov <sshtylyov@mvista.com>: > Hello. > > On 20-01-2013 10:12, Wei Shuai wrote: > >> Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can >> define a new common structure wwan_noarp_info. > > Wrap your lines at 76-80 columns maximum please. > >> Then more similiar NO ARP devices can be handled easily > > >> Signed-off-by: Wei Shuai <cpuwolf@gmail.com> >> --- >> drivers/net/usb/cdc_ncm.c | 21 +++++++++++++++++++++ >> 1 files changed, 21 insertions(+), 0 deletions(-) > >> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c >> index 71b6e92..2d699b6 100644 >> --- a/drivers/net/usb/cdc_ncm.c >> +++ b/drivers/net/usb/cdc_ncm.c >> @@ -1155,6 +1155,20 @@ static const struct driver_info wwan_info = { >> .tx_fixup = cdc_ncm_tx_fixup, >> }; >> >> +/* Same as wwan_info, but with IFF_NOARP */ > > FLAG_NOARP, you mean? > >> +static const struct driver_info wwan_noarp_info = { >> + .description = "Mobile Broadband Network Device (NO ARP)", >> + .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET >> + | FLAG_WWAN | FLAG_NOARP, > > WBR, Sergei > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Wei Shuai <cpuwolf@gmail.com> Date: Mon, 21 Jan 2013 10:20:22 +0800 > The main problem is that these devices don't support ethernet. He's saying your comment is referring to the wrong thing, rather than saying anything against what your change is doing. Read his feedback carefully: >>> +/* Same as wwan_info, but with IFF_NOARP */ >> >> FLAG_NOARP, you mean? He's saying your commnet is talking about FLAG_NOARP rather than what the core code does with this flag, which is translate into setting IFF_NOARP on the net device. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thank you David. yes in the core driver, FLAG_NOARP will be translated to IFF_NOARP 2013/1/21, David Miller <davem@davemloft.net>: > From: Wei Shuai <cpuwolf@gmail.com> > Date: Mon, 21 Jan 2013 10:20:22 +0800 > >> The main problem is that these devices don't support ethernet. > > He's saying your comment is referring to the wrong thing, > rather than saying anything against what your change is > doing. > > Read his feedback carefully: > >>>> +/* Same as wwan_info, but with IFF_NOARP */ >>> >>> FLAG_NOARP, you mean? > > He's saying your commnet is talking about FLAG_NOARP rather > than what the core code does with this flag, which is > translate into setting IFF_NOARP on the net device. > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 21-01-2013 6:20, Wei Shuai wrote: > The main problem is that these devices don't support ethernet. They > support IP (v4 and _maybe_ v6) with an ethernet header. Many of them > will do ARP (and IPv6 ND) as well to complete the picture, but some of > them don't and that's what these drivers try to deal with. > > Note that most of the devices will run a DHCP server, so there is some > sort of IP broadcast support. Whether that qualifies as proper ethernet > broadcast support is another question... > > These devices are attempting to bridge an IP-only point-to-point > interface and an ethernet over USB interface, with the intention to make > the point-to-point interface look like ethernet to applications and > users. This is of course always going to be imperfect. But I believe > that we should aim to help the firmware achive this goal when writing > drivers instead of working against it. Setting IFF_NOARP and not > IFF_POINTTOPOINT is one way to do that. ---- by Bjorn Mork <bjorn@mork.no> Why are you replying with this long story to my simple patch comments? :-) > 2013/1/21, Sergei Shtylyov <sshtylyov@mvista.com>: >> Hello. >> On 20-01-2013 10:12, Wei Shuai wrote: >>> Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can >>> define a new common structure wwan_noarp_info. >> Wrap your lines at 76-80 columns maximum please. >>> Then more similiar NO ARP devices can be handled easily s/NO/no/. >>> Signed-off-by: Wei Shuai <cpuwolf@gmail.com> >>> --- >>> drivers/net/usb/cdc_ncm.c | 21 +++++++++++++++++++++ >>> 1 files changed, 21 insertions(+), 0 deletions(-) >>> diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c >>> index 71b6e92..2d699b6 100644 >>> --- a/drivers/net/usb/cdc_ncm.c >>> +++ b/drivers/net/usb/cdc_ncm.c >>> @@ -1155,6 +1155,20 @@ static const struct driver_info wwan_info = { >>> .tx_fixup = cdc_ncm_tx_fixup, >>> }; >>> >>> +/* Same as wwan_info, but with IFF_NOARP */ >> FLAG_NOARP, you mean? >>> +static const struct driver_info wwan_noarp_info = { >>> + .description = "Mobile Broadband Network Device (NO ARP)", >>> + .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET >>> + | FLAG_WWAN | FLAG_NOARP, WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 71b6e92..2d699b6 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -1155,6 +1155,20 @@ static const struct driver_info wwan_info = { .tx_fixup = cdc_ncm_tx_fixup, }; +/* Same as wwan_info, but with IFF_NOARP */ +static const struct driver_info wwan_noarp_info = { + .description = "Mobile Broadband Network Device (NO ARP)", + .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT | FLAG_MULTI_PACKET + | FLAG_WWAN | FLAG_NOARP, + .bind = cdc_ncm_bind, + .unbind = cdc_ncm_unbind, + .check_connect = cdc_ncm_check_connect, + .manage_power = usbnet_manage_power, + .status = cdc_ncm_status, + .rx_fixup = cdc_ncm_rx_fixup, + .tx_fixup = cdc_ncm_tx_fixup, +}; + static const struct usb_device_id cdc_devs[] = { /* Ericsson MBM devices like F5521gw */ { .match_flags = USB_DEVICE_ID_MATCH_INT_INFO @@ -1194,6 +1208,13 @@ static const struct usb_device_id cdc_devs[] = { .driver_info = (unsigned long)&wwan_info, }, + /* Infineon(now Intel) HSPA Modem platform */ + { USB_DEVICE_AND_INTERFACE_INFO(0x1519, 0x0443, + USB_CLASS_COMM, + USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE), + .driver_info = (unsigned long)&wwan_noarp_info, + }, + /* Generic CDC-NCM devices */ { USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),
Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can define a new common structure wwan_noarp_info. Then more similiar NO ARP devices can be handled easily Signed-off-by: Wei Shuai <cpuwolf@gmail.com> --- drivers/net/usb/cdc_ncm.c | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-)