| Message ID | 1358456378-29248-2-git-send-email-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
Am 17.01.2013 21:59, schrieb Eduardo Habkost: > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > Cc: kvm@vger.kernel.org > Cc: Michael S. Tsirkin <mst@redhat.com> > Cc: Gleb Natapov <gleb@redhat.com> > Cc: Marcelo Tosatti <mtosatti@redhat.com> It appears as if Cc: below --- gets ignored? Please check and ping those people if necessary. Personally, I adopted the convention of having to-be-persisted CCs above Sob and stripping trailing CCs when applying. Andreas > --- > include/sysemu/kvm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 6bdd513..22acf91 100644 > --- a/include/sysemu/kvm.h > +++ b/include/sysemu/kvm.h > @@ -36,6 +36,7 @@ > #define KVM_FEATURE_ASYNC_PF 0 > #define KVM_FEATURE_STEAL_TIME 0 > #define KVM_FEATURE_PV_EOI 0 > +#define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 0 > #endif > > extern int kvm_allowed;
On Fri, Jan 18, 2013 at 12:17:56PM +0100, Andreas Färber wrote: > Am 17.01.2013 21:59, schrieb Eduardo Habkost: > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > --- > > Cc: kvm@vger.kernel.org > > Cc: Michael S. Tsirkin <mst@redhat.com> > > Cc: Gleb Natapov <gleb@redhat.com> > > Cc: Marcelo Tosatti <mtosatti@redhat.com> > > It appears as if Cc: below --- gets ignored? Please check and ping those > people if necessary. I believe it depends on git-send-email suppress-cc option. At least I remember this format have worked for me before, I need to check what changed on my config. > > Personally, I adopted the convention of having to-be-persisted CCs above > Sob and stripping trailing CCs when applying. I considered the CC lines not part of the commit message (just like the changelog isn't), so I decided to put them after "---". > > Andreas > > > --- > > include/sysemu/kvm.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > > index 6bdd513..22acf91 100644 > > --- a/include/sysemu/kvm.h > > +++ b/include/sysemu/kvm.h > > @@ -36,6 +36,7 @@ > > #define KVM_FEATURE_ASYNC_PF 0 > > #define KVM_FEATURE_STEAL_TIME 0 > > #define KVM_FEATURE_PV_EOI 0 > > +#define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 0 > > #endif > > > > extern int kvm_allowed; > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
On Fri, Jan 18, 2013 at 09:36:33AM -0200, Eduardo Habkost wrote: > On Fri, Jan 18, 2013 at 12:17:56PM +0100, Andreas Färber wrote: > > Am 17.01.2013 21:59, schrieb Eduardo Habkost: > > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > > --- > > > Cc: kvm@vger.kernel.org > > > Cc: Michael S. Tsirkin <mst@redhat.com> > > > Cc: Gleb Natapov <gleb@redhat.com> > > > Cc: Marcelo Tosatti <mtosatti@redhat.com> > > > > It appears as if Cc: below --- gets ignored? Please check and ping those > > people if necessary. > > I believe it depends on git-send-email suppress-cc option. At least I > remember this format have worked for me before, I need to check what > changed on my config. > > > > > Personally, I adopted the convention of having to-be-persisted CCs above > > Sob and stripping trailing CCs when applying. > > I considered the CC lines not part of the commit message (just like the > changelog isn't), so I decided to put them after "---". > This may be the reason git-send-email ignored it. > > > > Andreas > > > > > --- > > > include/sysemu/kvm.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > > > index 6bdd513..22acf91 100644 > > > --- a/include/sysemu/kvm.h > > > +++ b/include/sysemu/kvm.h > > > @@ -36,6 +36,7 @@ > > > #define KVM_FEATURE_ASYNC_PF 0 > > > #define KVM_FEATURE_STEAL_TIME 0 > > > #define KVM_FEATURE_PV_EOI 0 > > > +#define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 0 > > > #endif > > > > > > extern int kvm_allowed; > > > > -- > > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg > > -- > Eduardo -- Gleb.
On Fri, Jan 18, 2013 at 01:48:38PM +0200, Gleb Natapov wrote: > On Fri, Jan 18, 2013 at 09:36:33AM -0200, Eduardo Habkost wrote: > > On Fri, Jan 18, 2013 at 12:17:56PM +0100, Andreas Färber wrote: > > > Am 17.01.2013 21:59, schrieb Eduardo Habkost: > > > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > > > --- > > > > Cc: kvm@vger.kernel.org > > > > Cc: Michael S. Tsirkin <mst@redhat.com> > > > > Cc: Gleb Natapov <gleb@redhat.com> > > > > Cc: Marcelo Tosatti <mtosatti@redhat.com> > > > > > > It appears as if Cc: below --- gets ignored? Please check and ping those > > > people if necessary. > > > > I believe it depends on git-send-email suppress-cc option. At least I > > remember this format have worked for me before, I need to check what > > changed on my config. > > > > > > > > Personally, I adopted the convention of having to-be-persisted CCs above > > > Sob and stripping trailing CCs when applying. > > > > I considered the CC lines not part of the commit message (just like the > > changelog isn't), so I decided to put them after "---". > > > This may be the reason git-send-email ignored it. I just tested it here, and it ignored it because I have suppress-cc=all enabled by default and (by mistake) I didn't use my script that explicitly disabled it. If I use --suppress-cc=author, git-send-email uses the CC lines before _and_ after "---".
On Thu, Jan 17, 2013 at 06:59:27PM -0200, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > Cc: kvm@vger.kernel.org > Cc: Michael S. Tsirkin <mst@redhat.com> > Cc: Gleb Natapov <gleb@redhat.com> > Cc: Marcelo Tosatti <mtosatti@redhat.com> > --- > include/sysemu/kvm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 6bdd513..22acf91 100644 > --- a/include/sysemu/kvm.h > +++ b/include/sysemu/kvm.h > @@ -36,6 +36,7 @@ > #define KVM_FEATURE_ASYNC_PF 0 > #define KVM_FEATURE_STEAL_TIME 0 > #define KVM_FEATURE_PV_EOI 0 > +#define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 0 > #endif > > extern int kvm_allowed; > -- > 1.7.11.7 > ACK
Am 22.01.2013 02:43, schrieb Marcelo Tosatti: > On Thu, Jan 17, 2013 at 06:59:27PM -0200, Eduardo Habkost wrote: >> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> >> --- >> Cc: kvm@vger.kernel.org >> Cc: Michael S. Tsirkin <mst@redhat.com> >> Cc: Gleb Natapov <gleb@redhat.com> >> Cc: Marcelo Tosatti <mtosatti@redhat.com> >> --- >> include/sysemu/kvm.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h >> index 6bdd513..22acf91 100644 >> --- a/include/sysemu/kvm.h >> +++ b/include/sysemu/kvm.h >> @@ -36,6 +36,7 @@ >> #define KVM_FEATURE_ASYNC_PF 0 >> #define KVM_FEATURE_STEAL_TIME 0 >> #define KVM_FEATURE_PV_EOI 0 >> +#define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 0 >> #endif >> >> extern int kvm_allowed; >> -- >> 1.7.11.7 >> > > ACK BTW is it the general strategy to add these as needed for new patches? Or should we add all current ones and mandate adding such dummy definitions when new ones get introduced via linux-headers/ update? Andreas
On Tue, Jan 22, 2013 at 05:59:14AM +0100, Andreas Färber wrote: > Am 22.01.2013 02:43, schrieb Marcelo Tosatti: > > On Thu, Jan 17, 2013 at 06:59:27PM -0200, Eduardo Habkost wrote: > >> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > >> --- > >> Cc: kvm@vger.kernel.org > >> Cc: Michael S. Tsirkin <mst@redhat.com> > >> Cc: Gleb Natapov <gleb@redhat.com> > >> Cc: Marcelo Tosatti <mtosatti@redhat.com> > >> --- > >> include/sysemu/kvm.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > >> index 6bdd513..22acf91 100644 > >> --- a/include/sysemu/kvm.h > >> +++ b/include/sysemu/kvm.h > >> @@ -36,6 +36,7 @@ > >> #define KVM_FEATURE_ASYNC_PF 0 > >> #define KVM_FEATURE_STEAL_TIME 0 > >> #define KVM_FEATURE_PV_EOI 0 > >> +#define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 0 > >> #endif > >> > >> extern int kvm_allowed; > >> -- > >> 1.7.11.7 > >> > > > > ACK > > BTW is it the general strategy to add these as needed for new patches? > Or should we add all current ones and mandate adding such dummy > definitions when new ones get introduced via linux-headers/ update? I meant to include all existing bits in a single patch previously, but somehow I missed the KVM_FEATURE_CLOCKSOURCE_STABLE_BIT definition when looking at the kernel header. It would be nice to automatically refresh the fake-defines list when updating linux-headers, but I won't mind if we update the list (pulling all existing bits again) only when QEMU starts using a define that is missing.
On Tue, Jan 22, 2013 at 05:59:14AM +0100, Andreas Färber wrote: > Am 22.01.2013 02:43, schrieb Marcelo Tosatti: > > On Thu, Jan 17, 2013 at 06:59:27PM -0200, Eduardo Habkost wrote: > >> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > >> --- > >> Cc: kvm@vger.kernel.org > >> Cc: Michael S. Tsirkin <mst@redhat.com> > >> Cc: Gleb Natapov <gleb@redhat.com> > >> Cc: Marcelo Tosatti <mtosatti@redhat.com> > >> --- > >> include/sysemu/kvm.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > >> index 6bdd513..22acf91 100644 > >> --- a/include/sysemu/kvm.h > >> +++ b/include/sysemu/kvm.h > >> @@ -36,6 +36,7 @@ > >> #define KVM_FEATURE_ASYNC_PF 0 > >> #define KVM_FEATURE_STEAL_TIME 0 > >> #define KVM_FEATURE_PV_EOI 0 > >> +#define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 0 > >> #endif > >> > >> extern int kvm_allowed; > >> -- > >> 1.7.11.7 > >> > > > > ACK > > BTW is it the general strategy to add these as needed for new patches? > Or should we add all current ones and mandate adding such dummy > definitions when new ones get introduced via linux-headers/ update? Its a good idea to update the sync scripts to automatically create the dummy ones, i suppose (there is no proactive strategy).
diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 6bdd513..22acf91 100644 --- a/include/sysemu/kvm.h +++ b/include/sysemu/kvm.h @@ -36,6 +36,7 @@ #define KVM_FEATURE_ASYNC_PF 0 #define KVM_FEATURE_STEAL_TIME 0 #define KVM_FEATURE_PV_EOI 0 +#define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 0 #endif extern int kvm_allowed;
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Cc: kvm@vger.kernel.org Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Gleb Natapov <gleb@redhat.com> Cc: Marcelo Tosatti <mtosatti@redhat.com> --- include/sysemu/kvm.h | 1 + 1 file changed, 1 insertion(+)