diff mbox

: Fix compilation warnings in drivers/rtc/rtc-ds1390.c

Message ID ea11fea30901190918g1e4988a7m43c96e6e037e79b@mail.gmail.com
State Accepted, archived
Headers show

Commit Message

Manish Katiyar Jan. 19, 2009, 5:18 p.m. UTC 
Below patch removes the following compilation warning
drivers/rtc/rtc-ds1390.c:125: warning: unused variable 'rtc'


Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>
---
 drivers/rtc/rtc-ds1390.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Manish Katiyar Jan. 26, 2009, 3:18 p.m. UTC | #1 
On Mon, Jan 19, 2009 at 10:48 PM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> Below patch removes the following compilation warning
> drivers/rtc/rtc-ds1390.c:125: warning: unused variable 'rtc'

Hi,

Any feedback on this ?

Thanks -
Manish

>
>
> Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>
> ---
>  drivers/rtc/rtc-ds1390.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c
> index e54b5c6..e01b955 100644
> --- a/drivers/rtc/rtc-ds1390.c
> +++ b/drivers/rtc/rtc-ds1390.c
> @@ -122,7 +122,6 @@ static const struct rtc_class_ops ds1390_rtc_ops = {
>
>  static int __devinit ds1390_probe(struct spi_device *spi)
>  {
> -       struct rtc_device *rtc;
>        unsigned char tmp;
>        struct ds1390 *chip;
>        int res;
> --
> 1.5.4.3
>
> Thanks -
> Manish
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---
Alessandro Zummo Jan. 26, 2009, 4:21 p.m. UTC | #2 
On Mon, 26 Jan 2009 20:48:28 +0530
Manish Katiyar <mkatiyar@gmail.com> wrote:

> Hi,
> 
> Any feedback on this ?

 hi, been a little busy but seems ok. you can keep an eye on the
 status on the patchwork website.
Manish Katiyar Jan. 26, 2009, 4:24 p.m. UTC | #3 
On Mon, Jan 26, 2009 at 9:51 PM, Alessandro Zummo
<alessandro.zummo@towertech.it> wrote:
> On Mon, 26 Jan 2009 20:48:28 +0530
> Manish Katiyar <mkatiyar@gmail.com> wrote:
>
>> Hi,
>>
>> Any feedback on this ?
>
>  hi, been a little busy but seems ok. you can keep an eye on the
>  status on the patchwork website.

Thanks a lot. May be a dumb question but can you please give me the
link to patchwork website.

Thanks -
Manish

>
> --
>
>  Best regards,
>
>  Alessandro Zummo,
>  Tower Technologies - Torino, Italy
>
>  http://www.towertech.it
>
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---
Alessandro Zummo Jan. 26, 2009, 4:35 p.m. UTC | #4 
On Mon, 26 Jan 2009 21:54:44 +0530
Manish Katiyar <mkatiyar@gmail.com> wrote:

> >  hi, been a little busy but seems ok. you can keep an eye on the
> >  status on the patchwork website.
> 
> Thanks a lot. May be a dumb question but can you please give me the
> link to patchwork website.

 sure!
 http://patchwork.ozlabs.org/project/rtc-linux/list/
diff mbox

Patch

diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c
index e54b5c6..e01b955 100644
--- a/drivers/rtc/rtc-ds1390.c
+++ b/drivers/rtc/rtc-ds1390.c
@@ -122,7 +122,6 @@  static const struct rtc_class_ops ds1390_rtc_ops = {

 static int __devinit ds1390_probe(struct spi_device *spi)
 {
-       struct rtc_device *rtc;
        unsigned char tmp;
        struct ds1390 *chip;
        int res;