diff mbox

proxychains-ng: copy proxychains.conf to target dir

Message ID 1358309415-12945-1-git-send-email-stefan.froberg@petroprogram.com
State Superseded
Headers show

Commit Message

Stefan Fröberg Jan. 16, 2013, 4:10 a.m. UTC
proxychains installation does not copy proxychains.conf to 
$(TARGET_DIR)/etc anymore so we have to do it manually now.

Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
---
 package/proxychains-ng/proxychains-ng.mk |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Comments

Peter Korsgaard Jan. 16, 2013, 6:29 a.m. UTC | #1
>>>>> "Stefan" == Stefan Fröberg <stefan.froberg@petroprogram.com> writes:

 Stefan> proxychains installation does not copy proxychains.conf to 
 Stefan> $(TARGET_DIR)/etc anymore so we have to do it manually now.

 Stefan> Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
 Stefan> ---
 Stefan>  package/proxychains-ng/proxychains-ng.mk |    6 ++++++
 Stefan>  1 files changed, 6 insertions(+), 0 deletions(-)

 Stefan> diff --git a/package/proxychains-ng/proxychains-ng.mk b/package/proxychains-ng/proxychains-ng.mk
 Stefan> index 9cf24bf..70d35b6 100644
 Stefan> --- a/package/proxychains-ng/proxychains-ng.mk
 Stefan> +++ b/package/proxychains-ng/proxychains-ng.mk
 Stefan> @@ -7,4 +7,10 @@ PROXYCHAINS_NG_VERSION = 4.4
 Stefan>  PROXYCHAINS_NG_SOURCE = proxychains-$(PROXYCHAINS_NG_VERSION).tar.bz2
 Stefan>  PROXYCHAINS_NG_SITE = http://downloads.sourceforge.net/project/proxychains-ng
 
 Stefan> +define PROXYCHAINS_NG_POST_INSTALL_TARGET
 Stefan> +	$(INSTALL) -m 755 $(@D)/src/proxychains.conf $(TARGET_DIR)/etc

Does the configuration file really need to be executable?

/etc is almost guaranteed to exist, but for consistency please use
install -D . $(TARGET_DIR)/etc/proxychains.conf
Stefan Fröberg Jan. 16, 2013, 11:45 a.m. UTC | #2
16.1.2013 8:29, Peter Korsgaard kirjoitti:
>>>>>> "Stefan" == Stefan Fröberg <stefan.froberg@petroprogram.com> writes:
>  Stefan> proxychains installation does not copy proxychains.conf to 
>  Stefan> $(TARGET_DIR)/etc anymore so we have to do it manually now.
>
>  Stefan> Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
>  Stefan> ---
>  Stefan>  package/proxychains-ng/proxychains-ng.mk |    6 ++++++
>  Stefan>  1 files changed, 6 insertions(+), 0 deletions(-)
>
>  Stefan> diff --git a/package/proxychains-ng/proxychains-ng.mk b/package/proxychains-ng/proxychains-ng.mk
>  Stefan> index 9cf24bf..70d35b6 100644
>  Stefan> --- a/package/proxychains-ng/proxychains-ng.mk
>  Stefan> +++ b/package/proxychains-ng/proxychains-ng.mk
>  Stefan> @@ -7,4 +7,10 @@ PROXYCHAINS_NG_VERSION = 4.4
>  Stefan>  PROXYCHAINS_NG_SOURCE = proxychains-$(PROXYCHAINS_NG_VERSION).tar.bz2
>  Stefan>  PROXYCHAINS_NG_SITE = http://downloads.sourceforge.net/project/proxychains-ng
>  
>  Stefan> +define PROXYCHAINS_NG_POST_INSTALL_TARGET
>  Stefan> +	$(INSTALL) -m 755 $(@D)/src/proxychains.conf $(TARGET_DIR)/etc
>
> Does the configuration file really need to be executable?

Uuups!  sorry

> /etc is almost guaranteed to exist, but for consistency please use
> install -D . $(TARGET_DIR)/etc/proxychains.conf
>
Okay

Fixing and resubmitting

Stefan
diff mbox

Patch

diff --git a/package/proxychains-ng/proxychains-ng.mk b/package/proxychains-ng/proxychains-ng.mk
index 9cf24bf..70d35b6 100644
--- a/package/proxychains-ng/proxychains-ng.mk
+++ b/package/proxychains-ng/proxychains-ng.mk
@@ -7,4 +7,10 @@  PROXYCHAINS_NG_VERSION = 4.4
 PROXYCHAINS_NG_SOURCE = proxychains-$(PROXYCHAINS_NG_VERSION).tar.bz2
 PROXYCHAINS_NG_SITE = http://downloads.sourceforge.net/project/proxychains-ng
 
+define PROXYCHAINS_NG_POST_INSTALL_TARGET
+	$(INSTALL) -m 755 $(@D)/src/proxychains.conf $(TARGET_DIR)/etc
+endef
+
+PROXYCHAINS_NG_POST_INSTALL_TARGET_HOOKS += PROXYCHAINS_NG_POST_INSTALL_TARGET
+
 $(eval $(autotools-package))