| Message ID | 1357803907-18525-2-git-send-email-ajaykumar.rs@samsung.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
Hi Ajay, On Wed, Jan 9, 2013 at 11:45 PM, Ajay Kumar <ajaykumar.rs@samsung.com> wrote: > With this patch, stdout/stderr is assigned to serial and also to LCD. > Initially, u-boot output console is observed via serial port. > If you also have a DP panel connected onto your SMDK5250 board, > you can switch to LCD console by typing "setenv stdout lcd". > You can always switch back to serial using "setenv stdout serial". > You can switch error console(stderr) as well, using similar commands. > > Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> Acked-by: Simon Glass <sjg@chromium.org> This is OK for now. You could perhaps see what Tegra does here - there is code to patch up the stdout value based on settings I think. We probably want CONFIG_CONSOLE_MUX to be always defined, so perhaps think about that for a future patch. > --- > include/configs/exynos5250-dt.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h > index 298bae9..49c0adf 100644 > --- a/include/configs/exynos5250-dt.h > +++ b/include/configs/exynos5250-dt.h > @@ -305,6 +305,12 @@ > #define LCD_XRES 2560 > #define LCD_YRES 1600 > #define LCD_BPP LCD_COLOR16 > + > +/* Override console configuration when LCD is present */ > +#define CONFIG_CONSOLE_MUX > +#define CONFIG_SYS_CONSOLE_IS_IN_ENV > +#define CONFIG_EXTRA_ENV_SETTINGS \ > + "stdout=serial,lcd\0" > #endif > > #endif /* __CONFIG_H */ > -- > 1.8.0 > Regards, Simon
diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h index 298bae9..49c0adf 100644 --- a/include/configs/exynos5250-dt.h +++ b/include/configs/exynos5250-dt.h @@ -305,6 +305,12 @@ #define LCD_XRES 2560 #define LCD_YRES 1600 #define LCD_BPP LCD_COLOR16 + +/* Override console configuration when LCD is present */ +#define CONFIG_CONSOLE_MUX +#define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define CONFIG_EXTRA_ENV_SETTINGS \ + "stdout=serial,lcd\0" #endif #endif /* __CONFIG_H */
With this patch, stdout/stderr is assigned to serial and also to LCD. Initially, u-boot output console is observed via serial port. If you also have a DP panel connected onto your SMDK5250 board, you can switch to LCD console by typing "setenv stdout lcd". You can always switch back to serial using "setenv stdout serial". You can switch error console(stderr) as well, using similar commands. Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> --- include/configs/exynos5250-dt.h | 6 ++++++ 1 file changed, 6 insertions(+)