Message ID | 1357573140-8877-1-git-send-email-agraf@suse.de |
---|---|
State | New |
Headers | show |
Am 07.01.2013 16:38, schrieb Alexander Graf: > Hi Blue / Aurelien, > > This is my current patch queue for ppc. Please pull. Breaks on x86_64: CC ppc-softmmu/hw/ppc/e500.o /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c: In function ‘ppce500_load_device_tree’: /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: implicit declaration of function ‘kvmppc_get_hasidle’ [-Werror=implicit-function-declaration] /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: nested extern declaration of ‘kvmppc_get_hasidle’ [-Werror=nested-externs] cc1: all warnings being treated as errors make[1]: *** [hw/ppc/e500.o] Fehler 1 make: *** [subdir-ppc-softmmu] Fehler 2 Lacking a static inline version of kvmppc_get_hasidle() in kvm_ppc.h. Andreas
On 07.01.2013, at 17:21, Andreas Färber wrote: > Am 07.01.2013 16:38, schrieb Alexander Graf: >> Hi Blue / Aurelien, >> >> This is my current patch queue for ppc. Please pull. > > Breaks on x86_64: > > CC ppc-softmmu/hw/ppc/e500.o > /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c: In function > ‘ppce500_load_device_tree’: > /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: implicit > declaration of function ‘kvmppc_get_hasidle’ > [-Werror=implicit-function-declaration] > /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: nested extern > declaration of ‘kvmppc_get_hasidle’ [-Werror=nested-externs] > cc1: all warnings being treated as errors > make[1]: *** [hw/ppc/e500.o] Fehler 1 > make: *** [subdir-ppc-softmmu] Fehler 2 > > Lacking a static inline version of kvmppc_get_hasidle() in kvm_ppc.h. Sigh. I wonder why our buildbots didn't fetch this one. Fixed it up manually in both ppc-next and ppc-for-upstream, so the pull request is still valid. Alex
On Mon, Jan 07, 2013 at 05:40:24PM +0100, Alexander Graf wrote: > > On 07.01.2013, at 17:21, Andreas Färber wrote: > > > Am 07.01.2013 16:38, schrieb Alexander Graf: > >> Hi Blue / Aurelien, > >> > >> This is my current patch queue for ppc. Please pull. > > > > Breaks on x86_64: > > > > CC ppc-softmmu/hw/ppc/e500.o > > /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c: In function > > ‘ppce500_load_device_tree’: > > /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: implicit > > declaration of function ‘kvmppc_get_hasidle’ > > [-Werror=implicit-function-declaration] > > /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: nested extern > > declaration of ‘kvmppc_get_hasidle’ [-Werror=nested-externs] > > cc1: all warnings being treated as errors > > make[1]: *** [hw/ppc/e500.o] Fehler 1 > > make: *** [subdir-ppc-softmmu] Fehler 2 > > > > Lacking a static inline version of kvmppc_get_hasidle() in kvm_ppc.h. > > Sigh. I wonder why our buildbots didn't fetch this one. > > Fixed it up manually in both ppc-next and ppc-for-upstream, so the pull request is still valid. e500.o is only built when CONFIG_FDT is defined. agraf: "zypper search libfdt" on qemu-ppc.opensuse.org turns up no packages. Any ideas where to get the packages from? Stefan
Am 08.01.2013 um 09:54 schrieb Stefan Hajnoczi <stefanha@redhat.com>: > On Mon, Jan 07, 2013 at 05:40:24PM +0100, Alexander Graf wrote: >> >> On 07.01.2013, at 17:21, Andreas Färber wrote: >> >>> Am 07.01.2013 16:38, schrieb Alexander Graf: >>>> Hi Blue / Aurelien, >>>> >>>> This is my current patch queue for ppc. Please pull. >>> >>> Breaks on x86_64: >>> >>> CC ppc-softmmu/hw/ppc/e500.o >>> /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c: In function >>> ‘ppce500_load_device_tree’: >>> /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: implicit >>> declaration of function ‘kvmppc_get_hasidle’ >>> [-Werror=implicit-function-declaration] >>> /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: nested extern >>> declaration of ‘kvmppc_get_hasidle’ [-Werror=nested-externs] >>> cc1: all warnings being treated as errors >>> make[1]: *** [hw/ppc/e500.o] Fehler 1 >>> make: *** [subdir-ppc-softmmu] Fehler 2 >>> >>> Lacking a static inline version of kvmppc_get_hasidle() in kvm_ppc.h. >> >> Sigh. I wonder why our buildbots didn't fetch this one. >> >> Fixed it up manually in both ppc-next and ppc-for-upstream, so the pull request is still valid. > > e500.o is only built when CONFIG_FDT is defined. > > agraf: "zypper search libfdt" on qemu-ppc.opensuse.org turns up no > packages. Any ideas where to get the packages from? I can install them on the ppc box, but the important build case would be against x86, no? Alex > > Stefan
On 01/08/2013 12:54 AM, Stefan Hajnoczi wrote: > agraf: "zypper search libfdt" on qemu-ppc.opensuse.org turns up no > packages. Any ideas where to get the packages from? Fedora 17 ships them. Either grab the packages from there, or the rpm info points to URL : http://git.jdl.com/gitweb/?p=dtc.git;a=summary as the upstream source. r~
On Mon, Jan 7, 2013 at 4:40 PM, Alexander Graf <agraf@suse.de> wrote: > > On 07.01.2013, at 17:21, Andreas Färber wrote: > >> Am 07.01.2013 16:38, schrieb Alexander Graf: >>> Hi Blue / Aurelien, >>> >>> This is my current patch queue for ppc. Please pull. >> >> Breaks on x86_64: >> >> CC ppc-softmmu/hw/ppc/e500.o >> /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c: In function >> ‘ppce500_load_device_tree’: >> /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: implicit >> declaration of function ‘kvmppc_get_hasidle’ >> [-Werror=implicit-function-declaration] >> /home/andreas/QEMU/qemu-ppc/hw/ppc/e500.c:229:9: error: nested extern >> declaration of ‘kvmppc_get_hasidle’ [-Werror=nested-externs] >> cc1: all warnings being treated as errors >> make[1]: *** [hw/ppc/e500.o] Fehler 1 >> make: *** [subdir-ppc-softmmu] Fehler 2 >> >> Lacking a static inline version of kvmppc_get_hasidle() in kvm_ppc.h. > > Sigh. I wonder why our buildbots didn't fetch this one. > > Fixed it up manually in both ppc-next and ppc-for-upstream, so the pull request is still valid. Thanks, pulled. > > > Alex >