| Message ID | 1356086190-906-2-git-send-email-fabio.porcedda@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On 21 December 2012 10:36, Fabio Porcedda <fabio.porcedda@gmail.com> wrote: > - Use a more descriptive name, the same of the "toolchain" directory. > - Add missing dependencies to be able to successfully use the target > right after the configuration. > - Move to a better position. > - Documentation it in the help target. > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > --- > Makefile | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index 4b09437..458b8c5 100644 > --- a/Makefile > +++ b/Makefile > @@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config > > prepare: $(BUILD_DIR)/buildroot-config/auto.conf > > +toolchain: prepare dirs dependencies $(BASE_TARGETS) > + > world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL) > > -.PHONY: all world dirs clean distclean source outputmakefile \ > +.PHONY: all world toolchain dirs clean distclean source outputmakefile \ > legal-info legal-info-prepare legal-info-clean \ > $(BASE_TARGETS) $(TARGETS) $(TARGETS_ALL) \ > $(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \ > @@ -697,8 +699,6 @@ ifeq ($(O),output) > endif > rm -rf $(CONFIG_DIR)/.config $(CONFIG_DIR)/.config.old $(CONFIG_DIR)/.auto.deps > > -cross: $(BASE_TARGETS) > - > help: > @echo 'Cleaning:' > @echo ' clean - delete all files created by build' > @@ -706,6 +706,7 @@ help: > @echo > @echo 'Build:' > @echo ' all - make world' > + @echo ' toolchain - build toolchain' > @echo ' <package>-rebuild - force recompile <package>' > @echo ' <package>-reconfigure - force reconfigure <package>' > @echo > -- > 1.8.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot This one looks good to me as well Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
On 21/12/12 11:36, Fabio Porcedda wrote: > - Use a more descriptive name, the same of the "toolchain" directory. > - Add missing dependencies to be able to successfully use the target > right after the configuration. > - Move to a better position. > - Documentation it in the help target. > > Signed-off-by: Fabio Porcedda<fabio.porcedda@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (not tested but it's trivial enough) Some additional suggestions (for additional patches): - Document it in the manual. - Add toolchain as a dependency to $(1)-configure for target-packages; this makes it possible to remove it from the dependencies of 'world' and brings us a step closer to top-level parallel build. Regards, Arnout
On Fri, Dec 21, 2012 at 1:42 PM, Arnout Vandecappelle <arnout@mind.be> wrote: > On 21/12/12 11:36, Fabio Porcedda wrote: >> >> - Use a more descriptive name, the same of the "toolchain" directory. >> - Add missing dependencies to be able to successfully use the target >> right after the configuration. >> - Move to a better position. >> - Documentation it in the help target. >> >> Signed-off-by: Fabio Porcedda<fabio.porcedda@gmail.com> > > > Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > (not tested but it's trivial enough) > > Some additional suggestions (for additional patches): > > - Document it in the manual. > > - Add toolchain as a dependency to $(1)-configure for target-packages; > this makes it possible to remove it from the dependencies of 'world' and > brings us a step closer to top-level parallel build. Thank for the review. I like your suggestions. I will work on that for additional patches. Best regards -- Fabio Porcedda
Hi Fabio, 2012/12/21 Fabio Porcedda <fabio.porcedda@gmail.com>: > - Use a more descriptive name, the same of the "toolchain" directory. > - Add missing dependencies to be able to successfully use the target > right after the configuration. > - Move to a better position. > - Documentation it in the help target. > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > --- > Makefile | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index 4b09437..458b8c5 100644 > --- a/Makefile > +++ b/Makefile > @@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config > > prepare: $(BUILD_DIR)/buildroot-config/auto.conf > > +toolchain: prepare dirs dependencies $(BASE_TARGETS) > + > world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL) Any reason to not make the world target depend on the toolchain and $(TARGETS_ALL) targets? IOW: world: toolchain $(TARGETS_ALL) Otherwise, it looks good to me with few words in the manual as already mentioned by Arnout. Regards,
On Sat, Dec 22, 2012 at 1:45 PM, Samuel Martin <s.martin49@gmail.com> wrote: > Hi Fabio, > > 2012/12/21 Fabio Porcedda <fabio.porcedda@gmail.com>: >> - Use a more descriptive name, the same of the "toolchain" directory. >> - Add missing dependencies to be able to successfully use the target >> right after the configuration. >> - Move to a better position. >> - Documentation it in the help target. >> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> >> --- >> Makefile | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 4b09437..458b8c5 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config >> >> prepare: $(BUILD_DIR)/buildroot-config/auto.conf >> >> +toolchain: prepare dirs dependencies $(BASE_TARGETS) >> + >> world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL) > Any reason to not make the world target depend on the toolchain and > $(TARGETS_ALL) targets? > IOW: > world: toolchain $(TARGETS_ALL) I've done exactly that in the following patch 2/2 > Otherwise, it looks good to me with few words in the manual as already > mentioned by Arnout. Thanks for the review Best regards -- Fabio Porcedda
diff --git a/Makefile b/Makefile index 4b09437..458b8c5 100644 --- a/Makefile +++ b/Makefile @@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config prepare: $(BUILD_DIR)/buildroot-config/auto.conf +toolchain: prepare dirs dependencies $(BASE_TARGETS) + world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL) -.PHONY: all world dirs clean distclean source outputmakefile \ +.PHONY: all world toolchain dirs clean distclean source outputmakefile \ legal-info legal-info-prepare legal-info-clean \ $(BASE_TARGETS) $(TARGETS) $(TARGETS_ALL) \ $(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \ @@ -697,8 +699,6 @@ ifeq ($(O),output) endif rm -rf $(CONFIG_DIR)/.config $(CONFIG_DIR)/.config.old $(CONFIG_DIR)/.auto.deps -cross: $(BASE_TARGETS) - help: @echo 'Cleaning:' @echo ' clean - delete all files created by build' @@ -706,6 +706,7 @@ help: @echo @echo 'Build:' @echo ' all - make world' + @echo ' toolchain - build toolchain' @echo ' <package>-rebuild - force recompile <package>' @echo ' <package>-reconfigure - force reconfigure <package>' @echo
- Use a more descriptive name, the same of the "toolchain" directory. - Add missing dependencies to be able to successfully use the target right after the configuration. - Move to a better position. - Documentation it in the help target. Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> --- Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)