Message ID | 20121217164217.GF10671@lug-owl.de |
---|---|
State | New |
Headers | show |
On 12/17/2012 11:42 AM, Jan-Benedict Glaw wrote: > 2012-12-17 Jan-Benedict Glaw <jbglaw@lug-owl.de> > > * gcc/varasm.c (pending_assemble_externals_processed): Guard > with ASM_OUTPUT_EXTERNAL. This was fixed on trunk yesterday. The warning must be present on 4.6 and 4.7 but doesn't cause a build error. Thanks, Dave
On Mon, 2012-12-17 12:08:11 -0500, John David Anglin <dave.anglin@bell.net> wrote: > On 12/17/2012 11:42 AM, Jan-Benedict Glaw wrote: > >2012-12-17 Jan-Benedict Glaw <jbglaw@lug-owl.de> > > > > * gcc/varasm.c (pending_assemble_externals_processed): Guard > > with ASM_OUTPUT_EXTERNAL. > This was fixed on trunk yesterday. The warning must be present on Great. Takes a day until I'm up with my build robot... Thanks, JBG
On 12/17/2012 12:08 PM, John David Anglin wrote: > On 12/17/2012 11:42 AM, Jan-Benedict Glaw wrote: >> 2012-12-17 Jan-Benedict Glaw <jbglaw@lug-owl.de> >> >> * gcc/varasm.c (pending_assemble_externals_processed): Guard >> with ASM_OUTPUT_EXTERNAL. > This was fixed on trunk yesterday. The warning must be present on 4.6 > and 4.7 > but doesn't cause a build error. > Sorry, I thought Dominique Dhumieres fixed this but I see he didn't apply his change. I would say your change is obviously ok. Dave
On Mon, 2012-12-17 12:24:58 -0500, John David Anglin <dave.anglin@bell.net> wrote: > On 12/17/2012 12:08 PM, John David Anglin wrote: > > On 12/17/2012 11:42 AM, Jan-Benedict Glaw wrote: > > > 2012-12-17 Jan-Benedict Glaw <jbglaw@lug-owl.de> > > > > > > * gcc/varasm.c (pending_assemble_externals_processed): Guard > > > with ASM_OUTPUT_EXTERNAL. > > This was fixed on trunk yesterday. The warning must be present on > > 4.6 and 4.7 > > but doesn't cause a build error. > > Sorry, I thought Dominique Dhumieres fixed this but I see he didn't > apply his change. > I would say your change is obviously ok. Will commit. MfG, JBG
diff --git a/gcc/varasm.c b/gcc/varasm.c index daeb6e2..53ebfbf 100644 --- a/gcc/varasm.c +++ b/gcc/varasm.c @@ -2088,12 +2088,12 @@ contains_pointers_p (tree type) it all the way to final. See PR 17982 for further discussion. */ static GTY(()) tree pending_assemble_externals; +#ifdef ASM_OUTPUT_EXTERNAL /* Some targets delay some output to final using TARGET_ASM_FILE_END. As a result, assemble_external can be called after the list of externals is processed and the pointer set destroyed. */ static bool pending_assemble_externals_processed; -#ifdef ASM_OUTPUT_EXTERNAL /* Avoid O(external_decls**2) lookups in the pending_assemble_externals TREE_LIST in assemble_external. */ static struct pointer_set_t *pending_assemble_externals_set;