| Message ID | 1355482413-18629-1-git-send-email-florent.fourcot@enst-bretagne.fr |
|---|---|
| State | Accepted |
| Headers | show |
On 12/14/2012 02:53 AM, Florent Fourcot wrote: > Remove ambiguity of double negation > > Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr> > --- > net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c > index 00ee17c..137e245 100644 > --- a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c > +++ b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c > @@ -81,8 +81,8 @@ static int ipv6_get_l4proto(const struct sk_buff *skb, unsigned int nhoff, > } > protoff = ipv6_skip_exthdr(skb, extoff, &nexthdr, &frag_off); > /* > - * (protoff == skb->len) mean that the packet doesn't have no data > - * except of IPv6 & ext headers. but it's tracked anyway. - YK > + * (protoff == skb->len) means the packet has not data, just > + * IPv6 and possibly extensions headers, but it is tracked anyway > */ > if (protoff < 0 || (frag_off & htons(~0x7)) != 0) { > pr_debug("ip6_conntrack_core: can't find proto in pkt\n"); > Acked-by: Rick Jones <rick.jones2@hp.com> rick -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 14, 2012 at 01:28:54PM -0800, Rick Jones wrote: > On 12/14/2012 02:53 AM, Florent Fourcot wrote: > >Remove ambiguity of double negation > > > >Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr> > >--- > > net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c > >index 00ee17c..137e245 100644 > >--- a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c > >+++ b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c > >@@ -81,8 +81,8 @@ static int ipv6_get_l4proto(const struct sk_buff *skb, unsigned int nhoff, > > } > > protoff = ipv6_skip_exthdr(skb, extoff, &nexthdr, &frag_off); > > /* > >- * (protoff == skb->len) mean that the packet doesn't have no data > >- * except of IPv6 & ext headers. but it's tracked anyway. - YK > >+ * (protoff == skb->len) means the packet has not data, just > >+ * IPv6 and possibly extensions headers, but it is tracked anyway > > */ > > if (protoff < 0 || (frag_off & htons(~0x7)) != 0) { > > pr_debug("ip6_conntrack_core: can't find proto in pkt\n"); > > > > Acked-by: Rick Jones <rick.jones2@hp.com> Applied, thanks. That was many discussion for a patch to fix a comment, nice indeed :-) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c index 00ee17c..137e245 100644 --- a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c +++ b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c @@ -81,8 +81,8 @@ static int ipv6_get_l4proto(const struct sk_buff *skb, unsigned int nhoff, } protoff = ipv6_skip_exthdr(skb, extoff, &nexthdr, &frag_off); /* - * (protoff == skb->len) mean that the packet doesn't have no data - * except of IPv6 & ext headers. but it's tracked anyway. - YK + * (protoff == skb->len) means the packet has not data, just + * IPv6 and possibly extensions headers, but it is tracked anyway */ if (protoff < 0 || (frag_off & htons(~0x7)) != 0) { pr_debug("ip6_conntrack_core: can't find proto in pkt\n");
Remove ambiguity of double negation Signed-off-by: Florent Fourcot <florent.fourcot@enst-bretagne.fr> --- net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)