| Message ID | 50C57E3D.9010708@barfooze.de |
|---|---|
| State | New |
| Headers | show |
Am 10.12.2012 07:16, schrieb John Spencer:
Your patch is not shown here because you had attached it to your email.
Please use "git send-email" to send patches.See also
http://wiki.qemu.org/Contribute/SubmitAPatch.
In your patch, you replaced a wrong forward declarationof function setgroups
by an include statement using grp.h. That's fine.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
There are more extern declarations in linux-user/syscall.c.
Even if they are correct, they should be replaced by include statements.
If there will be a v2 of your patch series, you could add patches
for those declarations, too.
Regards
Stefan Weil
On 12/10/2012 07:37 AM, Stefan Weil wrote: > Am 10.12.2012 07:16, schrieb John Spencer: > > Your patch is not shown here because you had attached it to your email. > Please use "git send-email" to send patches.See also > http://wiki.qemu.org/Contribute/SubmitAPatch. thanks, resent with git send-email. i hope it is ok now. > > In your patch, you replaced a wrong forward declarationof function > setgroups > by an include statement using grp.h. That's fine. > > Reviewed-by: Stefan Weil <sw@weilnetz.de> > > There are more extern declarations in linux-user/syscall.c. > Even if they are correct, they should be replaced by include statements. > If there will be a v2 of your patch series, you could add patches > for those declarations, too. ok, will do separately after this first batch is merged. Regards, John Spencer
From 3d9bc5e06ae64806003f8999b4b7ead42bd19c5d Mon Sep 17 00:00:00 2001 From: John Spencer <maillist-qemu@barfooze.de> Date: Mon, 10 Dec 2012 07:02:49 +0100 Subject: [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix is to simply include the correct header. Signed-off-by: John Spencer <maillist-qemu@barfooze.de> --- linux-user/syscall.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index fabbcd7..665316e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -28,6 +28,7 @@ #include <fcntl.h> #include <time.h> #include <limits.h> +#include <grp.h> #include <sys/types.h> #include <sys/ipc.h> #include <sys/msg.h> @@ -585,7 +586,6 @@ extern int personality(int); extern int flock(int, int); extern int setfsuid(int); extern int setfsgid(int); -extern int setgroups(int, gid_t *); /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */ #ifdef TARGET_ARM -- 1.7.3.4