| Message ID | 1354896456-21120-4-git-send-email-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 07.12.2012, at 17:07, Eduardo Habkost wrote: > There's no point in using void* if all functions dealing with that data > use FWCfgState*. Acked-by: Alexander Graf <agraf@suse.de> Alex > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > Cc: Alexander Graf <agraf@suse.de> > --- > hw/ppc_newworld.c | 2 +- > hw/ppc_oldworld.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c > index 664747e..426ea51 100644 > --- a/hw/ppc_newworld.c > +++ b/hw/ppc_newworld.c > @@ -153,7 +153,7 @@ static void ppc_core99_init(QEMUMachineInitArgs *args) > MemoryRegion *ide_mem[3]; > int ppc_boot_device; > DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; > - void *fw_cfg; > + FWCfgState *fw_cfg; > void *dbdma; > int machine_arch; > > diff --git a/hw/ppc_oldworld.c b/hw/ppc_oldworld.c > index e8138c0..9855dcd 100644 > --- a/hw/ppc_oldworld.c > +++ b/hw/ppc_oldworld.c > @@ -96,7 +96,7 @@ static void ppc_heathrow_init(QEMUMachineInitArgs *args) > MemoryRegion *escc_mem, *escc_bar = g_new(MemoryRegion, 1), *ide_mem[2]; > uint16_t ppc_boot_device; > DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; > - void *fw_cfg; > + FWCfgState *fw_cfg; > void *dbdma; > > linux_boot = (kernel_filename != NULL); > -- > 1.7.11.7 >
diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c index 664747e..426ea51 100644 --- a/hw/ppc_newworld.c +++ b/hw/ppc_newworld.c @@ -153,7 +153,7 @@ static void ppc_core99_init(QEMUMachineInitArgs *args) MemoryRegion *ide_mem[3]; int ppc_boot_device; DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - void *fw_cfg; + FWCfgState *fw_cfg; void *dbdma; int machine_arch; diff --git a/hw/ppc_oldworld.c b/hw/ppc_oldworld.c index e8138c0..9855dcd 100644 --- a/hw/ppc_oldworld.c +++ b/hw/ppc_oldworld.c @@ -96,7 +96,7 @@ static void ppc_heathrow_init(QEMUMachineInitArgs *args) MemoryRegion *escc_mem, *escc_bar = g_new(MemoryRegion, 1), *ide_mem[2]; uint16_t ppc_boot_device; DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - void *fw_cfg; + FWCfgState *fw_cfg; void *dbdma; linux_boot = (kernel_filename != NULL);
There's no point in using void* if all functions dealing with that data use FWCfgState*. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Cc: Alexander Graf <agraf@suse.de> --- hw/ppc_newworld.c | 2 +- hw/ppc_oldworld.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)