Message ID | 1354759444-4937-1-git-send-email-amwang@redhat.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Cong Wang said, at 2012/12/6 10:04: > From: Cong Wang <amwang@redhat.com> > > net/core/neighbour.c:65:12: warning: 'zero' defined but not used [-Wunused-variable] > net/core/neighbour.c:66:12: warning: 'unres_qlen_max' defined but not used [-Wunused-variable] > > These variables are only used when CONFIG_SYSCTL is defined, > so move them under #ifdef CONFIG_SYSCTL. > > Reported-by: Fengguang Wu <fengguang.wu@intel.com> > Cc: Shan Wei <davidshan@tencent.com> > Cc: David S. Miller <davem@davemloft.net> > Signed-off-by: Cong Wang <amwang@redhat.com> Rapid response~~~ :-) Same patch in my tree,and i see your patch when prepare to submit it. Acked-by: Shan Wei <davidshan@tencent.com> Best Regards Shan Wei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Shan Wei <shanwei88@gmail.com> Date: Thu, 06 Dec 2012 10:39:00 +0800 > Cong Wang said, at 2012/12/6 10:04: >> From: Cong Wang <amwang@redhat.com> >> >> net/core/neighbour.c:65:12: warning: 'zero' defined but not used [-Wunused-variable] >> net/core/neighbour.c:66:12: warning: 'unres_qlen_max' defined but not used [-Wunused-variable] >> >> These variables are only used when CONFIG_SYSCTL is defined, >> so move them under #ifdef CONFIG_SYSCTL. >> >> Reported-by: Fengguang Wu <fengguang.wu@intel.com> >> Cc: Shan Wei <davidshan@tencent.com> >> Cc: David S. Miller <davem@davemloft.net> >> Signed-off-by: Cong Wang <amwang@redhat.com> > > Rapid response~~~ :-) > Same patch in my tree,and i see your patch when prepare to submit it. > > Acked-by: Shan Wei <davidshan@tencent.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 36fc692..c815f28 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -62,9 +62,6 @@ static void __neigh_notify(struct neighbour *n, int type, int flags); static void neigh_update_notify(struct neighbour *neigh); static int pneigh_ifdown(struct neigh_table *tbl, struct net_device *dev); -static int zero; -static int unres_qlen_max = INT_MAX / SKB_TRUESIZE(ETH_FRAME_LEN); - static struct neigh_table *neigh_tables; #ifdef CONFIG_PROC_FS static const struct file_operations neigh_stat_seq_fops; @@ -2772,6 +2769,8 @@ EXPORT_SYMBOL(neigh_app_ns); #endif /* CONFIG_ARPD */ #ifdef CONFIG_SYSCTL +static int zero; +static int unres_qlen_max = INT_MAX / SKB_TRUESIZE(ETH_FRAME_LEN); static int proc_unres_qlen(ctl_table *ctl, int write, void __user *buffer, size_t *lenp, loff_t *ppos)