| Message ID | 1354257706-6582-4-git-send-email-yan@linux.vnet.ibm.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, 30 Nov 2012, Guo Chao wrote: > Date: Fri, 30 Nov 2012 14:41:46 +0800 > From: Guo Chao <yan@linux.vnet.ibm.com> > To: tytso@mit.edu > Cc: linux-ext4@vger.kernel.org > Subject: [PATCH 4/4] ext4: remove redundant initialization in > ext4_fill_super() > > We use kzalloc() to allocate sbi, no need to zero its field. > > Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com> > --- > fs/ext4/super.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index 15d28e3..a99f6c7 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -3799,7 +3799,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) > > INIT_LIST_HEAD(&sbi->s_orphan); /* unlinked but open files */ > mutex_init(&sbi->s_orphan_lock); > - sbi->s_resize_flags = 0; > > sb->s_root = NULL; > > There are other members of sbi which we initialize to zero even though we use kzalloc. Thanks! -Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 30, 2012 at 02:41:46PM +0800, Guo Chao wrote: > We use kzalloc() to allocate sbi, no need to zero its field. > > Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 15d28e3..a99f6c7 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3799,7 +3799,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) INIT_LIST_HEAD(&sbi->s_orphan); /* unlinked but open files */ mutex_init(&sbi->s_orphan_lock); - sbi->s_resize_flags = 0; sb->s_root = NULL;
We use kzalloc() to allocate sbi, no need to zero its field. Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com> --- fs/ext4/super.c | 1 - 1 file changed, 1 deletion(-)