| Message ID | 1354257706-6582-3-git-send-email-yan@linux.vnet.ibm.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, 30 Nov 2012, Guo Chao wrote: > Date: Fri, 30 Nov 2012 14:41:45 +0800 > From: Guo Chao <yan@linux.vnet.ibm.com> > To: tytso@mit.edu > Cc: linux-ext4@vger.kernel.org > Subject: [PATCH 3/4] ext4: remove redundant code in ext4_alloc_inode() > > inode_init_always() will initialize inode->i_data.writeback_index > anyway, no need to do this in ext4_alloc_inode(). > > Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com> > --- > fs/ext4/super.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index 66a4e20..15d28e3 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -940,7 +940,6 @@ static struct inode *ext4_alloc_inode(struct super_block *sb) > return NULL; > > ei->vfs_inode.i_version = 1; > - ei->vfs_inode.i_data.writeback_index = 0; > memset(&ei->i_cached_extent, 0, sizeof(struct ext4_ext_cache)); > INIT_LIST_HEAD(&ei->i_prealloc_list); > spin_lock_init(&ei->i_prealloc_lock); > Looks good Reviewed-by: Lukas Czerner <lczerner@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 30, 2012 at 02:41:45PM +0800, Guo Chao wrote: > inode_init_always() will initialize inode->i_data.writeback_index > anyway, no need to do this in ext4_alloc_inode(). > > Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 66a4e20..15d28e3 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -940,7 +940,6 @@ static struct inode *ext4_alloc_inode(struct super_block *sb) return NULL; ei->vfs_inode.i_version = 1; - ei->vfs_inode.i_data.writeback_index = 0; memset(&ei->i_cached_extent, 0, sizeof(struct ext4_ext_cache)); INIT_LIST_HEAD(&ei->i_prealloc_list); spin_lock_init(&ei->i_prealloc_lock);
inode_init_always() will initialize inode->i_data.writeback_index anyway, no need to do this in ext4_alloc_inode(). Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com> --- fs/ext4/super.c | 1 - 1 file changed, 1 deletion(-)