Message ID | 1353559723-2367-1-git-send-email-herton.krzesinski@canonical.com |
---|---|
State | New |
Headers | show |
Hi On Thu, Nov 22, 2012 at 5:48 AM, Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com> wrote: > This is a note to let you know that I have just added a patch titled > > rt2x00: usb: fix reset resume > > to the linux-3.5.y-queue branch of the 3.5.yuz extended stable tree > which can be found at: > > http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue > > If you, or anyone else, feels it should not be added to this tree, please > reply to this email. I think this shouldn't be applied to kernels prior to 3.7. Quoting Stanislaw: > NAK, this patch cause random crashes on 3.6 (reproducible on 3.6, > not reproducible on 3.7 - seems on 3.7 there are some changes, that > prevent the crashes). > > Greg, please remove it from 3.6 stable queue Maybe Stanislaw can comment whether this also applies to 3.5 kernels? Regards David
On Sat, Nov 24, 2012 at 05:11:38PM +0100, David Herrmann wrote: > I think this shouldn't be applied to kernels prior to 3.7. Quoting Stanislaw: > > > NAK, this patch cause random crashes on 3.6 (reproducible on 3.6, > > not reproducible on 3.7 - seems on 3.7 there are some changes, that > > prevent the crashes). > > > > Greg, please remove it from 3.6 stable queue > > Maybe Stanislaw can comment whether this also applies to 3.5 kernels? It should not be applied, good catch. Stanislaw
On Sun, Nov 25, 2012 at 08:53:05PM +0100, Stanislaw Gruszka wrote: > On Sat, Nov 24, 2012 at 05:11:38PM +0100, David Herrmann wrote: > > I think this shouldn't be applied to kernels prior to 3.7. Quoting Stanislaw: > > > > > NAK, this patch cause random crashes on 3.6 (reproducible on 3.6, > > > not reproducible on 3.7 - seems on 3.7 there are some changes, that > > > prevent the crashes). > > > > > > Greg, please remove it from 3.6 stable queue > > > > Maybe Stanislaw can comment whether this also applies to 3.5 kernels? > > It should not be applied, good catch. > > Stanislaw > Indeed, thanks for the report. It's removed now from the queue.
diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c index d6e87c0..9356cda 100644 --- a/drivers/net/wireless/rt2x00/rt2500usb.c +++ b/drivers/net/wireless/rt2x00/rt2500usb.c @@ -1989,6 +1989,7 @@ static struct usb_driver rt2500usb_driver = { .disconnect = rt2x00usb_disconnect, .suspend = rt2x00usb_suspend, .resume = rt2x00usb_resume, + .reset_resume = rt2x00usb_resume, .disable_hub_initiated_lpm = 1, }; diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c index 6b4226b..2140005 100644 --- a/drivers/net/wireless/rt2x00/rt2800usb.c +++ b/drivers/net/wireless/rt2x00/rt2800usb.c @@ -1322,6 +1322,7 @@ static struct usb_driver rt2800usb_driver = { .disconnect = rt2x00usb_disconnect, .suspend = rt2x00usb_suspend, .resume = rt2x00usb_resume, + .reset_resume = rt2x00usb_resume, .disable_hub_initiated_lpm = 1, }; diff --git a/drivers/net/wireless/rt2x00/rt73usb.c b/drivers/net/wireless/rt2x00/rt73usb.c index ceb1c4f..d5ec04a 100644 --- a/drivers/net/wireless/rt2x00/rt73usb.c +++ b/drivers/net/wireless/rt2x00/rt73usb.c @@ -2536,6 +2536,7 @@ static struct usb_driver rt73usb_driver = { .disconnect = rt2x00usb_disconnect, .suspend = rt2x00usb_suspend, .resume = rt2x00usb_resume, + .reset_resume = rt2x00usb_resume, .disable_hub_initiated_lpm = 1, };