Message ID | e3a70a1ead77b829c3c8ce406ed45561c4715874.1353421334.git.amit.shah@redhat.com |
---|---|
State | New |
Headers | show |
Amit Shah <amit.shah@redhat.com> writes: > Fix typos, whitespace and update comments to match current > implementation. > > Signed-off-by: Amit Shah <amit.shah@redhat.com> > --- > hw/virtio-rng.c | 7 +++---- > include/qemu/rng.h | 6 +++--- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c > index c8a6da7..f4ed9cf 100644 > --- a/hw/virtio-rng.c > +++ b/hw/virtio-rng.c > @@ -23,7 +23,6 @@ typedef struct VirtIORNG { > /* Only one vq - guest puts buffer(s) on it when it needs entropy */ > VirtQueue *vq; > > - /* Config data for the device -- currently only chardev */ > VirtIORNGConf *conf; > > RngBackend *rng; > @@ -125,9 +124,9 @@ static int virtio_rng_load(QEMUFile *f, void *opaque, int version_id) > virtio_load(&vrng->vdev, f); > > /* We may have an element ready but couldn't process it due to a quota > - limit. Make sure to try again after live migration when the quota may > - have been reset. > - */ > + * limit. Make sure to try again after live migration when the quota may > + * have been reset. > + */ > virtio_rng_process(vrng); > > return 0; > diff --git a/include/qemu/rng.h b/include/qemu/rng.h > index 7e9d672..9836463 100644 > --- a/include/qemu/rng.h > +++ b/include/qemu/rng.h > @@ -61,10 +61,10 @@ struct RngBackend > * This function is used by the front-end to request entropy from an entropy > * source. This function can be called multiple times before @receive_entropy > * is invoked with different values of @receive_entropy and @opaque. The > - * backend will queue each request and handle appropriate. > + * backend will queue each request and handle appropriately. > * > * The backend does not need to pass the full amount of data to @receive_entropy > - * but will pass at a value greater than 0. > + * but will pass a a value greater than 0. Your typo fix has a typo. Regards, Anthony Liguori > */ > void rng_backend_request_entropy(RngBackend *s, size_t size, > EntropyReceiveFunc *receive_entropy, > @@ -87,7 +87,7 @@ void rng_backend_cancel_requests(RngBackend *s); > * > * This function will open the backend if it is not already open. Calling this > * function on an already opened backend will not result in an error. > - */ > + */ > void rng_backend_open(RngBackend *s, Error **errp); > > #endif > -- > 1.8.0
On (Tue) 20 Nov 2012 [19:43:16], Anthony Liguori wrote: > > * The backend does not need to pass the full amount of data to @receive_entropy > > - * but will pass at a value greater than 0. > > + * but will pass a a value greater than 0. > > Your typo fix has a typo. Woops, series re-sent. Amit
diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c index c8a6da7..f4ed9cf 100644 --- a/hw/virtio-rng.c +++ b/hw/virtio-rng.c @@ -23,7 +23,6 @@ typedef struct VirtIORNG { /* Only one vq - guest puts buffer(s) on it when it needs entropy */ VirtQueue *vq; - /* Config data for the device -- currently only chardev */ VirtIORNGConf *conf; RngBackend *rng; @@ -125,9 +124,9 @@ static int virtio_rng_load(QEMUFile *f, void *opaque, int version_id) virtio_load(&vrng->vdev, f); /* We may have an element ready but couldn't process it due to a quota - limit. Make sure to try again after live migration when the quota may - have been reset. - */ + * limit. Make sure to try again after live migration when the quota may + * have been reset. + */ virtio_rng_process(vrng); return 0; diff --git a/include/qemu/rng.h b/include/qemu/rng.h index 7e9d672..9836463 100644 --- a/include/qemu/rng.h +++ b/include/qemu/rng.h @@ -61,10 +61,10 @@ struct RngBackend * This function is used by the front-end to request entropy from an entropy * source. This function can be called multiple times before @receive_entropy * is invoked with different values of @receive_entropy and @opaque. The - * backend will queue each request and handle appropriate. + * backend will queue each request and handle appropriately. * * The backend does not need to pass the full amount of data to @receive_entropy - * but will pass at a value greater than 0. + * but will pass a a value greater than 0. */ void rng_backend_request_entropy(RngBackend *s, size_t size, EntropyReceiveFunc *receive_entropy, @@ -87,7 +87,7 @@ void rng_backend_cancel_requests(RngBackend *s); * * This function will open the backend if it is not already open. Calling this * function on an already opened backend will not result in an error. - */ + */ void rng_backend_open(RngBackend *s, Error **errp); #endif
Fix typos, whitespace and update comments to match current implementation. Signed-off-by: Amit Shah <amit.shah@redhat.com> --- hw/virtio-rng.c | 7 +++---- include/qemu/rng.h | 6 +++--- 2 files changed, 6 insertions(+), 7 deletions(-)