| Message ID | 1353076764.3647.35.camel@mars |
|---|---|
| State | New |
| Headers | show |
On Fri, Nov 16, 2012 at 03:39:24PM +0100, Christoph Fritz wrote: > This patch sets HPM (Host power mask bit) to bit 16 according to i.MX > Reference Manual. Falsely it was set to bit 8, but this controls pull-up > Impedance. > > Reported-by: Michael Burkey <mdburkey@gmail.com> > Cc: Stable <stable@vger.kernel.org> > Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com> > Acked-by: Eric Bénard <eric@eukrea.com> Applied, thanks Sascha > --- > arch/arm/mach-imx/ehci-imx25.c | 2 +- > arch/arm/mach-imx/ehci-imx35.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-imx/ehci-imx25.c b/arch/arm/mach-imx/ehci-imx25.c > index 27e40d1..134c190 100644 > --- a/arch/arm/mach-imx/ehci-imx25.c > +++ b/arch/arm/mach-imx/ehci-imx25.c > @@ -30,7 +30,7 @@ > #define MX25_H1_SIC_SHIFT 21 > #define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT) > #define MX25_H1_PP_BIT (1 << 18) > -#define MX25_H1_PM_BIT (1 << 8) > +#define MX25_H1_PM_BIT (1 << 16) > #define MX25_H1_IPPUE_UP_BIT (1 << 7) > #define MX25_H1_IPPUE_DOWN_BIT (1 << 6) > #define MX25_H1_TLL_BIT (1 << 5) > diff --git a/arch/arm/mach-imx/ehci-imx35.c b/arch/arm/mach-imx/ehci-imx35.c > index a596f70..554e7cc 100644 > --- a/arch/arm/mach-imx/ehci-imx35.c > +++ b/arch/arm/mach-imx/ehci-imx35.c > @@ -30,7 +30,7 @@ > #define MX35_H1_SIC_SHIFT 21 > #define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT) > #define MX35_H1_PP_BIT (1 << 18) > -#define MX35_H1_PM_BIT (1 << 8) > +#define MX35_H1_PM_BIT (1 << 16) > #define MX35_H1_IPPUE_UP_BIT (1 << 7) > #define MX35_H1_IPPUE_DOWN_BIT (1 << 6) > #define MX35_H1_TLL_BIT (1 << 5) > -- > 1.7.10.4 > > > >
Great! Also, be aware that this bug/fix needs to be applied to both the Linux kernel and to BareBox as well. Thanks, Michael Burkey ----- Original Message ----- From: "Sascha Hauer" <s.hauer@pengutronix.de> To: "Christoph Fritz" <chf.fritz@googlemail.com> Cc: "Eric Bénard" <eric@eukrea.com>; "Sascha Hauer" <kernel@pengutronix.de>; "Fabio Estevam" <fabio.estevam@freescale.com>; "Michael Burkey" <mdburkey@gmail.com>; "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>; "Stable" <stable@vger.kernel.org>; "Hans J. Koch" <hjk@hansjkoch.de>; "Daniel Mack" <daniel@caiaq.de>; "Christian Hemp" <c.hemp@phytec.de>; <linux-arm-kernel@lists.infradead.org> Sent: Friday, November 16, 2012 9:55 AM Subject: Re: [PATCH] ARM: imx: ehci: fix host power mask bit > On Fri, Nov 16, 2012 at 03:39:24PM +0100, Christoph Fritz wrote: >> This patch sets HPM (Host power mask bit) to bit 16 according to i.MX >> Reference Manual. Falsely it was set to bit 8, but this controls pull-up >> Impedance. >> >> Reported-by: Michael Burkey <mdburkey@gmail.com> >> Cc: Stable <stable@vger.kernel.org> >> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com> >> Acked-by: Eric Bénard <eric@eukrea.com> > > Applied, thanks > > Sascha > >> --- >> arch/arm/mach-imx/ehci-imx25.c | 2 +- >> arch/arm/mach-imx/ehci-imx35.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-imx/ehci-imx25.c >> b/arch/arm/mach-imx/ehci-imx25.c >> index 27e40d1..134c190 100644 >> --- a/arch/arm/mach-imx/ehci-imx25.c >> +++ b/arch/arm/mach-imx/ehci-imx25.c >> @@ -30,7 +30,7 @@ >> #define MX25_H1_SIC_SHIFT 21 >> #define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT) >> #define MX25_H1_PP_BIT (1 << 18) >> -#define MX25_H1_PM_BIT (1 << 8) >> +#define MX25_H1_PM_BIT (1 << 16) >> #define MX25_H1_IPPUE_UP_BIT (1 << 7) >> #define MX25_H1_IPPUE_DOWN_BIT (1 << 6) >> #define MX25_H1_TLL_BIT (1 << 5) >> diff --git a/arch/arm/mach-imx/ehci-imx35.c >> b/arch/arm/mach-imx/ehci-imx35.c >> index a596f70..554e7cc 100644 >> --- a/arch/arm/mach-imx/ehci-imx35.c >> +++ b/arch/arm/mach-imx/ehci-imx35.c >> @@ -30,7 +30,7 @@ >> #define MX35_H1_SIC_SHIFT 21 >> #define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT) >> #define MX35_H1_PP_BIT (1 << 18) >> -#define MX35_H1_PM_BIT (1 << 8) >> +#define MX35_H1_PM_BIT (1 << 16) >> #define MX35_H1_IPPUE_UP_BIT (1 << 7) >> #define MX35_H1_IPPUE_DOWN_BIT (1 << 6) >> #define MX35_H1_TLL_BIT (1 << 5) >> -- >> 1.7.10.4 >> >> >> >> > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
diff --git a/arch/arm/mach-imx/ehci-imx25.c b/arch/arm/mach-imx/ehci-imx25.c index 27e40d1..134c190 100644 --- a/arch/arm/mach-imx/ehci-imx25.c +++ b/arch/arm/mach-imx/ehci-imx25.c @@ -30,7 +30,7 @@ #define MX25_H1_SIC_SHIFT 21 #define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT) #define MX25_H1_PP_BIT (1 << 18) -#define MX25_H1_PM_BIT (1 << 8) +#define MX25_H1_PM_BIT (1 << 16) #define MX25_H1_IPPUE_UP_BIT (1 << 7) #define MX25_H1_IPPUE_DOWN_BIT (1 << 6) #define MX25_H1_TLL_BIT (1 << 5) diff --git a/arch/arm/mach-imx/ehci-imx35.c b/arch/arm/mach-imx/ehci-imx35.c index a596f70..554e7cc 100644 --- a/arch/arm/mach-imx/ehci-imx35.c +++ b/arch/arm/mach-imx/ehci-imx35.c @@ -30,7 +30,7 @@ #define MX35_H1_SIC_SHIFT 21 #define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT) #define MX35_H1_PP_BIT (1 << 18) -#define MX35_H1_PM_BIT (1 << 8) +#define MX35_H1_PM_BIT (1 << 16) #define MX35_H1_IPPUE_UP_BIT (1 << 7) #define MX35_H1_IPPUE_DOWN_BIT (1 << 6) #define MX35_H1_TLL_BIT (1 << 5)