| Message ID | 1353014604-26493-2-git-send-email-festevam@gmail.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
Am 15.11.2012 22:23, schrieb Fabio Estevam: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Print CSPI clock in 'clock' command. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- > arch/arm/cpu/armv7/mx5/clock.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/cpu/armv7/mx5/clock.c b/arch/arm/cpu/armv7/mx5/clock.c > index 1c9223f..76c2c52 100644 > --- a/arch/arm/cpu/armv7/mx5/clock.c > +++ b/arch/arm/cpu/armv7/mx5/clock.c > @@ -928,7 +928,9 @@ int do_mx5_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > printf("IPG %8d kHz\n", mxc_get_clock(MXC_IPG_CLK) / 1000); > printf("IPG PERCLK %8d kHz\n", mxc_get_clock(MXC_IPG_PERCLK) / 1000); > printf("DDR %8d kHz\n", mxc_get_clock(MXC_DDR_CLK) / 1000); > - > +#ifdef CONFIG_MXC_SPI > + printf("CSPI %8d kHz\n", mxc_get_clock(MXC_CSPI_CLK) / 1000); > +#endif I wondered if we want something similar for i.MX6, too. And found that we have this on i.MX6, already. But without #ifdef. http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=arch/arm/cpu/armv7/mx6/clock.c;h=a01d96f48e04377d705b7a587ec7b3ea59aee283;hb=HEAD#l407 Do we want to add the #ifdef for i.MX6, too? Or would it be nicer to drop the #ifdef in this patch to make i.MX6 and i.MX5 equal? Best regards Dirk
Hi Dirk, On Fri, Nov 16, 2012 at 4:35 AM, Dirk Behme <dirk.behme@gmail.com> wrote: > I wondered if we want something similar for i.MX6, too. And found that we > have this on i.MX6, already. But without #ifdef. > > http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=arch/arm/cpu/armv7/mx6/clock.c;h=a01d96f48e04377d705b7a587ec7b3ea59aee283;hb=HEAD#l407 > > Do we want to add the #ifdef for i.MX6, too? Or would it be nicer to drop > the #ifdef in this patch to make i.MX6 and i.MX5 equal? The reason I added the ifdef was to avoid showing the cspi clock on a board that does not use cspi. This would help not 'polluting' the clock command output. Regards, Fabio Estevam
On 16/11/2012 12:15, Fabio Estevam wrote: > Hi Dirk, > > On Fri, Nov 16, 2012 at 4:35 AM, Dirk Behme <dirk.behme@gmail.com> wrote: > >> I wondered if we want something similar for i.MX6, too. And found that we >> have this on i.MX6, already. But without #ifdef. >> >> http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=arch/arm/cpu/armv7/mx6/clock.c;h=a01d96f48e04377d705b7a587ec7b3ea59aee283;hb=HEAD#l407 >> >> Do we want to add the #ifdef for i.MX6, too? Or would it be nicer to drop >> the #ifdef in this patch to make i.MX6 and i.MX5 equal? > > The reason I added the ifdef was to avoid showing the cspi clock on a > board that does not use cspi. This would help > not 'polluting' the clock command output. > Agree. Boards that do not support SPI can have a completely wrong value,. Regards, Stefano Babic
diff --git a/arch/arm/cpu/armv7/mx5/clock.c b/arch/arm/cpu/armv7/mx5/clock.c index 1c9223f..76c2c52 100644 --- a/arch/arm/cpu/armv7/mx5/clock.c +++ b/arch/arm/cpu/armv7/mx5/clock.c @@ -928,7 +928,9 @@ int do_mx5_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) printf("IPG %8d kHz\n", mxc_get_clock(MXC_IPG_CLK) / 1000); printf("IPG PERCLK %8d kHz\n", mxc_get_clock(MXC_IPG_PERCLK) / 1000); printf("DDR %8d kHz\n", mxc_get_clock(MXC_DDR_CLK) / 1000); - +#ifdef CONFIG_MXC_SPI + printf("CSPI %8d kHz\n", mxc_get_clock(MXC_CSPI_CLK) / 1000); +#endif return 0; }