| Message ID | 1352987345-11263-1-git-send-email-tt.rantala@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Tommi Rantala <tt.rantala@gmail.com> Date: Thu, 15 Nov 2012 15:49:05 +0200 > Commit 13d782f ("sctp: Make the proc files per network namespace.") > changed the /proc/net/sctp/ struct file_operations opener functions to > use single_open_net() and seq_open_net(). > > Avoid leaking memory by using single_release_net() and seq_release_net() > as the release functions. > > Discovered with Trinity (the syscall fuzzer). > > Signed-off-by: Tommi Rantala <tt.rantala@gmail.com> > Acked-by: Neil Horman <nhorman@tuxdriver.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Tommi Rantala <tt.rantala@gmail.com> writes: > Commit 13d782f ("sctp: Make the proc files per network namespace.") > changed the /proc/net/sctp/ struct file_operations opener functions to > use single_open_net() and seq_open_net(). > > Avoid leaking memory by using single_release_net() and seq_release_net() > as the release functions. > > Discovered with Trinity (the syscall fuzzer). Doh! Thanks for catching this. Eric > - .release = single_release, > + .release = single_release_net, > }; > - .release = seq_release, > + .release = seq_release_net, > }; > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sctp/proc.c b/net/sctp/proc.c index c3bea26..9966e7b 100644 --- a/net/sctp/proc.c +++ b/net/sctp/proc.c @@ -102,7 +102,7 @@ static const struct file_operations sctp_snmp_seq_fops = { .open = sctp_snmp_seq_open, .read = seq_read, .llseek = seq_lseek, - .release = single_release, + .release = single_release_net, }; /* Set up the proc fs entry for 'snmp' object. */ @@ -251,7 +251,7 @@ static const struct file_operations sctp_eps_seq_fops = { .open = sctp_eps_seq_open, .read = seq_read, .llseek = seq_lseek, - .release = seq_release, + .release = seq_release_net, }; /* Set up the proc fs entry for 'eps' object. */ @@ -372,7 +372,7 @@ static const struct file_operations sctp_assocs_seq_fops = { .open = sctp_assocs_seq_open, .read = seq_read, .llseek = seq_lseek, - .release = seq_release, + .release = seq_release_net, }; /* Set up the proc fs entry for 'assocs' object. */ @@ -517,7 +517,7 @@ static const struct file_operations sctp_remaddr_seq_fops = { .open = sctp_remaddr_seq_open, .read = seq_read, .llseek = seq_lseek, - .release = seq_release, + .release = seq_release_net, }; int __net_init sctp_remaddr_proc_init(struct net *net)
Commit 13d782f ("sctp: Make the proc files per network namespace.") changed the /proc/net/sctp/ struct file_operations opener functions to use single_open_net() and seq_open_net(). Avoid leaking memory by using single_release_net() and seq_release_net() as the release functions. Discovered with Trinity (the syscall fuzzer). Signed-off-by: Tommi Rantala <tt.rantala@gmail.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Cc: "Eric W. Biederman" <ebiederm@xmission.com> --- net/sctp/proc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)