| Message ID | 1352473012-20500-8-git-send-email-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
Am 09.11.2012 15:56, schrieb Eduardo Habkost: > module.h is where machine_init() is defined, but qemu-fsdev-dummy.c > doesn't include it. > > The header is probably being included by accident because some other > headers are including qemu-common.h, but those headers should eventually > stop including qemu-common.h. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Acked-by: Andreas Färber <afaerber@suse.de> I'm surprised about this machine_init() use case outside a machine though... Andreas
diff --git a/fsdev/qemu-fsdev-dummy.c b/fsdev/qemu-fsdev-dummy.c index 4e700dd..300f275 100644 --- a/fsdev/qemu-fsdev-dummy.c +++ b/fsdev/qemu-fsdev-dummy.c @@ -14,6 +14,7 @@ #include <string.h> #include "qemu-fsdev.h" #include "qemu-config.h" +#include "module.h" int qemu_fsdev_add(QemuOpts *opts) {
module.h is where machine_init() is defined, but qemu-fsdev-dummy.c doesn't include it. The header is probably being included by accident because some other headers are including qemu-common.h, but those headers should eventually stop including qemu-common.h. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- fsdev/qemu-fsdev-dummy.c | 1 + 1 file changed, 1 insertion(+)