Message ID | 1352464266-22684-1-git-send-email-alexander@mezon.ru |
---|---|
State | Not Applicable |
Headers | show |
Hi Alexander, 2012/11/9 Alexander Khryukin <alexander@mezon.ru>: > > Signed-off-by: Alexander Khryukin <alexander@mezon.ru> > --- > package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch > > diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch b/package/gnutls/gnutls-2.12.20-glibc2.16.patch > new file mode 100644 > index 0000000..6b7f545 > --- /dev/null > +++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch > @@ -0,0 +1,26 @@ > +--- gnutls-2.12.20/gl/stdio.in.h > ++++ gnutls-2.12.20/gl/stdio.in.h When adding a patch to a package, we usually add a header to the patch containing a description and the SoB line. Regards,
2012/11/9 Samuel Martin <s.martin49@gmail.com> > Hi Alexander, > > 2012/11/9 Alexander Khryukin <alexander@mezon.ru>: > > > > Signed-off-by: Alexander Khryukin <alexander@mezon.ru> > > --- > > package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 > ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch > > > > diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch > b/package/gnutls/gnutls-2.12.20-glibc2.16.patch > > new file mode 100644 > > index 0000000..6b7f545 > > --- /dev/null > > +++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch > > @@ -0,0 +1,26 @@ > > +--- gnutls-2.12.20/gl/stdio.in.h > > ++++ gnutls-2.12.20/gl/stdio.in.h > When adding a patch to a package, we usually add a header to the patch > containing a description and the SoB line. > > Regards, > > -- > Sam > Looks as my mistake. In a short time i'll send good patch.
On 11/09/12 17:54, Samuel Martin wrote: > Hi Alexander, > > 2012/11/9 Alexander Khryukin<alexander@mezon.ru>: >> > >> > Signed-off-by: Alexander Khryukin<alexander@mezon.ru> >> > --- >> > package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++ >> > 1 file changed, 26 insertions(+) >> > create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch >> > >> > diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch b/package/gnutls/gnutls-2.12.20-glibc2.16.patch >> > new file mode 100644 >> > index 0000000..6b7f545 >> > --- /dev/null >> > +++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch >> > @@ -0,0 +1,26 @@ >> > +--- gnutls-2.12.20/gl/stdio.in.h >> > ++++ gnutls-2.12.20/gl/stdio.in.h > When adding a patch to a package, we usually add a header to the patch > containing a description and the SoB line. And the commit message itself should also be something more explanatory, e.g.: gnutls: fix build with glibc2.16, which doesn't declare gets() Regards, Arnout
On 11/10/12 01:55, Arnout Vandecappelle wrote: > On 11/09/12 17:54, Samuel Martin wrote: >> Hi Alexander, >> >> 2012/11/9 Alexander Khryukin<alexander@mezon.ru>: >>> > >>> > Signed-off-by: Alexander Khryukin<alexander@mezon.ru> >>> > --- >>> > package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++ >>> > 1 file changed, 26 insertions(+) >>> > create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch >>> > >>> > diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch b/package/gnutls/gnutls-2.12.20-glibc2.16.patch >>> > new file mode 100644 >>> > index 0000000..6b7f545 >>> > --- /dev/null >>> > +++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch >>> > @@ -0,0 +1,26 @@ >>> > +--- gnutls-2.12.20/gl/stdio.in.h >>> > ++++ gnutls-2.12.20/gl/stdio.in.h >> When adding a patch to a package, we usually add a header to the patch >> containing a description and the SoB line. > > And the commit message itself should also be something more explanatory, e.g.: > > gnutls: fix build with glibc2.16, which doesn't declare gets() BTW, I verified that this indeed fixes the build for glibc2.16, so with a corrected commit message and a SoB in the patch, this gets my Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout
diff --git a/package/gnutls/gnutls-2.12.20-glibc2.16.patch b/package/gnutls/gnutls-2.12.20-glibc2.16.patch new file mode 100644 index 0000000..6b7f545 --- /dev/null +++ b/package/gnutls/gnutls-2.12.20-glibc2.16.patch @@ -0,0 +1,26 @@ +--- gnutls-2.12.20/gl/stdio.in.h ++++ gnutls-2.12.20/gl/stdio.in.h +@@ -714,8 +714,10 @@ + /* It is very rare that the developer ever has full control of stdin, + so any use of gets warrants an unconditional warning. Assume it is + always declared, since it is required by C89. */ ++#ifdef HAVE_RAW_DECL_GETS + _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead"); + #endif ++#endif + + + #if @GNULIB_OBSTACK_PRINTF@ || @GNULIB_OBSTACK_PRINTF_POSIX@ +--- gnutls-2.12.20/lib/gl/stdio.in.h ++++ gnutls-2.12.20/lib/gl/stdio.in.h +@@ -714,8 +714,10 @@ + /* It is very rare that the developer ever has full control of stdin, + so any use of gets warrants an unconditional warning. Assume it is + always declared, since it is required by C89. */ ++#ifdef HAVE_RAW_DECL_GETS + _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead"); + #endif ++#endif + + + #if @GNULIB_OBSTACK_PRINTF@ || @GNULIB_OBSTACK_PRINTF_POSIX@
Signed-off-by: Alexander Khryukin <alexander@mezon.ru> --- package/gnutls/gnutls-2.12.20-glibc2.16.patch | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 package/gnutls/gnutls-2.12.20-glibc2.16.patch